Re: [PATCH] xfs: fix use-after-free on CIL context on shutdown

2020-06-19 Thread Christoph Hellwig
On Thu, Jun 11, 2020 at 12:45:03PM +1000, Dave Chinner wrote: > > From: Dave Chinner > > xlog_wait() on the CIL context can reference a freed context if the > waiter doesn't get scheduled before the CIL context is freed. This > can happen when a task is on the hard throttle and the CIL push >

Re: [PATCH] xfs: fix use-after-free on CIL context on shutdown

2020-06-15 Thread Dave Chinner
On Tue, Jun 16, 2020 at 09:16:09AM +0800, yukuai (C) wrote: > On 2020/6/11 10:45, Dave Chinner wrote: > > > > From: Dave Chinner > > > > xlog_wait() on the CIL context can reference a freed context if the > > waiter doesn't get scheduled before the CIL context is freed. This > > can happen when

Re: [PATCH] xfs: fix use-after-free on CIL context on shutdown

2020-06-15 Thread yukuai (C)
On 2020/6/11 10:45, Dave Chinner wrote: From: Dave Chinner xlog_wait() on the CIL context can reference a freed context if the waiter doesn't get scheduled before the CIL context is freed. This can happen when a task is on the hard throttle and the CIL push aborts due to a shutdown. This was

Re: [PATCH] xfs: fix use-after-free on CIL context on shutdown

2020-06-11 Thread Brian Foster
On Thu, Jun 11, 2020 at 12:45:03PM +1000, Dave Chinner wrote: > > From: Dave Chinner > > xlog_wait() on the CIL context can reference a freed context if the > waiter doesn't get scheduled before the CIL context is freed. This > can happen when a task is on the hard throttle and the CIL push >

[PATCH] xfs: fix use-after-free on CIL context on shutdown

2020-06-10 Thread Dave Chinner
From: Dave Chinner xlog_wait() on the CIL context can reference a freed context if the waiter doesn't get scheduled before the CIL context is freed. This can happen when a task is on the hard throttle and the CIL push aborts due to a shutdown. This was detected by generic/019: thread 1