Re: [PATCH] xsysace: Fix error handling in ace_setup

2019-02-20 Thread Guenter Roeck
On 2/19/19 11:09 PM, Michal Simek wrote: On 19. 02. 19 17:49, Guenter Roeck wrote: If xace hardware reports a bad version number, the error handling code in ace_setup() calls put_disk(), followed by queue cleanup. However, since the disk data structure has the queue pointer set, put_disk() also

Re: [PATCH] xsysace: Fix error handling in ace_setup

2019-02-19 Thread Michal Simek
On 19. 02. 19 17:49, Guenter Roeck wrote: > If xace hardware reports a bad version number, the error handling code > in ace_setup() calls put_disk(), followed by queue cleanup. However, since > the disk data structure has the queue pointer set, put_disk() also > cleans and releases the queue. This

[PATCH] xsysace: Fix error handling in ace_setup

2019-02-19 Thread Guenter Roeck
If xace hardware reports a bad version number, the error handling code in ace_setup() calls put_disk(), followed by queue cleanup. However, since the disk data structure has the queue pointer set, put_disk() also cleans and releases the queue. This results in blk_cleanup_queue() accessing an