Re: [PATCH] zpool: add EXPORT_SYMBOL for functions

2015-05-29 Thread Andrew Morton
On Fri, 29 May 2015 12:35:46 -0400 Dan Streetman wrote: > On Fri, May 29, 2015 at 12:30 PM, Christoph Hellwig > wrote: > > On Fri, May 29, 2015 at 11:36:05AM -0400, Dan Streetman wrote: > >> because they are available for public use, per zpool.h? If, e.g., > >> zram ever started using zpool,

Re: [PATCH] zpool: add EXPORT_SYMBOL for functions

2015-05-29 Thread Dan Streetman
On Fri, May 29, 2015 at 12:30 PM, Christoph Hellwig wrote: > On Fri, May 29, 2015 at 11:36:05AM -0400, Dan Streetman wrote: >> because they are available for public use, per zpool.h? If, e.g., >> zram ever started using zpool, it would need them exported, wouldn't >> it? > > If you want to use

Re: [PATCH] zpool: add EXPORT_SYMBOL for functions

2015-05-29 Thread Christoph Hellwig
On Fri, May 29, 2015 at 11:36:05AM -0400, Dan Streetman wrote: > because they are available for public use, per zpool.h? If, e.g., > zram ever started using zpool, it would need them exported, wouldn't > it? If you want to use it in ram export it in the same series as those changes, and explain

Re: [PATCH] zpool: add EXPORT_SYMBOL for functions

2015-05-29 Thread Dan Streetman
On Fri, May 29, 2015 at 11:22 AM, Christoph Hellwig wrote: > On Fri, May 29, 2015 at 11:09:32AM -0400, Dan Streetman wrote: >> Export the zpool functions that should be exported. > > Why? because they are available for public use, per zpool.h? If, e.g., zram ever started using zpool, it would

Re: [PATCH] zpool: add EXPORT_SYMBOL for functions

2015-05-29 Thread Christoph Hellwig
On Fri, May 29, 2015 at 11:09:32AM -0400, Dan Streetman wrote: > Export the zpool functions that should be exported. Why? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH] zpool: add EXPORT_SYMBOL for functions

2015-05-29 Thread Dan Streetman
Export the zpool functions that should be exported. Signed-off-by: Dan Streetman --- mm/zpool.c | 9 + 1 file changed, 9 insertions(+) diff --git a/mm/zpool.c b/mm/zpool.c index 6b1f103..884659d 100644 --- a/mm/zpool.c +++ b/mm/zpool.c @@ -188,6 +188,7 @@ struct zpool

Re: [PATCH] zpool: add EXPORT_SYMBOL for functions

2015-05-29 Thread Dan Streetman
On Fri, May 29, 2015 at 11:22 AM, Christoph Hellwig h...@infradead.org wrote: On Fri, May 29, 2015 at 11:09:32AM -0400, Dan Streetman wrote: Export the zpool functions that should be exported. Why? because they are available for public use, per zpool.h? If, e.g., zram ever started using

Re: [PATCH] zpool: add EXPORT_SYMBOL for functions

2015-05-29 Thread Christoph Hellwig
On Fri, May 29, 2015 at 11:36:05AM -0400, Dan Streetman wrote: because they are available for public use, per zpool.h? If, e.g., zram ever started using zpool, it would need them exported, wouldn't it? If you want to use it in ram export it in the same series as those changes, and explain

[PATCH] zpool: add EXPORT_SYMBOL for functions

2015-05-29 Thread Dan Streetman
Export the zpool functions that should be exported. Signed-off-by: Dan Streetman ddstr...@ieee.org --- mm/zpool.c | 9 + 1 file changed, 9 insertions(+) diff --git a/mm/zpool.c b/mm/zpool.c index 6b1f103..884659d 100644 --- a/mm/zpool.c +++ b/mm/zpool.c @@ -188,6 +188,7 @@ struct zpool

Re: [PATCH] zpool: add EXPORT_SYMBOL for functions

2015-05-29 Thread Christoph Hellwig
On Fri, May 29, 2015 at 11:09:32AM -0400, Dan Streetman wrote: Export the zpool functions that should be exported. Why? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] zpool: add EXPORT_SYMBOL for functions

2015-05-29 Thread Dan Streetman
On Fri, May 29, 2015 at 12:30 PM, Christoph Hellwig h...@infradead.org wrote: On Fri, May 29, 2015 at 11:36:05AM -0400, Dan Streetman wrote: because they are available for public use, per zpool.h? If, e.g., zram ever started using zpool, it would need them exported, wouldn't it? If you want

Re: [PATCH] zpool: add EXPORT_SYMBOL for functions

2015-05-29 Thread Andrew Morton
On Fri, 29 May 2015 12:35:46 -0400 Dan Streetman ddstr...@ieee.org wrote: On Fri, May 29, 2015 at 12:30 PM, Christoph Hellwig h...@infradead.org wrote: On Fri, May 29, 2015 at 11:36:05AM -0400, Dan Streetman wrote: because they are available for public use, per zpool.h? If, e.g., zram