Re: [PATCH] zram: fix possible use after free in zcomp_create()

2015-09-07 Thread Luis Henriques
On Mon, Sep 07, 2015 at 10:33:32PM +0900, Sergey Senozhatsky wrote: > On (09/07/15 13:53), Luis Henriques wrote: > > > On (09/07/15 11:33), Luis Henriques wrote: > > > > zcomp_create() verifies the success of > > > > zcomp_strm_{multi,siggle}_create() > > > > through comp->stream, which can

Re: [PATCH] zram: fix possible use after free in zcomp_create()

2015-09-07 Thread Sergey Senozhatsky
On (09/07/15 13:53), Luis Henriques wrote: > > On (09/07/15 11:33), Luis Henriques wrote: > > > zcomp_create() verifies the success of zcomp_strm_{multi,siggle}_create() > > > through comp->stream, which can potentially be pointing to memory that was > > > freed if these functions returned an

Re: [PATCH] zram: fix possible use after free in zcomp_create()

2015-09-07 Thread Luis Henriques
On Mon, Sep 07, 2015 at 08:11:48PM +0900, Sergey Senozhatsky wrote: > On (09/07/15 11:33), Luis Henriques wrote: > > zcomp_create() verifies the success of zcomp_strm_{multi,siggle}_create() > > through comp->stream, which can potentially be pointing to memory that was > > freed if these functions

Re: [PATCH] zram: fix possible use after free in zcomp_create()

2015-09-07 Thread Sergey Senozhatsky
On (09/07/15 11:33), Luis Henriques wrote: > zcomp_create() verifies the success of zcomp_strm_{multi,siggle}_create() > through comp->stream, which can potentially be pointing to memory that was > freed if these functions returned an error. > good catch. we probably better start checking the

[PATCH] zram: fix possible use after free in zcomp_create()

2015-09-07 Thread Luis Henriques
zcomp_create() verifies the success of zcomp_strm_{multi,siggle}_create() through comp->stream, which can potentially be pointing to memory that was freed if these functions returned an error. Fixes: beca3ec71fe5 ("zram: add multi stream functionality") Cc: sta...@vger.kernel.org Signed-off-by:

Re: [PATCH] zram: fix possible use after free in zcomp_create()

2015-09-07 Thread Luis Henriques
On Mon, Sep 07, 2015 at 08:11:48PM +0900, Sergey Senozhatsky wrote: > On (09/07/15 11:33), Luis Henriques wrote: > > zcomp_create() verifies the success of zcomp_strm_{multi,siggle}_create() > > through comp->stream, which can potentially be pointing to memory that was > > freed if these functions

[PATCH] zram: fix possible use after free in zcomp_create()

2015-09-07 Thread Luis Henriques
zcomp_create() verifies the success of zcomp_strm_{multi,siggle}_create() through comp->stream, which can potentially be pointing to memory that was freed if these functions returned an error. Fixes: beca3ec71fe5 ("zram: add multi stream functionality") Cc: sta...@vger.kernel.org Signed-off-by:

Re: [PATCH] zram: fix possible use after free in zcomp_create()

2015-09-07 Thread Sergey Senozhatsky
On (09/07/15 11:33), Luis Henriques wrote: > zcomp_create() verifies the success of zcomp_strm_{multi,siggle}_create() > through comp->stream, which can potentially be pointing to memory that was > freed if these functions returned an error. > good catch. we probably better start checking the

Re: [PATCH] zram: fix possible use after free in zcomp_create()

2015-09-07 Thread Luis Henriques
On Mon, Sep 07, 2015 at 10:33:32PM +0900, Sergey Senozhatsky wrote: > On (09/07/15 13:53), Luis Henriques wrote: > > > On (09/07/15 11:33), Luis Henriques wrote: > > > > zcomp_create() verifies the success of > > > > zcomp_strm_{multi,siggle}_create() > > > > through comp->stream, which can

Re: [PATCH] zram: fix possible use after free in zcomp_create()

2015-09-07 Thread Sergey Senozhatsky
On (09/07/15 13:53), Luis Henriques wrote: > > On (09/07/15 11:33), Luis Henriques wrote: > > > zcomp_create() verifies the success of zcomp_strm_{multi,siggle}_create() > > > through comp->stream, which can potentially be pointing to memory that was > > > freed if these functions returned an