Re: [PATCH] zram: idle writeback fixes and cleanup

2018-12-27 Thread Minchan Kim
Hi Sergey, On Thu, Dec 27, 2018 at 11:26:24AM +0900, Sergey Senozhatsky wrote: > On (12/24/18 12:35), Minchan Kim wrote: > [..] > > @@ -645,10 +680,13 @@ static ssize_t writeback_store(struct device *dev, > > bvec.bv_len = PAGE_SIZE; > > bvec.bv_offset = 0; > > > > -

Re: [PATCH] zram: idle writeback fixes and cleanup

2018-12-26 Thread Sergey Senozhatsky
On (12/24/18 12:35), Minchan Kim wrote: [..] > @@ -645,10 +680,13 @@ static ssize_t writeback_store(struct device *dev, > bvec.bv_len = PAGE_SIZE; > bvec.bv_offset = 0; > > - if (zram->stop_writeback) { > + spin_lock(>wb_limit_lock); > +

[PATCH] zram: idle writeback fixes and cleanup

2018-12-23 Thread Minchan Kim
This patch includes some fixes and cleanup for idle-page writeback. 1. writeback_limit interface Now writeback_limit interface is rather conusing. For example, once writeback limit budget is exausted, admin can see 0 from /sys/block/zramX/writeback_limit which is same semantic with disable