Re: [PATCH-next] misc: mic: Use PTR_ERR_OR_ZERO

2018-01-26 Thread Ashutosh Dixit
On Tue, Jan 23 2018 at 02:55:19 PM, Al Viro wrote: > On Tue, Jan 23, 2018 at 03:10:09PM -0500, Christopher Díaz Riveros wrote: >> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR >> >> This issue was detected by using the Coccinelle software. > > ... and that's

Re: [PATCH-next] misc: mic: Use PTR_ERR_OR_ZERO

2018-01-26 Thread Ashutosh Dixit
On Tue, Jan 23 2018 at 02:55:19 PM, Al Viro wrote: > On Tue, Jan 23, 2018 at 03:10:09PM -0500, Christopher Díaz Riveros wrote: >> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR >> >> This issue was detected by using the Coccinelle software. > > ... and that's a wonderful demonstration

Re: [PATCH-next] misc: mic: Use PTR_ERR_OR_ZERO

2018-01-24 Thread walter harms
Am 23.01.2018 21:10, schrieb Christopher Díaz Riveros: > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Christopher Díaz Riveros > --- > drivers/misc/mic/scif/scif_epd.h | 4 +---

Re: [PATCH-next] misc: mic: Use PTR_ERR_OR_ZERO

2018-01-24 Thread walter harms
Am 23.01.2018 21:10, schrieb Christopher Díaz Riveros: > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Christopher Díaz Riveros > --- > drivers/misc/mic/scif/scif_epd.h | 4 +--- > 1 file changed, 1

Re: [PATCH-next] misc: mic: Use PTR_ERR_OR_ZERO

2018-01-23 Thread Al Viro
On Tue, Jan 23, 2018 at 03:10:09PM -0500, Christopher Díaz Riveros wrote: > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > This issue was detected by using the Coccinelle software. ... and that's a wonderful demonstration of the reasons why PTR_ERR_OR_ZERO() is in bad taste. Look

Re: [PATCH-next] misc: mic: Use PTR_ERR_OR_ZERO

2018-01-23 Thread Al Viro
On Tue, Jan 23, 2018 at 03:10:09PM -0500, Christopher Díaz Riveros wrote: > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > This issue was detected by using the Coccinelle software. ... and that's a wonderful demonstration of the reasons why PTR_ERR_OR_ZERO() is in bad taste. Look

[PATCH-next] misc: mic: Use PTR_ERR_OR_ZERO

2018-01-23 Thread Christopher Díaz Riveros
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR This issue was detected by using the Coccinelle software. Signed-off-by: Christopher Díaz Riveros --- drivers/misc/mic/scif/scif_epd.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH-next] misc: mic: Use PTR_ERR_OR_ZERO

2018-01-23 Thread Christopher Díaz Riveros
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR This issue was detected by using the Coccinelle software. Signed-off-by: Christopher Díaz Riveros --- drivers/misc/mic/scif/scif_epd.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH-next] misc: mic: Use PTR_ERR_OR_ZERO

2018-01-23 Thread Christopher Díaz Riveros
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR This issue was detected by using the Coccinelle software. Signed-off-by: Christopher Díaz Riveros --- drivers/misc/mic/scif/scif_epd.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH-next] misc: mic: Use PTR_ERR_OR_ZERO

2018-01-23 Thread Christopher Díaz Riveros
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR This issue was detected by using the Coccinelle software. Signed-off-by: Christopher Díaz Riveros --- drivers/misc/mic/scif/scif_epd.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git