On Sat, 2013-08-24 at 08:18 -0700, Christoph Hellwig wrote:
> > static int
> > +transport_generic_get_mem_bidi(struct se_cmd *cmd)
>
> Except for the fields touched in struct se_cmd this is a duplication
> of transport_generic_get_mem. I'd suggest to factor that one into
> a new helper:
>
>
> static int
> +transport_generic_get_mem_bidi(struct se_cmd *cmd)
Except for the fields touched in struct se_cmd this is a duplication
of transport_generic_get_mem. I'd suggest to factor that one into
a new helper:
static int
target_alloc_sgl(struct scatterlist **sgl, unsigned int **nents,
static int
+transport_generic_get_mem_bidi(struct se_cmd *cmd)
Except for the fields touched in struct se_cmd this is a duplication
of transport_generic_get_mem. I'd suggest to factor that one into
a new helper:
static int
target_alloc_sgl(struct scatterlist **sgl, unsigned int **nents,
On Sat, 2013-08-24 at 08:18 -0700, Christoph Hellwig wrote:
static int
+transport_generic_get_mem_bidi(struct se_cmd *cmd)
Except for the fields touched in struct se_cmd this is a duplication
of transport_generic_get_mem. I'd suggest to factor that one into
a new helper:
static int
From: Nicholas Bellinger
This adds transport_generic_get_mem_bidi() to perform scatterlist
allocation for bidirectional commands.
Also, update transport_generic_new_cmd() to call this new function
when SCF_BIDI has been set.
v2 Changes:
- Use SCF_COMPARE_AND_WRITE instead of CDB based check
From: Nicholas Bellinger n...@daterainc.com
This adds transport_generic_get_mem_bidi() to perform scatterlist
allocation for bidirectional commands.
Also, update transport_generic_new_cmd() to call this new function
when SCF_BIDI has been set.
v2 Changes:
- Use SCF_COMPARE_AND_WRITE instead
6 matches
Mail list logo
