Re: [PATCH -mm 1/2] kexec/i386: kexec page table code clean up - add arch_kimage

2008-01-14 Thread Simon Horman
On Mon, Jan 14, 2008 at 01:29:36PM +, Ian Campbell wrote: > > On Thu, 2008-01-10 at 17:15 +0900, Simon Horman wrote: > > > Have you tested Xen too? Does it run into issues with this change? > > > > Xen will need to be updated for this change but it shouldn't be a big > > deal. Basically

Re: [PATCH -mm 1/2] kexec/i386: kexec page table code clean up - add arch_kimage

2008-01-14 Thread Ian Campbell
On Thu, 2008-01-10 at 17:15 +0900, Simon Horman wrote: > > Have you tested Xen too? Does it run into issues with this change? > > Xen will need to be updated for this change but it shouldn't be a big > deal. Basically right now it calls __ma() (which is kind of like __pa()) > on kexec_pgd and

Re: [PATCH -mm 1/2] kexec/i386: kexec page table code clean up - add arch_kimage

2008-01-14 Thread Ian Campbell
On Thu, 2008-01-10 at 17:15 +0900, Simon Horman wrote: Have you tested Xen too? Does it run into issues with this change? Xen will need to be updated for this change but it shouldn't be a big deal. Basically right now it calls __ma() (which is kind of like __pa()) on kexec_pgd and

Re: [PATCH -mm 1/2] kexec/i386: kexec page table code clean up - add arch_kimage

2008-01-14 Thread Simon Horman
On Mon, Jan 14, 2008 at 01:29:36PM +, Ian Campbell wrote: On Thu, 2008-01-10 at 17:15 +0900, Simon Horman wrote: Have you tested Xen too? Does it run into issues with this change? Xen will need to be updated for this change but it shouldn't be a big deal. Basically right now it

Re: [PATCH -mm 1/2] kexec/i386: kexec page table code clean up - add arch_kimage

2008-01-10 Thread Simon Horman
[ CCing Magnus Damm and Ian Campbell ] On Wed, Jan 09, 2008 at 08:14:23PM -0500, Vivek Goyal wrote: > On Wed, Jan 09, 2008 at 10:57:47AM +0800, Huang, Ying wrote: > > This patch add an architecture specific struct arch_kimage into struct > > kimage. Three pointers to page table pages used by

Re: [PATCH -mm 1/2] kexec/i386: kexec page table code clean up - add arch_kimage

2008-01-10 Thread Simon Horman
[ CCing Magnus Damm and Ian Campbell ] On Wed, Jan 09, 2008 at 08:14:23PM -0500, Vivek Goyal wrote: On Wed, Jan 09, 2008 at 10:57:47AM +0800, Huang, Ying wrote: This patch add an architecture specific struct arch_kimage into struct kimage. Three pointers to page table pages used by kexec are

Re: [PATCH -mm 1/2] kexec/i386: kexec page table code clean up - add arch_kimage

2008-01-09 Thread Huang, Ying
On Wed, 2008-01-09 at 20:14 -0500, Vivek Goyal wrote: [...] > > > > +static void alloc_page_tables(struct kimage *image) > > +{ > > This is too generic a name. How about something like > arch_alloc_kexec_page_tables() OK, I will change it. > > + image->arch_kimage.pgd = (pgd_t

Re: [PATCH -mm 1/2] kexec/i386: kexec page table code clean up - add arch_kimage

2008-01-09 Thread Vivek Goyal
On Wed, Jan 09, 2008 at 10:57:47AM +0800, Huang, Ying wrote: > This patch add an architecture specific struct arch_kimage into struct > kimage. Three pointers to page table pages used by kexec are added to > struct arch_kimage. The page tables pages are dynamically allocated in >

Re: [PATCH -mm 1/2] kexec/i386: kexec page table code clean up - add arch_kimage

2008-01-09 Thread Vivek Goyal
On Wed, Jan 09, 2008 at 10:57:47AM +0800, Huang, Ying wrote: This patch add an architecture specific struct arch_kimage into struct kimage. Three pointers to page table pages used by kexec are added to struct arch_kimage. The page tables pages are dynamically allocated in machine_kexec_prepare

Re: [PATCH -mm 1/2] kexec/i386: kexec page table code clean up - add arch_kimage

2008-01-09 Thread Huang, Ying
On Wed, 2008-01-09 at 20:14 -0500, Vivek Goyal wrote: [...] +static void alloc_page_tables(struct kimage *image) +{ This is too generic a name. How about something like arch_alloc_kexec_page_tables() OK, I will change it. + image-arch_kimage.pgd = (pgd_t

[PATCH -mm 1/2] kexec/i386: kexec page table code clean up - add arch_kimage

2008-01-08 Thread Huang, Ying
This patch add an architecture specific struct arch_kimage into struct kimage. Three pointers to page table pages used by kexec are added to struct arch_kimage. The page tables pages are dynamically allocated in machine_kexec_prepare instead of statically from BSS segment. This will save up to 20k

[PATCH -mm 1/2] kexec/i386: kexec page table code clean up - add arch_kimage

2008-01-08 Thread Huang, Ying
This patch add an architecture specific struct arch_kimage into struct kimage. Three pointers to page table pages used by kexec are added to struct arch_kimage. The page tables pages are dynamically allocated in machine_kexec_prepare instead of statically from BSS segment. This will save up to 20k