Re: [PATCH -mm 2/2] kexec/i386: kexec page table code clean up - page table setup in C

2008-01-14 Thread Ian Campbell
On Thu, 2008-01-10 at 16:21 +0900, Simon Horman wrote: > [ CCing Ian Campbell who handles much of the maintenance of kexec in Xen ] > > On Thu, Jan 10, 2008 at 10:08:09AM +0800, Huang, Ying wrote: > > On Wed, 2008-01-09 at 20:05 -0500, Vivek Goyal wrote: > > > On Wed, Jan 09, 2008 at 10:57:50AM

Re: [PATCH -mm 2/2] kexec/i386: kexec page table code clean up - page table setup in C

2008-01-09 Thread Simon Horman
[ CCing Ian Campbell who handles much of the maintenance of kexec in Xen ] On Thu, Jan 10, 2008 at 10:08:09AM +0800, Huang, Ying wrote: > On Wed, 2008-01-09 at 20:05 -0500, Vivek Goyal wrote: > > On Wed, Jan 09, 2008 at 10:57:50AM +0800, Huang, Ying wrote: > > > This patch transforms the kexec pag

Re: [PATCH -mm 2/2] kexec/i386: kexec page table code clean up - page table setup in C

2008-01-09 Thread Huang, Ying
On Wed, 2008-01-09 at 20:05 -0500, Vivek Goyal wrote: > On Wed, Jan 09, 2008 at 10:57:50AM +0800, Huang, Ying wrote: > > This patch transforms the kexec page tables setup code from asseumbler > > code to iC code in machine_kexec_prepare. This improves readability and > > reduces code line number. >

Re: [PATCH -mm 2/2] kexec/i386: kexec page table code clean up - page table setup in C

2008-01-09 Thread Vivek Goyal
On Wed, Jan 09, 2008 at 10:57:50AM +0800, Huang, Ying wrote: > This patch transforms the kexec page tables setup code from asseumbler > code to iC code in machine_kexec_prepare. This improves readability and > reduces code line number. > I think this will create issues for Xen. Initially page tab

[PATCH -mm 2/2] kexec/i386: kexec page table code clean up - page table setup in C

2008-01-08 Thread Huang, Ying
This patch transforms the kexec page tables setup code from assembler code to C code in machine_kexec_prepare. This improves readability and reduces code line number. Signed-off-by: Huang Ying <[EMAIL PROTECTED]> --- arch/x86/kernel/machine_kexec_32.c | 50 +++ arch/x86/kernel/re