Re: [PATCH -mm 5/9] netconsole: Introduce dev_status member

2007-07-07 Thread Satyam Sharma
Hi Stephen, On Thu, 5 Jul 2007, Stephen Hemminger wrote: > On Wed, 4 Jul 2007 08:56:42 -0500 > Matt Mackall <[EMAIL PROTECTED]> wrote: > [...] > > > + if (nt->dev_status) { > > > > Why not simply call net_dev_is_up? > > The flags field values are really BSD legacy-ish stuff and should not be > u

Re: [PATCH -mm 5/9] netconsole: Introduce dev_status member

2007-07-05 Thread Stephen Hemminger
On Wed, 4 Jul 2007 08:56:42 -0500 Matt Mackall <[EMAIL PROTECTED]> wrote: > On Wed, Jul 04, 2007 at 04:38:04PM +0530, Satyam Sharma wrote: > > From: Satyam Sharma <[EMAIL PROTECTED]> > > > > [5/9] netconsole: Introduce dev_status member > > > > Introduce a new member in netconsole_target that tr

Re: [PATCH -mm 5/9] netconsole: Introduce dev_status member

2007-07-05 Thread Satyam Sharma
On Wed, 4 Jul 2007, Joel Becker wrote: > On Wed, Jul 04, 2007 at 04:38:04PM +0530, Satyam Sharma wrote: > > - if (!(event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME)) > > - goto done; > > + if (!(event == NETDEV_UP || event == NETDEV_DOWN || > > + event == NETDEV_CHANG

Re: [PATCH -mm 5/9] netconsole: Introduce dev_status member

2007-07-04 Thread Joel Becker
On Wed, Jul 04, 2007 at 04:38:04PM +0530, Satyam Sharma wrote: > - if (!(event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME)) > - goto done; > + if (!(event == NETDEV_UP || event == NETDEV_DOWN || > + event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME)) > +

Re: [PATCH -mm 5/9] netconsole: Introduce dev_status member

2007-07-04 Thread Satyam Sharma
On Wed, 4 Jul 2007, Matt Mackall wrote: > On Wed, Jul 04, 2007 at 04:38:04PM +0530, Satyam Sharma wrote: > > [...] > > +/* > > + * Why no net_dev_is_up() in netdevice.h? The kernel could lose a lot of > > + * weight if only netdevice.h had the good sense to export such a function. > > + * Oh well .

Re: [PATCH -mm 5/9] netconsole: Introduce dev_status member

2007-07-04 Thread Matt Mackall
On Wed, Jul 04, 2007 at 04:38:04PM +0530, Satyam Sharma wrote: > From: Satyam Sharma <[EMAIL PROTECTED]> > > [5/9] netconsole: Introduce dev_status member > > Introduce a new member in netconsole_target that tracks the status (up or > down) of the underlying interface network device that the spec

[PATCH -mm 5/9] netconsole: Introduce dev_status member

2007-07-04 Thread Satyam Sharma
From: Satyam Sharma <[EMAIL PROTECTED]> [5/9] netconsole: Introduce dev_status member Introduce a new member in netconsole_target that tracks the status (up or down) of the underlying interface network device that the specific logging target netpoll is attached to. We then join this up with the