Re: [PATCH -mm v2 2/2] mm: get rid of __GFP_KMEMCG

2014-04-02 Thread Vladimir Davydov
On 04/02/2014 04:48 AM, Greg Thelen wrote: > diff --git a/include/linux/slab.h b/include/linux/slab.h > index 3dd389aa91c7..6d6959292e00 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -358,17 +358,6 @@ kmem_cache_alloc_node_trace(struct kmem_cache *s, > #include > #endif

Re: [PATCH -mm v2 2/2] mm: get rid of __GFP_KMEMCG

2014-04-02 Thread Vladimir Davydov
On 04/02/2014 04:48 AM, Greg Thelen wrote: diff --git a/include/linux/slab.h b/include/linux/slab.h index 3dd389aa91c7..6d6959292e00 100644 --- a/include/linux/slab.h +++ b/include/linux/slab.h @@ -358,17 +358,6 @@ kmem_cache_alloc_node_trace(struct kmem_cache *s, #include linux/slub_def.h

Re: [PATCH -mm v2 2/2] mm: get rid of __GFP_KMEMCG

2014-04-01 Thread Greg Thelen
On Tue, Apr 01 2014, Vladimir Davydov wrote: > Currently to allocate a page that should be charged to kmemcg (e.g. > threadinfo), we pass __GFP_KMEMCG flag to the page allocator. The page > allocated is then to be freed by free_memcg_kmem_pages. Apart from > looking asymmetrical, this also

[PATCH -mm v2 2/2] mm: get rid of __GFP_KMEMCG

2014-04-01 Thread Vladimir Davydov
Currently to allocate a page that should be charged to kmemcg (e.g. threadinfo), we pass __GFP_KMEMCG flag to the page allocator. The page allocated is then to be freed by free_memcg_kmem_pages. Apart from looking asymmetrical, this also requires intrusion to the general allocation path. So let's

[PATCH -mm v2 2/2] mm: get rid of __GFP_KMEMCG

2014-04-01 Thread Vladimir Davydov
Currently to allocate a page that should be charged to kmemcg (e.g. threadinfo), we pass __GFP_KMEMCG flag to the page allocator. The page allocated is then to be freed by free_memcg_kmem_pages. Apart from looking asymmetrical, this also requires intrusion to the general allocation path. So let's

Re: [PATCH -mm v2 2/2] mm: get rid of __GFP_KMEMCG

2014-04-01 Thread Greg Thelen
On Tue, Apr 01 2014, Vladimir Davydov vdavy...@parallels.com wrote: Currently to allocate a page that should be charged to kmemcg (e.g. threadinfo), we pass __GFP_KMEMCG flag to the page allocator. The page allocated is then to be freed by free_memcg_kmem_pages. Apart from looking