Re: [PATCH -next] ASoC: Intel: bytcht_es8316: Set correct platform drvdata in snd_byt_cht_es8316_mc_probe()

2019-01-09 Thread Dan Carpenter
On Wed, Jan 09, 2019 at 10:33:38AM +0100, Hans de Goede wrote: > Hi, > > On 09-01-19 10:29, Dan Carpenter wrote: > > I think the correct fix is actually this (untested): > > Right, I'm pretty sure the soc framework depends on dev_get_drvdata > returning the snd_soc_card and I forgot about this

Re: [PATCH -next] ASoC: Intel: bytcht_es8316: Set correct platform drvdata in snd_byt_cht_es8316_mc_probe()

2019-01-09 Thread Hans de Goede
Hi, On 09-01-19 10:29, Dan Carpenter wrote: I think the correct fix is actually this (untested): Right, I'm pretty sure the soc framework depends on dev_get_drvdata returning the snd_soc_card and I forgot about this when adding the remove function. Wei Yongjun, thank you for catching this.

Re: [PATCH -next] ASoC: Intel: bytcht_es8316: Set correct platform drvdata in snd_byt_cht_es8316_mc_probe()

2019-01-09 Thread Dan Carpenter
I think the correct fix is actually this (untested): diff --git a/sound/soc/intel/boards/bytcht_es8316.c b/sound/soc/intel/boards/bytcht_es8316.c index cdf2061e7613..fa9c4cf97686 100644 --- a/sound/soc/intel/boards/bytcht_es8316.c +++ b/sound/soc/intel/boards/bytcht_es8316.c @@ -544,7 +544,8 @@

[PATCH -next] ASoC: Intel: bytcht_es8316: Set correct platform drvdata in snd_byt_cht_es8316_mc_probe()

2019-01-09 Thread Wei Yongjun
The snd_byt_cht_es8316_mc_remove() use the platform drvdata as a type of 'struct byt_cht_es8316_private', but snd_byt_cht_es8316_mc_probe() set it to 'struct snd_soc_card', fix to pass correct platform drvdata to platform_set_drvdata(). Fixes: 0d3e91da0750 ("ASoC: Intel: bytcht_es8316: Add