Re: [PATCH -next] ASoC: samsung: i2s: Fix return value check in i2s_create_secondary_device()

2019-02-18 Thread Sylwester Nawrocki
On 2/16/19 02:20, Wei Yongjun wrote: > In case of error, the function platform_device_register_simple() returns > ERR_PTR() and never returns NULL. The NULL test in the return value > check should be replaced with IS_ERR(). Thanks for the patch, it looks good but I have already prepared other fix

Re: [PATCH -next] ASoC: samsung: i2s: Fix return value check in i2s_create_secondary_device()

2019-02-18 Thread Krzysztof Kozlowski
On Sat, 16 Feb 2019 at 02:07, Wei Yongjun wrote: > > In case of error, the function platform_device_register_simple() returns > ERR_PTR() and never returns NULL. The NULL test in the return value > check should be replaced with IS_ERR(). > > Fixes: 7196c64c7d0c ("ASoC: samsung: i2s: Restore

[PATCH -next] ASoC: samsung: i2s: Fix return value check in i2s_create_secondary_device()

2019-02-15 Thread Wei Yongjun
In case of error, the function platform_device_register_simple() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: 7196c64c7d0c ("ASoC: samsung: i2s: Restore support for the secondary PCM") Signed-off-by: Wei Yongjun ---