Re: [PATCH -next] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-06 Thread Andreas Kemnade
On Sat, 6 Mar 2021 21:19:38 +0100 Jonathan Neuschäfer wrote: [...] > > > > + case NTXEC_VERSION_TOLINO_SHINE2: > > > > + has_rtc = false; > > > > + ec->regmap = devm_regmap_init(ec->dev, NULL, > > > > + ec->regmap, > >

Re: [PATCH -next] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-06 Thread Jonathan Neuschäfer
On Sat, Mar 06, 2021 at 08:42:19PM +0100, Andreas Kemnade wrote: > On Sat, 6 Mar 2021 20:14:46 +0100 > Jonathan Neuschäfer wrote: [...] > > > +/* some firmware versions do not ack written data, add a wrapper */ > > > +static const struct regmap_config regmap_config_noack = { > > > + .name =

Re: [PATCH -next] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-06 Thread Andreas Kemnade
On Sat, 6 Mar 2021 20:14:46 +0100 Jonathan Neuschäfer wrote: > Hi, > > (Cc'ing Mark Brown because of the regmap related questions) > > On Sat, Mar 06, 2021 at 07:13:14PM +0100, Andreas Kemnade wrote: > > Add the version of the EC in the Tolino Shine 2 HD > > to the supported versions. It seems

Re: [PATCH -next] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-06 Thread Jonathan Neuschäfer
Hi, (Cc'ing Mark Brown because of the regmap related questions) On Sat, Mar 06, 2021 at 07:13:14PM +0100, Andreas Kemnade wrote: > Add the version of the EC in the Tolino Shine 2 HD > to the supported versions. It seems not to have an RTC > and does not ack data written to it. > The vendor

[PATCH -next] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-06 Thread Andreas Kemnade
Add the version of the EC in the Tolino Shine 2 HD to the supported versions. It seems not to have an RTC and does not ack data written to it. The vendor kernel happily ignores write errors, using I2C via userspace i2c-set also shows the error. So add a quirk to ignore that error. PWM can be