Re: [PATCH -next] net: dsa: mv88e6xxx: Fix build warning when CONFIG_NET_DSA_LEGACY is n

2019-03-04 Thread Zhangshaokun
Hi Andrew, On 2019/3/4 22:57, Andrew Lunn wrote: > On Mon, Mar 04, 2019 at 10:16:08PM +0800, Zhangshaokun wrote: >> Hi Andrew, >> >> On 2019/3/4 21:26, Andrew Lunn wrote: >>> On Mon, Mar 04, 2019 at 08:43:01PM +0800, Shaokun Zhang wrote: When CONFIG_NET_DSA_LEGACY is n, there is a GCC bulid w

Re: [PATCH -next] net: dsa: mv88e6xxx: Fix build warning when CONFIG_NET_DSA_LEGACY is n

2019-03-04 Thread Florian Fainelli
On 3/4/19 10:31 AM, Heiner Kallweit wrote: > On 04.03.2019 19:24, Florian Fainelli wrote: >> On 3/4/19 10:18 AM, Heiner Kallweit wrote: >>> On 04.03.2019 15:57, Andrew Lunn wrote: On Mon, Mar 04, 2019 at 10:16:08PM +0800, Zhangshaokun wrote: > Hi Andrew, > > On 2019/3/4 21:26, Andr

Re: [PATCH -next] net: dsa: mv88e6xxx: Fix build warning when CONFIG_NET_DSA_LEGACY is n

2019-03-04 Thread Heiner Kallweit
On 04.03.2019 19:24, Florian Fainelli wrote: > On 3/4/19 10:18 AM, Heiner Kallweit wrote: >> On 04.03.2019 15:57, Andrew Lunn wrote: >>> On Mon, Mar 04, 2019 at 10:16:08PM +0800, Zhangshaokun wrote: Hi Andrew, On 2019/3/4 21:26, Andrew Lunn wrote: > On Mon, Mar 04, 2019 at 08:43:

Re: [PATCH -next] net: dsa: mv88e6xxx: Fix build warning when CONFIG_NET_DSA_LEGACY is n

2019-03-04 Thread Florian Fainelli
On 3/4/19 10:18 AM, Heiner Kallweit wrote: > On 04.03.2019 15:57, Andrew Lunn wrote: >> On Mon, Mar 04, 2019 at 10:16:08PM +0800, Zhangshaokun wrote: >>> Hi Andrew, >>> >>> On 2019/3/4 21:26, Andrew Lunn wrote: On Mon, Mar 04, 2019 at 08:43:01PM +0800, Shaokun Zhang wrote: > When CONFIG_NE

Re: [PATCH -next] net: dsa: mv88e6xxx: Fix build warning when CONFIG_NET_DSA_LEGACY is n

2019-03-04 Thread Heiner Kallweit
On 04.03.2019 15:57, Andrew Lunn wrote: > On Mon, Mar 04, 2019 at 10:16:08PM +0800, Zhangshaokun wrote: >> Hi Andrew, >> >> On 2019/3/4 21:26, Andrew Lunn wrote: >>> On Mon, Mar 04, 2019 at 08:43:01PM +0800, Shaokun Zhang wrote: When CONFIG_NET_DSA_LEGACY is n, there is a GCC bulid warning: >>

Re: [PATCH -next] net: dsa: mv88e6xxx: Fix build warning when CONFIG_NET_DSA_LEGACY is n

2019-03-04 Thread Andrew Lunn
On Mon, Mar 04, 2019 at 10:16:08PM +0800, Zhangshaokun wrote: > Hi Andrew, > > On 2019/3/4 21:26, Andrew Lunn wrote: > > On Mon, Mar 04, 2019 at 08:43:01PM +0800, Shaokun Zhang wrote: > >> When CONFIG_NET_DSA_LEGACY is n, there is a GCC bulid warning: > >> drivers/net/dsa/mv88e6xxx/chip.c:4623:13:

Re: [PATCH -next] net: dsa: mv88e6xxx: Fix build warning when CONFIG_NET_DSA_LEGACY is n

2019-03-04 Thread Zhangshaokun
Hi Andrew, On 2019/3/4 21:26, Andrew Lunn wrote: > On Mon, Mar 04, 2019 at 08:43:01PM +0800, Shaokun Zhang wrote: >> When CONFIG_NET_DSA_LEGACY is n, there is a GCC bulid warning: >> drivers/net/dsa/mv88e6xxx/chip.c:4623:13: warning: >> ‘mv88e6xxx_ports_cmode_init’ defined but not used [-Wunused-

Re: [PATCH -next] net: dsa: mv88e6xxx: Fix build warning when CONFIG_NET_DSA_LEGACY is n

2019-03-04 Thread Andrew Lunn
On Mon, Mar 04, 2019 at 08:43:01PM +0800, Shaokun Zhang wrote: > When CONFIG_NET_DSA_LEGACY is n, there is a GCC bulid warning: > drivers/net/dsa/mv88e6xxx/chip.c:4623:13: warning: > ‘mv88e6xxx_ports_cmode_init’ defined but not used [-Wunused-function] > static void mv88e6xxx_ports_cmode_init(stru

[PATCH -next] net: dsa: mv88e6xxx: Fix build warning when CONFIG_NET_DSA_LEGACY is n

2019-03-04 Thread Shaokun Zhang
When CONFIG_NET_DSA_LEGACY is n, there is a GCC bulid warning: drivers/net/dsa/mv88e6xxx/chip.c:4623:13: warning: ???mv88e6xxx_ports_cmode_init??? defined but not used [-Wunused-function] static void mv88e6xxx_ports_cmode_init(struct mv88e6xxx_chip *chip) Let's fix it. Fixes: ed8fe20205ac ("net: