Re: [PATCH -next] nvme-rdma: fix the return value of nvme_rdma_reinit_request()

2016-07-13 Thread Sagi Grimberg
Thanks! Reviewed-by: Sagi Grimberg

Re: [PATCH -next] nvme-rdma: fix the return value of nvme_rdma_reinit_request()

2016-07-13 Thread Sagi Grimberg
Thanks! Reviewed-by: Sagi Grimberg

Re: [PATCH -next] nvme-rdma: fix the return value of nvme_rdma_reinit_request()

2016-07-12 Thread Jens Axboe
On 07/12/2016 04:06 AM, weiyj...@163.com wrote: From: Wei Yongjun PTR_ERR should be applied before its argument is reassigned, otherwise the return value will be set to 0, not error code. Applied, thanks. -- Jens Axboe

Re: [PATCH -next] nvme-rdma: fix the return value of nvme_rdma_reinit_request()

2016-07-12 Thread Jens Axboe
On 07/12/2016 04:06 AM, weiyj...@163.com wrote: From: Wei Yongjun PTR_ERR should be applied before its argument is reassigned, otherwise the return value will be set to 0, not error code. Applied, thanks. -- Jens Axboe

Re: [PATCH -next] nvme-rdma: fix the return value of nvme_rdma_reinit_request()

2016-07-12 Thread J Freyensee
On Tue, 2016-07-12 at 11:06 +, weiyj...@163.com wrote: > From: Wei Yongjun > > PTR_ERR should be applied before its argument is reassigned, > otherwise the > return value will be set to 0, not error code. Another good catch. Reviewed-by: Jay Freyensee

Re: [PATCH -next] nvme-rdma: fix the return value of nvme_rdma_reinit_request()

2016-07-12 Thread J Freyensee
On Tue, 2016-07-12 at 11:06 +, weiyj...@163.com wrote: > From: Wei Yongjun > > PTR_ERR should be applied before its argument is reassigned, > otherwise the > return value will be set to 0, not error code. Another good catch. Reviewed-by: Jay Freyensee > > Signed-off-by: Wei Yongjun >

[PATCH -next] nvme-rdma: fix the return value of nvme_rdma_reinit_request()

2016-07-12 Thread weiyj_lk
From: Wei Yongjun PTR_ERR should be applied before its argument is reassigned, otherwise the return value will be set to 0, not error code. Signed-off-by: Wei Yongjun --- drivers/nvme/host/rdma.c | 2 +- 1 file changed, 1

[PATCH -next] nvme-rdma: fix the return value of nvme_rdma_reinit_request()

2016-07-12 Thread weiyj_lk
From: Wei Yongjun PTR_ERR should be applied before its argument is reassigned, otherwise the return value will be set to 0, not error code. Signed-off-by: Wei Yongjun --- drivers/nvme/host/rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/rdma.c