Re: [PATCH -next] platform/chrome: Fix Kconfig dependencies for wilco_ec

2019-02-25 Thread Cheng-yi Chiang
On Mon, Feb 25, 2019 at 8:23 PM Enric Balletbo i Serra wrote: > > Hi Cheng-yi, > > Attached the config that Randy sent. > > Thanks, > Enric Hi Enric, Thanks for the quick reply. I have posted a patch to fix it. > On 25/2/19 11:22, Cheng-yi Chiang wrote: > > On Mon, Feb 25, 2019 at 6:11 PM Enric

Re: [PATCH -next] platform/chrome: Fix Kconfig dependencies for wilco_ec

2019-02-25 Thread Enric Balletbo i Serra
Hi Cheng-yi, Attached the config that Randy sent. Thanks, Enric On 25/2/19 11:22, Cheng-yi Chiang wrote: > On Mon, Feb 25, 2019 at 6:11 PM Enric Balletbo i Serra > wrote: >> >> Hi Randy, >> >> Thanks for the report >> >> On 22/2/19 17:50, Randy Dunlap wrote: >>> On 2/20/19 11:57 PM, Enric Balle

Re: [PATCH -next] platform/chrome: Fix Kconfig dependencies for wilco_ec

2019-02-25 Thread Cheng-yi Chiang
On Mon, Feb 25, 2019 at 6:11 PM Enric Balletbo i Serra wrote: > > Hi Randy, > > Thanks for the report > > On 22/2/19 17:50, Randy Dunlap wrote: > > On 2/20/19 11:57 PM, Enric Balletbo i Serra wrote: > >> Hi, > >> > >> On 21/2/19 0:09, Randy Dunlap wrote: > >>> On 2/20/19 2:11 PM, Nick Crews wrote:

Re: [PATCH -next] platform/chrome: Fix Kconfig dependencies for wilco_ec

2019-02-25 Thread Enric Balletbo i Serra
Hi Randy, Thanks for the report On 22/2/19 17:50, Randy Dunlap wrote: > On 2/20/19 11:57 PM, Enric Balletbo i Serra wrote: >> Hi, >> >> On 21/2/19 0:09, Randy Dunlap wrote: >>> On 2/20/19 2:11 PM, Nick Crews wrote: In the initial version of the Wilco EC Driver, the dependency order was

Re: [PATCH -next] platform/chrome: Fix Kconfig dependencies for wilco_ec

2019-02-22 Thread Randy Dunlap
On 2/20/19 11:57 PM, Enric Balletbo i Serra wrote: > Hi, > > On 21/2/19 0:09, Randy Dunlap wrote: >> On 2/20/19 2:11 PM, Nick Crews wrote: >>> In the initial version of the Wilco EC Driver, the >>> dependency order was wrong. It before was possible to >>> select CONFIG_WILCO_EC and CONFIG_CROS_EC_

Re: [PATCH -next] platform/chrome: Fix Kconfig dependencies for wilco_ec

2019-02-20 Thread Enric Balletbo i Serra
Hi, On 21/2/19 0:09, Randy Dunlap wrote: > On 2/20/19 2:11 PM, Nick Crews wrote: >> In the initial version of the Wilco EC Driver, the >> dependency order was wrong. It before was possible to >> select CONFIG_WILCO_EC and CONFIG_CROS_EC_LPC without >> having CONFIG_CROS_EC_LPC_MEC. This was wrong,

Re: [PATCH -next] platform/chrome: Fix Kconfig dependencies for wilco_ec

2019-02-20 Thread Randy Dunlap
On 2/20/19 2:11 PM, Nick Crews wrote: > In the initial version of the Wilco EC Driver, the > dependency order was wrong. It before was possible to > select CONFIG_WILCO_EC and CONFIG_CROS_EC_LPC without > having CONFIG_CROS_EC_LPC_MEC. This was wrong, since > WILCO_EC depends upon CONFIG CROS_EC_LP

[PATCH -next] platform/chrome: Fix Kconfig dependencies for wilco_ec

2019-02-20 Thread Nick Crews
In the initial version of the Wilco EC Driver, the dependency order was wrong. It before was possible to select CONFIG_WILCO_EC and CONFIG_CROS_EC_LPC without having CONFIG_CROS_EC_LPC_MEC. This was wrong, since WILCO_EC depends upon CONFIG CROS_EC_LPC_MEC, not the other way around. Fixes: 1733c32