Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
for debugfs files.

Semantic patch information:
Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
imposes some significant overhead as compared to
DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().

Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci

Signed-off-by: YueHaibing <yuehaib...@huawei.com>
---
 arch/x86/kernel/cpu/mce/core.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
index 672c722..d5f067a 100644
--- a/arch/x86/kernel/cpu/mce/core.c
+++ b/arch/x86/kernel/cpu/mce/core.c
@@ -2454,8 +2454,8 @@ static int fake_panic_set(void *data, u64 val)
        return 0;
 }
 
-DEFINE_SIMPLE_ATTRIBUTE(fake_panic_fops, fake_panic_get,
-                       fake_panic_set, "%llu\n");
+DEFINE_DEBUGFS_ATTRIBUTE(fake_panic_fops, fake_panic_get, fake_panic_set,
+                        "%llu\n");
 
 static int __init mcheck_debugfs_init(void)
 {
@@ -2464,8 +2464,8 @@ static int __init mcheck_debugfs_init(void)
        dmce = mce_get_debugfs_dir();
        if (!dmce)
                return -ENOMEM;
-       ffake_panic = debugfs_create_file("fake_panic", 0444, dmce, NULL,
-                                         &fake_panic_fops);
+       ffake_panic = debugfs_create_file_unsafe("fake_panic", 0444, dmce,
+                                                NULL, &fake_panic_fops);
        if (!ffake_panic)
                return -ENOMEM;
 





Reply via email to