Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-26 Thread Joel Fernandes
On Sat, Nov 24, 2018 at 04:47:36PM -0800, Matthew Wilcox wrote: > On Sat, Nov 24, 2018 at 04:42:29PM -0800, Andrew Morton wrote: > > This changelog doesn't have the nifty test case code which was in > > earlier versions? > > Why do we put regression tests in the changelogs anyway? We have >

Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-26 Thread Joel Fernandes
On Sat, Nov 24, 2018 at 04:47:36PM -0800, Matthew Wilcox wrote: > On Sat, Nov 24, 2018 at 04:42:29PM -0800, Andrew Morton wrote: > > This changelog doesn't have the nifty test case code which was in > > earlier versions? > > Why do we put regression tests in the changelogs anyway? We have >

Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-24 Thread Matthew Wilcox
On Sat, Nov 24, 2018 at 04:42:29PM -0800, Andrew Morton wrote: > This changelog doesn't have the nifty test case code which was in > earlier versions? Why do we put regression tests in the changelogs anyway? We have tools/testing/selftests/vm/ already, perhaps they should go there?

Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-24 Thread Matthew Wilcox
On Sat, Nov 24, 2018 at 04:42:29PM -0800, Andrew Morton wrote: > This changelog doesn't have the nifty test case code which was in > earlier versions? Why do we put regression tests in the changelogs anyway? We have tools/testing/selftests/vm/ already, perhaps they should go there?

Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-24 Thread Andrew Morton
On Thu, 22 Nov 2018 15:09:06 -0800 Joel Fernandes wrote: > Android uses ashmem for sharing memory regions. We are looking forward to > migrating all usecases of ashmem to memfd so that we can possibly remove > the ashmem driver in the future from staging while also benefiting from > using

Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-24 Thread Andrew Morton
On Thu, 22 Nov 2018 15:09:06 -0800 Joel Fernandes wrote: > Android uses ashmem for sharing memory regions. We are looking forward to > migrating all usecases of ashmem to memfd so that we can possibly remove > the ashmem driver in the future from staging while also benefiting from > using

Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-22 Thread Joel Fernandes
On Wed, Nov 21, 2018 at 07:25:26PM -0800, Andy Lutomirski wrote: > On Wed, Nov 21, 2018 at 6:27 PM Andrew Morton > wrote: > > > > On Tue, 20 Nov 2018 13:13:35 -0800 Joel Fernandes > > wrote: > > > > > > > I am Ok with whatever Andrew wants to do, if it is better to squash > > > > > it with >

Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-22 Thread Joel Fernandes
On Wed, Nov 21, 2018 at 07:25:26PM -0800, Andy Lutomirski wrote: > On Wed, Nov 21, 2018 at 6:27 PM Andrew Morton > wrote: > > > > On Tue, 20 Nov 2018 13:13:35 -0800 Joel Fernandes > > wrote: > > > > > > > I am Ok with whatever Andrew wants to do, if it is better to squash > > > > > it with >

Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-21 Thread Andy Lutomirski
On Wed, Nov 21, 2018 at 6:27 PM Andrew Morton wrote: > > On Tue, 20 Nov 2018 13:13:35 -0800 Joel Fernandes > wrote: > > > > > I am Ok with whatever Andrew wants to do, if it is better to squash it > > > > with > > > > the original, then I can do that and send another patch. > > > > > > > > > >

Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-21 Thread Andy Lutomirski
On Wed, Nov 21, 2018 at 6:27 PM Andrew Morton wrote: > > On Tue, 20 Nov 2018 13:13:35 -0800 Joel Fernandes > wrote: > > > > > I am Ok with whatever Andrew wants to do, if it is better to squash it > > > > with > > > > the original, then I can do that and send another patch. > > > > > > > > > >

Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-21 Thread Andrew Morton
On Tue, 20 Nov 2018 13:13:35 -0800 Joel Fernandes wrote: > > > I am Ok with whatever Andrew wants to do, if it is better to squash it > > > with > > > the original, then I can do that and send another patch. > > > > > > > > > > From experience, Andrew will food in fixups on request :) > >

Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-21 Thread Andrew Morton
On Tue, 20 Nov 2018 13:13:35 -0800 Joel Fernandes wrote: > > > I am Ok with whatever Andrew wants to do, if it is better to squash it > > > with > > > the original, then I can do that and send another patch. > > > > > > > > > > From experience, Andrew will food in fixups on request :) > >

Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-20 Thread Joel Fernandes
On Tue, Nov 20, 2018 at 02:02:49PM -0700, Andy Lutomirski wrote: > > > On Nov 20, 2018, at 1:47 PM, Joel Fernandes wrote: > > > >> On Tue, Nov 20, 2018 at 01:33:18PM -0700, Andy Lutomirski wrote: > >> > >>> On Nov 20, 2018, at 1:07 PM, Stephen Rothwell > >>> wrote: > >>> > >>> Hi Joel, >

Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-20 Thread Joel Fernandes
On Tue, Nov 20, 2018 at 02:02:49PM -0700, Andy Lutomirski wrote: > > > On Nov 20, 2018, at 1:47 PM, Joel Fernandes wrote: > > > >> On Tue, Nov 20, 2018 at 01:33:18PM -0700, Andy Lutomirski wrote: > >> > >>> On Nov 20, 2018, at 1:07 PM, Stephen Rothwell > >>> wrote: > >>> > >>> Hi Joel, >

Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-20 Thread Andy Lutomirski
> On Nov 20, 2018, at 1:47 PM, Joel Fernandes wrote: > >> On Tue, Nov 20, 2018 at 01:33:18PM -0700, Andy Lutomirski wrote: >> >>> On Nov 20, 2018, at 1:07 PM, Stephen Rothwell wrote: >>> >>> Hi Joel, >>> > On Tue, 20 Nov 2018 10:39:26 -0800 Joel Fernandes > wrote: > > On

Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-20 Thread Andy Lutomirski
> On Nov 20, 2018, at 1:47 PM, Joel Fernandes wrote: > >> On Tue, Nov 20, 2018 at 01:33:18PM -0700, Andy Lutomirski wrote: >> >>> On Nov 20, 2018, at 1:07 PM, Stephen Rothwell wrote: >>> >>> Hi Joel, >>> > On Tue, 20 Nov 2018 10:39:26 -0800 Joel Fernandes > wrote: > > On

Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-20 Thread Joel Fernandes
On Tue, Nov 20, 2018 at 01:33:18PM -0700, Andy Lutomirski wrote: > > > On Nov 20, 2018, at 1:07 PM, Stephen Rothwell wrote: > > > > Hi Joel, > > > >> On Tue, 20 Nov 2018 10:39:26 -0800 Joel Fernandes > >> wrote: > >> > >>> On Tue, Nov 20, 2018 at 07:13:17AM -0800, Andy Lutomirski wrote: >

Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-20 Thread Joel Fernandes
On Tue, Nov 20, 2018 at 01:33:18PM -0700, Andy Lutomirski wrote: > > > On Nov 20, 2018, at 1:07 PM, Stephen Rothwell wrote: > > > > Hi Joel, > > > >> On Tue, 20 Nov 2018 10:39:26 -0800 Joel Fernandes > >> wrote: > >> > >>> On Tue, Nov 20, 2018 at 07:13:17AM -0800, Andy Lutomirski wrote: >

Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-20 Thread Andy Lutomirski
> On Nov 20, 2018, at 1:07 PM, Stephen Rothwell wrote: > > Hi Joel, > >> On Tue, 20 Nov 2018 10:39:26 -0800 Joel Fernandes >> wrote: >> >>> On Tue, Nov 20, 2018 at 07:13:17AM -0800, Andy Lutomirski wrote: >>> On Mon, Nov 19, 2018 at 9:21 PM Joel Fernandes (Google) >>> wrote:

Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-20 Thread Andy Lutomirski
> On Nov 20, 2018, at 1:07 PM, Stephen Rothwell wrote: > > Hi Joel, > >> On Tue, 20 Nov 2018 10:39:26 -0800 Joel Fernandes >> wrote: >> >>> On Tue, Nov 20, 2018 at 07:13:17AM -0800, Andy Lutomirski wrote: >>> On Mon, Nov 19, 2018 at 9:21 PM Joel Fernandes (Google) >>> wrote:

Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-20 Thread Stephen Rothwell
Hi Joel, On Tue, 20 Nov 2018 10:39:26 -0800 Joel Fernandes wrote: > > On Tue, Nov 20, 2018 at 07:13:17AM -0800, Andy Lutomirski wrote: > > On Mon, Nov 19, 2018 at 9:21 PM Joel Fernandes (Google) > > wrote: > > > > > > A better way to do F_SEAL_FUTURE_WRITE seal was discussed [1] last week >

Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-20 Thread Stephen Rothwell
Hi Joel, On Tue, 20 Nov 2018 10:39:26 -0800 Joel Fernandes wrote: > > On Tue, Nov 20, 2018 at 07:13:17AM -0800, Andy Lutomirski wrote: > > On Mon, Nov 19, 2018 at 9:21 PM Joel Fernandes (Google) > > wrote: > > > > > > A better way to do F_SEAL_FUTURE_WRITE seal was discussed [1] last week >

Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-20 Thread Joel Fernandes
On Tue, Nov 20, 2018 at 07:13:17AM -0800, Andy Lutomirski wrote: > On Mon, Nov 19, 2018 at 9:21 PM Joel Fernandes (Google) > wrote: > > > > A better way to do F_SEAL_FUTURE_WRITE seal was discussed [1] last week > > where we don't need to modify core VFS structures to get the same > > behavior of

Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-20 Thread Joel Fernandes
On Tue, Nov 20, 2018 at 07:13:17AM -0800, Andy Lutomirski wrote: > On Mon, Nov 19, 2018 at 9:21 PM Joel Fernandes (Google) > wrote: > > > > A better way to do F_SEAL_FUTURE_WRITE seal was discussed [1] last week > > where we don't need to modify core VFS structures to get the same > > behavior of

Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-20 Thread Andy Lutomirski
On Mon, Nov 19, 2018 at 9:21 PM Joel Fernandes (Google) wrote: > > A better way to do F_SEAL_FUTURE_WRITE seal was discussed [1] last week > where we don't need to modify core VFS structures to get the same > behavior of the seal. This solves several side-effects pointed out by > Andy [2]. > >

Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-20 Thread Andy Lutomirski
On Mon, Nov 19, 2018 at 9:21 PM Joel Fernandes (Google) wrote: > > A better way to do F_SEAL_FUTURE_WRITE seal was discussed [1] last week > where we don't need to modify core VFS structures to get the same > behavior of the seal. This solves several side-effects pointed out by > Andy [2]. > >

[PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-19 Thread Joel Fernandes (Google)
A better way to do F_SEAL_FUTURE_WRITE seal was discussed [1] last week where we don't need to modify core VFS structures to get the same behavior of the seal. This solves several side-effects pointed out by Andy [2]. [1] https://lore.kernel.org/lkml/2018173650.ga256...@google.com/ [2]

[PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-19 Thread Joel Fernandes (Google)
A better way to do F_SEAL_FUTURE_WRITE seal was discussed [1] last week where we don't need to modify core VFS structures to get the same behavior of the seal. This solves several side-effects pointed out by Andy [2]. [1] https://lore.kernel.org/lkml/2018173650.ga256...@google.com/ [2]