Re: [PATCH -next 25/36] spi: s3c24xx: use devm_platform_ioremap_resource() to simplify code

2019-09-07 Thread Andi Shyti
Hi Yuehaibing, > >> Use devm_platform_ioremap_resource() to simplify the code a bit. > >> This is detected by coccinelle. > >> > >> Reported-by: Hulk Robot > > > > This tag does not look real... First of all where is the report? > > It is our internal CI robot, which is unavailable to external

Re: [PATCH -next 25/36] spi: s3c24xx: use devm_platform_ioremap_resource() to simplify code

2019-09-05 Thread Sylwester Nawrocki
On 9/4/19 15:59, YueHaibing wrote: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Reviewed-by: Sylwester Nawrocki

Re: [PATCH -next 25/36] spi: s3c24xx: use devm_platform_ioremap_resource() to simplify code

2019-09-04 Thread Mark Brown
On Wed, Sep 04, 2019 at 05:09:45PM +0200, Krzysztof Kozlowski wrote: > On Wed, 4 Sep 2019 at 16:39, Mark Brown wrote: > > I think it's reasonable, it's giving credit to the automated system > > they've got running coccinelle (which they do mention in their commit > > logs). It doesn't really

Re: [PATCH -next 25/36] spi: s3c24xx: use devm_platform_ioremap_resource() to simplify code

2019-09-04 Thread Krzysztof Kozlowski
On Wed, 4 Sep 2019 at 16:39, Mark Brown wrote: > > On Wed, Sep 04, 2019 at 04:28:29PM +0200, Krzysztof Kozlowski wrote: > > On Wed, 4 Sep 2019 at 16:00, YueHaibing wrote: > > > > Reported-by: Hulk Robot > > > This tag does not look real... First of all where is the report? > > Second, it was

Re: [PATCH -next 25/36] spi: s3c24xx: use devm_platform_ioremap_resource() to simplify code

2019-09-04 Thread Yuehaibing
On 2019/9/4 22:28, Krzysztof Kozlowski wrote: > On Wed, 4 Sep 2019 at 16:00, YueHaibing wrote: >> >> Use devm_platform_ioremap_resource() to simplify the code a bit. >> This is detected by coccinelle. >> >> Reported-by: Hulk Robot > > This tag does not look real... First of all where is the

Re: [PATCH -next 25/36] spi: s3c24xx: use devm_platform_ioremap_resource() to simplify code

2019-09-04 Thread Mark Brown
On Wed, Sep 04, 2019 at 04:28:29PM +0200, Krzysztof Kozlowski wrote: > On Wed, 4 Sep 2019 at 16:00, YueHaibing wrote: > > Reported-by: Hulk Robot > This tag does not look real... First of all where is the report? > Second, it was reported by coccinelle. > Reported-by should be use to give real

Re: [PATCH -next 25/36] spi: s3c24xx: use devm_platform_ioremap_resource() to simplify code

2019-09-04 Thread Krzysztof Kozlowski
On Wed, 4 Sep 2019 at 16:00, YueHaibing wrote: > > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Reported-by: Hulk Robot This tag does not look real... First of all where is the report? Second, it was reported by coccinelle. Reported-by

[PATCH -next 25/36] spi: s3c24xx: use devm_platform_ioremap_resource() to simplify code

2019-09-04 Thread YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/spi/spi-s3c24xx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/spi-s3c24xx.c