Re: [PATCH -next v2] sched/fair: fix -Wunused-but-set-variable warnings

2019-09-16 Thread Qian Cai
Ingo, I saw you sent a pull request to Linus including the commit introduced the warnings, https://lkml.org/lkml/2019/9/16/309 but seems not yet picked up the fix here, https://lore.kernel.org/lkml/20190903141554.GS2349@hirez.programming.kicks-ass.n et/ On Tue, 2019-09-10 at 16:58 -0400, Qian

Re: [PATCH -next v2] sched/fair: fix -Wunused-but-set-variable warnings

2019-09-10 Thread Qian Cai
On Tue, 2019-09-03 at 16:15 +0200, Peter Zijlstra wrote: > On Tue, Sep 03, 2019 at 09:03:26AM -0400, Qian Cai wrote: > > Ingo or Peter, please take a look at this trivial patch. Still see the > > warning > > in linux-next every day. > > > > On Tue, 2019-08-20 at 14:40 -0400, Qian Cai wrote: > >

Re: [PATCH -next v2] sched/fair: fix -Wunused-but-set-variable warnings

2019-09-03 Thread Peter Zijlstra
On Tue, Sep 03, 2019 at 09:03:26AM -0400, Qian Cai wrote: > Ingo or Peter, please take a look at this trivial patch. Still see the warning > in linux-next every day. > > On Tue, 2019-08-20 at 14:40 -0400, Qian Cai wrote: > > The linux-next commit "sched/fair: Fix low cpu usage with high > >

Re: [PATCH -next v2] sched/fair: fix -Wunused-but-set-variable warnings

2019-09-03 Thread Qian Cai
Ingo or Peter, please take a look at this trivial patch. Still see the warning in linux-next every day. On Tue, 2019-08-20 at 14:40 -0400, Qian Cai wrote: > The linux-next commit "sched/fair: Fix low cpu usage with high > throttling by removing expiration of cpu-local slices" [1] introduced a >

Re: [PATCH -next v2] sched/fair: fix -Wunused-but-set-variable warnings

2019-08-23 Thread Phil Auld
On Fri, Aug 23, 2019 at 10:28:02AM -0700 bseg...@google.com wrote: > Dave Chiluk writes: > > > On Wed, Aug 21, 2019 at 12:36 PM wrote: > >> > >> Qian Cai writes: > >> > >> > The linux-next commit "sched/fair: Fix low cpu usage with high > >> > throttling by removing expiration of cpu-local

Re: [PATCH -next v2] sched/fair: fix -Wunused-but-set-variable warnings

2019-08-23 Thread bsegall
Dave Chiluk writes: > On Wed, Aug 21, 2019 at 12:36 PM wrote: >> >> Qian Cai writes: >> >> > The linux-next commit "sched/fair: Fix low cpu usage with high >> > throttling by removing expiration of cpu-local slices" [1] introduced a >> > few compilation warnings, >> > >> > kernel/sched/fair.c:

Re: [PATCH -next v2] sched/fair: fix -Wunused-but-set-variable warnings

2019-08-23 Thread Dave Chiluk
On Wed, Aug 21, 2019 at 12:36 PM wrote: > > Qian Cai writes: > > > The linux-next commit "sched/fair: Fix low cpu usage with high > > throttling by removing expiration of cpu-local slices" [1] introduced a > > few compilation warnings, > > > > kernel/sched/fair.c: In function

Re: [PATCH -next v2] sched/fair: fix -Wunused-but-set-variable warnings

2019-08-21 Thread bsegall
Qian Cai writes: > The linux-next commit "sched/fair: Fix low cpu usage with high > throttling by removing expiration of cpu-local slices" [1] introduced a > few compilation warnings, > > kernel/sched/fair.c: In function '__refill_cfs_bandwidth_runtime': > kernel/sched/fair.c:4365:6: warning:

[PATCH -next v2] sched/fair: fix -Wunused-but-set-variable warnings

2019-08-20 Thread Qian Cai
The linux-next commit "sched/fair: Fix low cpu usage with high throttling by removing expiration of cpu-local slices" [1] introduced a few compilation warnings, kernel/sched/fair.c: In function '__refill_cfs_bandwidth_runtime': kernel/sched/fair.c:4365:6: warning: variable 'now' set but not used