Re: Re: [PATCH -tip v8 01/26] [BUGFIX]kprobes/x86: Fix page-fault handling logic

2014-03-23 Thread Masami Hiramatsu
(2014/03/22 6:39), Steven Rostedt wrote: >> diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c >> index 79a3f96..b482e96 100644 >> --- a/arch/x86/kernel/kprobes/core.c >> +++ b/arch/x86/kernel/kprobes/core.c >> @@ -897,9 +897,7 @@ int __kprobes kprobe_fault_handler(struct

Re: Re: [PATCH -tip v8 01/26] [BUGFIX]kprobes/x86: Fix page-fault handling logic

2014-03-23 Thread Masami Hiramatsu
(2014/03/22 6:39), Steven Rostedt wrote: diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c index 79a3f96..b482e96 100644 --- a/arch/x86/kernel/kprobes/core.c +++ b/arch/x86/kernel/kprobes/core.c @@ -897,9 +897,7 @@ int __kprobes kprobe_fault_handler(struct pt_regs

Re: [PATCH -tip v8 01/26] [BUGFIX]kprobes/x86: Fix page-fault handling logic

2014-03-21 Thread Steven Rostedt
On Wed, 05 Mar 2014 20:58:50 +0900 Masami Hiramatsu wrote: > Current kprobes in-kernel page fault handler doesn't > expect that its single-stepping can be interrupted by > an NMI handler which may cause a page fault(e.g. perf > with callback tracing). > In that case, the page-fault handled by

Re: [PATCH -tip v8 01/26] [BUGFIX]kprobes/x86: Fix page-fault handling logic

2014-03-21 Thread Steven Rostedt
On Wed, 05 Mar 2014 20:58:50 +0900 Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote: Current kprobes in-kernel page fault handler doesn't expect that its single-stepping can be interrupted by an NMI handler which may cause a page fault(e.g. perf with callback tracing). In that case,

[PATCH -tip v8 01/26] [BUGFIX]kprobes/x86: Fix page-fault handling logic

2014-03-05 Thread Masami Hiramatsu
Current kprobes in-kernel page fault handler doesn't expect that its single-stepping can be interrupted by an NMI handler which may cause a page fault(e.g. perf with callback tracing). In that case, the page-fault handled by kprobes and it misunderstands the page-fault has been caused by the

[PATCH -tip v8 01/26] [BUGFIX]kprobes/x86: Fix page-fault handling logic

2014-03-05 Thread Masami Hiramatsu
Current kprobes in-kernel page fault handler doesn't expect that its single-stepping can be interrupted by an NMI handler which may cause a page fault(e.g. perf with callback tracing). In that case, the page-fault handled by kprobes and it misunderstands the page-fault has been caused by the