Re: [PATCH -v2 3/3] PCI,pciehp: use PCIe DSN to identify device change during suspend

2013-07-11 Thread Yijing Wang
On 2013/7/11 22:33, Paul Bolle wrote: > On Thu, 2013-07-11 at 17:43 +0800, Yijing Wang wrote: > [...] >> diff --git a/drivers/pci/hotplug/pciehp_core.c >> b/drivers/pci/hotplug/pciehp_core.c >> index 1542735..f2eb214 100644 >> --- a/drivers/pci/hotplug/pciehp_core.c >> +++

Re: [PATCH -v2 3/3] PCI,pciehp: use PCIe DSN to identify device change during suspend

2013-07-11 Thread Paul Bolle
On Thu, 2013-07-11 at 17:43 +0800, Yijing Wang wrote: [...] > diff --git a/drivers/pci/hotplug/pciehp_core.c > b/drivers/pci/hotplug/pciehp_core.c > index 1542735..f2eb214 100644 > --- a/drivers/pci/hotplug/pciehp_core.c > +++ b/drivers/pci/hotplug/pciehp_core.c [...] > @@ -315,6 +342,24 @@

Re: [PATCH -v2 3/3] PCI,pciehp: use PCIe DSN to identify device change during suspend

2013-07-11 Thread Don Dutile
Sorry, did a 'reply' instead of 'reply all' on first reply to this patch... excuse any repeat... - Don On 07/11/2013 05:43 AM, Yijing Wang wrote: If device was removed from slot and reinsert a new device during suspend, pciehp can not identify the physical device change now. So the old driver

[PATCH -v2 3/3] PCI,pciehp: use PCIe DSN to identify device change during suspend

2013-07-11 Thread Yijing Wang
If device was removed from slot and reinsert a new device during suspend, pciehp can not identify the physical device change now. So the old driver .resume() method will be called for the new device, this is bad. If device support device serial number capability, we can identify this by DSN. So

[PATCH -v2 3/3] PCI,pciehp: use PCIe DSN to identify device change during suspend

2013-07-11 Thread Yijing Wang
If device was removed from slot and reinsert a new device during suspend, pciehp can not identify the physical device change now. So the old driver .resume() method will be called for the new device, this is bad. If device support device serial number capability, we can identify this by DSN. So

Re: [PATCH -v2 3/3] PCI,pciehp: use PCIe DSN to identify device change during suspend

2013-07-11 Thread Don Dutile
Sorry, did a 'reply' instead of 'reply all' on first reply to this patch... excuse any repeat... - Don On 07/11/2013 05:43 AM, Yijing Wang wrote: If device was removed from slot and reinsert a new device during suspend, pciehp can not identify the physical device change now. So the old driver

Re: [PATCH -v2 3/3] PCI,pciehp: use PCIe DSN to identify device change during suspend

2013-07-11 Thread Paul Bolle
On Thu, 2013-07-11 at 17:43 +0800, Yijing Wang wrote: [...] diff --git a/drivers/pci/hotplug/pciehp_core.c b/drivers/pci/hotplug/pciehp_core.c index 1542735..f2eb214 100644 --- a/drivers/pci/hotplug/pciehp_core.c +++ b/drivers/pci/hotplug/pciehp_core.c [...] @@ -315,6 +342,24 @@ static int

Re: [PATCH -v2 3/3] PCI,pciehp: use PCIe DSN to identify device change during suspend

2013-07-11 Thread Yijing Wang
On 2013/7/11 22:33, Paul Bolle wrote: On Thu, 2013-07-11 at 17:43 +0800, Yijing Wang wrote: [...] diff --git a/drivers/pci/hotplug/pciehp_core.c b/drivers/pci/hotplug/pciehp_core.c index 1542735..f2eb214 100644 --- a/drivers/pci/hotplug/pciehp_core.c +++ b/drivers/pci/hotplug/pciehp_core.c