Re: [PATCH 0/1] mm, shmem: map few pages around fault address if they are in page cache

2014-03-13 Thread Ning Qu
Hi, Andrew, I have updated the results for tmpfs last week and Hugh already ack this patchset on Mar 4 in "[PATCH 1/1] mm: implement ->map_pages for shmem/tmpfs" Acked-by: Hugh Dickins Please consider to apply this patch so that tmpfs will have the similar feature together with the other file

Re: [PATCH 0/1] mm, shmem: map few pages around fault address if they are in page cache

2014-03-13 Thread Ning Qu
Hi, Andrew, I have updated the results for tmpfs last week and Hugh already ack this patchset on Mar 4 in [PATCH 1/1] mm: implement -map_pages for shmem/tmpfs Acked-by: Hugh Dickins hu...@google.com Please consider to apply this patch so that tmpfs will have the similar feature together with

Re: [PATCH 0/1] mm, shmem: map few pages around fault address if they are in page cache

2014-03-03 Thread Kirill A. Shutemov
On Mon, Mar 03, 2014 at 03:37:07PM -0800, Andrew Morton wrote: > On Mon, 3 Mar 2014 15:29:00 -0800 Linus Torvalds > wrote: > > > On Mon, Mar 3, 2014 at 2:38 PM, Andrew Morton > > wrote: > > > > > > When the file is uncached, results are peculiar: > > > > > > 0.00user 2.84system 0:50.90elapsed

Re: [PATCH 0/1] mm, shmem: map few pages around fault address if they are in page cache

2014-03-03 Thread Linus Torvalds
On Mon, Mar 3, 2014 at 2:38 PM, Andrew Morton wrote: > > When the file is uncached, results are peculiar: > > 0.00user 2.84system 0:50.90elapsed 5%CPU (0avgtext+0avgdata > 4198096maxresident)k > 0inputs+0outputs (1major+49666minor)pagefaults 0swaps > > That's approximately 3x more minor faults.

Re: [PATCH 0/1] mm, shmem: map few pages around fault address if they are in page cache

2014-03-03 Thread Ning Qu
Actually this one is just using the generic functions provided in Kirill's patch. And Kirill just sent another email earlier with two fixes reported by Hugh and I. So it doesn't change anything in this patch. I will update the log and work on the experiment results. I already asked Kirill

Re: [PATCH 0/1] mm, shmem: map few pages around fault address if they are in page cache

2014-03-03 Thread Ning Qu
Actually this one is just using the generic functions provided in Kirill's patch. And Kirill just sent another email earlier with two fixes reported by Hugh and I. So it doesn't change anything in this patch. I will update the log and work on the experiment results. I already asked Kirill

Re: [PATCH 0/1] mm, shmem: map few pages around fault address if they are in page cache

2014-03-03 Thread Linus Torvalds
On Mon, Mar 3, 2014 at 2:38 PM, Andrew Morton a...@linux-foundation.org wrote: When the file is uncached, results are peculiar: 0.00user 2.84system 0:50.90elapsed 5%CPU (0avgtext+0avgdata 4198096maxresident)k 0inputs+0outputs (1major+49666minor)pagefaults 0swaps That's approximately 3x

Re: [PATCH 0/1] mm, shmem: map few pages around fault address if they are in page cache

2014-03-03 Thread Kirill A. Shutemov
On Mon, Mar 03, 2014 at 03:37:07PM -0800, Andrew Morton wrote: On Mon, 3 Mar 2014 15:29:00 -0800 Linus Torvalds torva...@linux-foundation.org wrote: On Mon, Mar 3, 2014 at 2:38 PM, Andrew Morton a...@linux-foundation.org wrote: When the file is uncached, results are peculiar:

Re: [PATCH 0/1] mm, shmem: map few pages around fault address if they are in page cache

2014-02-28 Thread Ning Qu
Yes, the simple test does verify that the page fault number are correct with the patch. So my previous results are from those command lines, which also show some performance improvement with this change in tmpfs. sequential access /usr/bin/time -a ./iozone —B s 8g -i 0 -i 1 random access

Re: [PATCH 0/1] mm, shmem: map few pages around fault address if they are in page cache

2014-02-28 Thread Ning Qu
Yes, I am using the iozone -i 0 -i 1. Let me try the most simple test as you mentioned. Best wishes, -- Ning Qu On Fri, Feb 28, 2014 at 5:41 PM, Andrew Morton wrote: > On Fri, 28 Feb 2014 16:35:16 -0800 Ning Qu wrote: > >> Sorry about my fault about the experiments, here is the real one. >>

Re: [PATCH 0/1] mm, shmem: map few pages around fault address if they are in page cache

2014-02-28 Thread Andrew Morton
On Fri, 28 Feb 2014 16:35:16 -0800 Ning Qu wrote: > Sorry about my fault about the experiments, here is the real one. > > Btw, apparently, there are still some questions about the results and > I will sync with Kirill about his test command line. > > Below is just some simple experiment

Re: [PATCH 0/1] mm, shmem: map few pages around fault address if they are in page cache

2014-02-28 Thread Ning Qu
Sorry about my fault about the experiments, here is the real one. Btw, apparently, there are still some questions about the results and I will sync with Kirill about his test command line. Below is just some simple experiment numbers from this patch, let me know if you would like more: Tested

Re: [PATCH 0/1] mm, shmem: map few pages around fault address if they are in page cache

2014-02-28 Thread Andrew Morton
On Fri, 28 Feb 2014 14:18:50 -0800 Ning Qu wrote: > This is a follow-up patch for "mm: map few pages around fault address if they > are in page cache" > > We use the generic filemap_map_pages as ->map_pages in shmem/tmpfs. > Please cc Hugh on shmem/tmpfs things > >

[PATCH 0/1] mm, shmem: map few pages around fault address if they are in page cache

2014-02-28 Thread Ning Qu
This is a follow-up patch for "mm: map few pages around fault address if they are in page cache" We use the generic filemap_map_pages as ->map_pages in shmem/tmpfs. Please consider applying. = Below is just some simple

[PATCH 0/1] mm, shmem: map few pages around fault address if they are in page cache

2014-02-28 Thread Ning Qu
This is a follow-up patch for mm: map few pages around fault address if they are in page cache We use the generic filemap_map_pages as -map_pages in shmem/tmpfs. Please consider applying. = Below is just some simple

Re: [PATCH 0/1] mm, shmem: map few pages around fault address if they are in page cache

2014-02-28 Thread Andrew Morton
On Fri, 28 Feb 2014 14:18:50 -0800 Ning Qu qun...@google.com wrote: This is a follow-up patch for mm: map few pages around fault address if they are in page cache We use the generic filemap_map_pages as -map_pages in shmem/tmpfs. Please cc Hugh on shmem/tmpfs things

Re: [PATCH 0/1] mm, shmem: map few pages around fault address if they are in page cache

2014-02-28 Thread Ning Qu
Sorry about my fault about the experiments, here is the real one. Btw, apparently, there are still some questions about the results and I will sync with Kirill about his test command line. Below is just some simple experiment numbers from this patch, let me know if you would like more: Tested

Re: [PATCH 0/1] mm, shmem: map few pages around fault address if they are in page cache

2014-02-28 Thread Andrew Morton
On Fri, 28 Feb 2014 16:35:16 -0800 Ning Qu qun...@gmail.com wrote: Sorry about my fault about the experiments, here is the real one. Btw, apparently, there are still some questions about the results and I will sync with Kirill about his test command line. Below is just some simple

Re: [PATCH 0/1] mm, shmem: map few pages around fault address if they are in page cache

2014-02-28 Thread Ning Qu
Yes, I am using the iozone -i 0 -i 1. Let me try the most simple test as you mentioned. Best wishes, -- Ning Qu On Fri, Feb 28, 2014 at 5:41 PM, Andrew Morton a...@linux-foundation.org wrote: On Fri, 28 Feb 2014 16:35:16 -0800 Ning Qu qun...@gmail.com wrote: Sorry about my fault about the

Re: [PATCH 0/1] mm, shmem: map few pages around fault address if they are in page cache

2014-02-28 Thread Ning Qu
Yes, the simple test does verify that the page fault number are correct with the patch. So my previous results are from those command lines, which also show some performance improvement with this change in tmpfs. sequential access /usr/bin/time -a ./iozone —B s 8g -i 0 -i 1 random access