Re: [PATCH 0/2] [BUG FIXES - 3.10.27] sit: More backports

2014-01-30 Thread Steven Rostedt
On Thu, 30 Jan 2014 14:42:57 +0100 Nicolas Dichtel wrote: > > I'll let you know when these are finished. > Thank you for testing. Our short tests that were crashing have all now passed :-) with your patches applied. We are now running our full tier tests on the code, but I don't think we need

Re: [PATCH 0/2] [BUG FIXES - 3.10.27] sit: More backports

2014-01-30 Thread Nicolas Dichtel
Le 30/01/2014 14:31, Steven Rostedt a écrit : On Thu, 30 Jan 2014 10:28:43 +0100 Nicolas Dichtel wrote: Steve, I think the patch I sent yesterday is the good fix. At the end, it's a backport of Willem's patch. Note that he also ack that patch. The first version you sent (which removes

Re: [PATCH 0/2] [BUG FIXES - 3.10.27] sit: More backports

2014-01-30 Thread Steven Rostedt
On Thu, 30 Jan 2014 10:28:43 +0100 Nicolas Dichtel wrote: > Steve, I think the patch I sent yesterday is the good fix. At the end, it's > a backport of Willem's patch. Note that he also ack that patch. > The first version you sent (which removes > unregister_netdevice_queue(sitn->fb_tunnel_dev,

Re: [PATCH 0/2] [BUG FIXES - 3.10.27] sit: More backports

2014-01-30 Thread Nicolas Dichtel
Le 29/01/2014 21:48, Steven Rostedt a écrit : On Wed, 29 Jan 2014 17:04:12 +0100 Nicolas Dichtel wrote: Your patch serie seems to be the good way to go (note that patch 1/2 does not compile) but I think the fix is smaller because we don't have x-netns. Here is my proposal, if you agree, I

Re: [PATCH 0/2] [BUG FIXES - 3.10.27] sit: More backports

2014-01-30 Thread Nicolas Dichtel
Le 29/01/2014 21:48, Steven Rostedt a écrit : On Wed, 29 Jan 2014 17:04:12 +0100 Nicolas Dichtel nicolas.dich...@6wind.com wrote: Your patch serie seems to be the good way to go (note that patch 1/2 does not compile) but I think the fix is smaller because we don't have x-netns. Here is my

Re: [PATCH 0/2] [BUG FIXES - 3.10.27] sit: More backports

2014-01-30 Thread Steven Rostedt
On Thu, 30 Jan 2014 10:28:43 +0100 Nicolas Dichtel nicolas.dich...@6wind.com wrote: Steve, I think the patch I sent yesterday is the good fix. At the end, it's a backport of Willem's patch. Note that he also ack that patch. The first version you sent (which removes

Re: [PATCH 0/2] [BUG FIXES - 3.10.27] sit: More backports

2014-01-30 Thread Nicolas Dichtel
Le 30/01/2014 14:31, Steven Rostedt a écrit : On Thu, 30 Jan 2014 10:28:43 +0100 Nicolas Dichtel nicolas.dich...@6wind.com wrote: Steve, I think the patch I sent yesterday is the good fix. At the end, it's a backport of Willem's patch. Note that he also ack that patch. The first version you

Re: [PATCH 0/2] [BUG FIXES - 3.10.27] sit: More backports

2014-01-30 Thread Steven Rostedt
On Thu, 30 Jan 2014 14:42:57 +0100 Nicolas Dichtel nicolas.dich...@6wind.com wrote: I'll let you know when these are finished. Thank you for testing. Our short tests that were crashing have all now passed :-) with your patches applied. We are now running our full tier tests on the code, but

Re: [PATCH 0/2] [BUG FIXES - 3.10.27] sit: More backports

2014-01-29 Thread Steven Rostedt
On Wed, 29 Jan 2014 17:04:12 +0100 Nicolas Dichtel wrote: > Your patch serie seems to be the good way to go (note that patch 1/2 does not > compile) but I think the fix is smaller because we don't have x-netns. > > Here is my proposal, if you agree, I will send the same patch for ip6_tunnnel,

Re: [PATCH 0/2] [BUG FIXES - 3.10.27] sit: More backports

2014-01-29 Thread Willem de Bruijn
> From d101450583c3a472a2a94904cfe13fd4e7d2f519 Mon Sep 17 00:00:00 2001 > From: Nicolas Dichtel > Date: Wed, 29 Jan 2014 16:40:30 +0100 > Subject: [PATCH] sit: fix double free of fb_tunnel_dev on exit > > This problem was fixed upstream by commit 9434266f2c64 ("sit: fix use after > free > of

Re: [PATCH 0/2] [BUG FIXES - 3.10.27] sit: More backports

2014-01-29 Thread Nicolas Dichtel
Le 29/01/2014 13:57, Steven Rostedt a écrit : On Wed, 29 Jan 2014 12:04:05 +0100 Nicolas Dichtel wrote: Le 28/01/2014 21:57, Steven Rostedt a écrit : At Red Hat we base our real-time kernel off of 3.10.27 and do lots of stress testing on that kernel. This has discovered some bugs that we can

Re: [PATCH 0/2] [BUG FIXES - 3.10.27] sit: More backports

2014-01-29 Thread Steven Rostedt
On Tue, 28 Jan 2014 23:52:14 -0800 (PST) David Miller wrote: > Greg, these have my blessing, please apply these to 3.10 -stable, > thanks a lot! Hi David, Thanks for the blessing :-) But I want to work with Nicolas a bit more to make sure that I have a correct backport. Just because it fixed

Re: [PATCH 0/2] [BUG FIXES - 3.10.27] sit: More backports

2014-01-29 Thread Steven Rostedt
On Wed, 29 Jan 2014 12:04:05 +0100 Nicolas Dichtel wrote: > Le 28/01/2014 21:57, Steven Rostedt a écrit : > > At Red Hat we base our real-time kernel off of 3.10.27 and do lots of > > stress testing on that kernel. This has discovered some bugs that we > > can hit with the vanilla 3.10.27 kernel

Re: [PATCH 0/2] [BUG FIXES - 3.10.27] sit: More backports

2014-01-29 Thread Nicolas Dichtel
Le 28/01/2014 21:57, Steven Rostedt a écrit : At Red Hat we base our real-time kernel off of 3.10.27 and do lots of stress testing on that kernel. This has discovered some bugs that we can hit with the vanilla 3.10.27 kernel (no -rt patches applied). I sent out a bug fix that can cause a crash

Re: [PATCH 0/2] [BUG FIXES - 3.10.27] sit: More backports

2014-01-29 Thread Nicolas Dichtel
Le 28/01/2014 21:57, Steven Rostedt a écrit : At Red Hat we base our real-time kernel off of 3.10.27 and do lots of stress testing on that kernel. This has discovered some bugs that we can hit with the vanilla 3.10.27 kernel (no -rt patches applied). I sent out a bug fix that can cause a crash

Re: [PATCH 0/2] [BUG FIXES - 3.10.27] sit: More backports

2014-01-29 Thread Steven Rostedt
On Wed, 29 Jan 2014 12:04:05 +0100 Nicolas Dichtel nicolas.dich...@6wind.com wrote: Le 28/01/2014 21:57, Steven Rostedt a écrit : At Red Hat we base our real-time kernel off of 3.10.27 and do lots of stress testing on that kernel. This has discovered some bugs that we can hit with the

Re: [PATCH 0/2] [BUG FIXES - 3.10.27] sit: More backports

2014-01-29 Thread Steven Rostedt
On Tue, 28 Jan 2014 23:52:14 -0800 (PST) David Miller da...@davemloft.net wrote: Greg, these have my blessing, please apply these to 3.10 -stable, thanks a lot! Hi David, Thanks for the blessing :-) But I want to work with Nicolas a bit more to make sure that I have a correct backport. Just

Re: [PATCH 0/2] [BUG FIXES - 3.10.27] sit: More backports

2014-01-29 Thread Nicolas Dichtel
Le 29/01/2014 13:57, Steven Rostedt a écrit : On Wed, 29 Jan 2014 12:04:05 +0100 Nicolas Dichtel nicolas.dich...@6wind.com wrote: Le 28/01/2014 21:57, Steven Rostedt a écrit : At Red Hat we base our real-time kernel off of 3.10.27 and do lots of stress testing on that kernel. This has

Re: [PATCH 0/2] [BUG FIXES - 3.10.27] sit: More backports

2014-01-29 Thread Willem de Bruijn
From d101450583c3a472a2a94904cfe13fd4e7d2f519 Mon Sep 17 00:00:00 2001 From: Nicolas Dichtel nicolas.dich...@6wind.com Date: Wed, 29 Jan 2014 16:40:30 +0100 Subject: [PATCH] sit: fix double free of fb_tunnel_dev on exit This problem was fixed upstream by commit 9434266f2c64 (sit: fix use

Re: [PATCH 0/2] [BUG FIXES - 3.10.27] sit: More backports

2014-01-29 Thread Steven Rostedt
On Wed, 29 Jan 2014 17:04:12 +0100 Nicolas Dichtel nicolas.dich...@6wind.com wrote: Your patch serie seems to be the good way to go (note that patch 1/2 does not compile) but I think the fix is smaller because we don't have x-netns. Here is my proposal, if you agree, I will send the same

Re: [PATCH 0/2] [BUG FIXES - 3.10.27] sit: More backports

2014-01-28 Thread David Miller
From: Steven Rostedt Date: Tue, 28 Jan 2014 15:57:56 -0500 > At Red Hat we base our real-time kernel off of 3.10.27 and do lots of > stress testing on that kernel. This has discovered some bugs that we > can hit with the vanilla 3.10.27 kernel (no -rt patches applied). > > I sent out a bug fix

[PATCH 0/2] [BUG FIXES - 3.10.27] sit: More backports

2014-01-28 Thread Steven Rostedt
At Red Hat we base our real-time kernel off of 3.10.27 and do lots of stress testing on that kernel. This has discovered some bugs that we can hit with the vanilla 3.10.27 kernel (no -rt patches applied). I sent out a bug fix that can cause a crash with the current 3.10.27 when you add and then

[PATCH 0/2] [BUG FIXES - 3.10.27] sit: More backports

2014-01-28 Thread Steven Rostedt
At Red Hat we base our real-time kernel off of 3.10.27 and do lots of stress testing on that kernel. This has discovered some bugs that we can hit with the vanilla 3.10.27 kernel (no -rt patches applied). I sent out a bug fix that can cause a crash with the current 3.10.27 when you add and then

Re: [PATCH 0/2] [BUG FIXES - 3.10.27] sit: More backports

2014-01-28 Thread David Miller
From: Steven Rostedt rost...@goodmis.org Date: Tue, 28 Jan 2014 15:57:56 -0500 At Red Hat we base our real-time kernel off of 3.10.27 and do lots of stress testing on that kernel. This has discovered some bugs that we can hit with the vanilla 3.10.27 kernel (no -rt patches applied). I sent