Re: [PATCH 0/2] Fix W+X debug feature on x86

2020-05-22 Thread Steven Price
On 21/05/2020 20:08, Andrew Morton wrote: On Thu, 21 May 2020 16:23:06 +0100 Steven Price wrote: Jan alert me[1] that the W+X detection debug feature was broken in x86 by my change[2] to switch x86 to use the generic ptdump infrastructure. Fundamentally the approach of trying to move the

Re: [PATCH 0/2] Fix W+X debug feature on x86

2020-05-21 Thread Andrew Morton
On Thu, 21 May 2020 16:23:06 +0100 Steven Price wrote: > Jan alert me[1] that the W+X detection debug feature was broken in x86 > by my change[2] to switch x86 to use the generic ptdump infrastructure. > > Fundamentally the approach of trying to move the calculation of > effective permissions

[PATCH 0/2] Fix W+X debug feature on x86

2020-05-21 Thread Steven Price
Jan alert me[1] that the W+X detection debug feature was broken in x86 by my change[2] to switch x86 to use the generic ptdump infrastructure. Fundamentally the approach of trying to move the calculation of effective permissions into note_page() was broken because note_page() is only called for