Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-09 Thread Ulf Hansson
On 9 November 2015 at 14:14, Ludovic Desroches wrote: > On Mon, Nov 09, 2015 at 11:50:50AM +0100, Ulf Hansson wrote: >> [...] >> >> >> >> >> This doesn't seems like a case where a gpio regulator should be used >> >> and I am not sure what problem it would solve. Beside to suppress the >> >> log

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-09 Thread Ludovic Desroches
On Mon, Nov 09, 2015 at 11:50:50AM +0100, Ulf Hansson wrote: > [...] > > >> > >> This doesn't seems like a case where a gpio regulator should be used > >> and I am not sure what problem it would solve. Beside to suppress the > >> log warnings (actually those aren't warnings but informations). >

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-09 Thread Ulf Hansson
[...] >> >> This doesn't seems like a case where a gpio regulator should be used >> and I am not sure what problem it would solve. Beside to suppress the >> log warnings (actually those aren't warnings but informations). >> >> Isn't sdhci_do_start_signal_voltage_switch() doing what you need here?

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-09 Thread Ludovic Desroches
On Mon, Nov 09, 2015 at 10:38:03AM +0100, Ulf Hansson wrote: > [...] > > >> > Is the regulator-gpio usage the right thing to do for vqmmc? In my case > >> > it is > >> > not really driven by a gpio but by a pio from the sdhci device. In the > >> > binding, > >> > >> What's a "pio"? > >> > >>

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-09 Thread Ulf Hansson
[...] >> > Is the regulator-gpio usage the right thing to do for vqmmc? In my case it >> > is >> > not really driven by a gpio but by a pio from the sdhci device. In the >> > binding, >> >> What's a "pio"? >> >> What do you mean by the it's driven from the sdhci device? >> > > Sorry I mean

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-09 Thread Ludovic Desroches
On Mon, Nov 09, 2015 at 11:50:50AM +0100, Ulf Hansson wrote: > [...] > > >> > >> This doesn't seems like a case where a gpio regulator should be used > >> and I am not sure what problem it would solve. Beside to suppress the > >> log warnings (actually those aren't warnings but informations). >

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-09 Thread Ulf Hansson
On 9 November 2015 at 14:14, Ludovic Desroches wrote: > On Mon, Nov 09, 2015 at 11:50:50AM +0100, Ulf Hansson wrote: >> [...] >> >> >> >> >> This doesn't seems like a case where a gpio regulator should be used >> >> and I am not sure what problem it would solve.

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-09 Thread Ulf Hansson
[...] >> >> This doesn't seems like a case where a gpio regulator should be used >> and I am not sure what problem it would solve. Beside to suppress the >> log warnings (actually those aren't warnings but informations). >> >> Isn't sdhci_do_start_signal_voltage_switch() doing what you need here?

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-09 Thread Ludovic Desroches
On Mon, Nov 09, 2015 at 10:38:03AM +0100, Ulf Hansson wrote: > [...] > > >> > Is the regulator-gpio usage the right thing to do for vqmmc? In my case > >> > it is > >> > not really driven by a gpio but by a pio from the sdhci device. In the > >> > binding, > >> > >> What's a "pio"? > >> > >>

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-09 Thread Ulf Hansson
[...] >> > Is the regulator-gpio usage the right thing to do for vqmmc? In my case it >> > is >> > not really driven by a gpio but by a pio from the sdhci device. In the >> > binding, >> >> What's a "pio"? >> >> What do you mean by the it's driven from the sdhci device? >> > > Sorry I mean

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-08 Thread Ludovic Desroches
Hi Ulf, Thanks for your answer. On Fri, Nov 06, 2015 at 05:42:51PM +0100, Ulf Hansson wrote: > On 6 November 2015 at 16:59, Ludovic Desroches > wrote: > > Hi, > > > > I would like to have some feedback for these two patches. I have two > > questions. > > > > 1. > > > > To suppress the warnings

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-08 Thread Ludovic Desroches
Hi Ulf, Thanks for your answer. On Fri, Nov 06, 2015 at 05:42:51PM +0100, Ulf Hansson wrote: > On 6 November 2015 at 16:59, Ludovic Desroches > wrote: > > Hi, > > > > I would like to have some feedback for these two patches. I have two > > questions. > > > > 1. > >

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-06 Thread Ulf Hansson
On 6 November 2015 at 16:59, Ludovic Desroches wrote: > Hi, > > I would like to have some feedback for these two patches. I have two > questions. > > 1. > > To suppress the warnings telling me I have no vmmc and vqmmc supplies, I have > added them and discovered that adding a vmmc supply involve

[PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-06 Thread Ludovic Desroches
Hi, I would like to have some feedback for these two patches. I have two questions. 1. To suppress the warnings telling me I have no vmmc and vqmmc supplies, I have added them and discovered that adding a vmmc supply involve only writing 1 in the Power Control Register involves enabling the SD

[PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-06 Thread Ludovic Desroches
Hi, I would like to have some feedback for these two patches. I have two questions. 1. To suppress the warnings telling me I have no vmmc and vqmmc supplies, I have added them and discovered that adding a vmmc supply involve only writing 1 in the Power Control Register involves enabling the SD

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-06 Thread Ulf Hansson
On 6 November 2015 at 16:59, Ludovic Desroches wrote: > Hi, > > I would like to have some feedback for these two patches. I have two > questions. > > 1. > > To suppress the warnings telling me I have no vmmc and vqmmc supplies, I have > added them and discovered that