Re: [PATCH 0/2] nvme-pic: improve max I/O queue handling

2020-11-13 Thread Niklas Schnelle
On 11/13/20 5:25 PM, Christoph Hellwig wrote: > On Fri, Nov 13, 2020 at 02:15:59PM +0100, Niklas Schnelle wrote: >> >> >> On 11/12/20 6:36 PM, Keith Busch wrote: >>> On Thu, Nov 12, 2020 at 04:45:35PM +0100, Niklas Schnelle wrote: You got to get something wrong, I hope in this case it's

Re: [PATCH 0/2] nvme-pic: improve max I/O queue handling

2020-11-13 Thread Christoph Hellwig
On Fri, Nov 13, 2020 at 02:15:59PM +0100, Niklas Schnelle wrote: > > > On 11/12/20 6:36 PM, Keith Busch wrote: > > On Thu, Nov 12, 2020 at 04:45:35PM +0100, Niklas Schnelle wrote: > >> You got to get something wrong, I hope in this case it's just the subject > >> of the cover letter :D > > > >

Re: [PATCH 0/2] nvme-pic: improve max I/O queue handling

2020-11-13 Thread Niklas Schnelle
On 11/12/20 6:36 PM, Keith Busch wrote: > On Thu, Nov 12, 2020 at 04:45:35PM +0100, Niklas Schnelle wrote: >> You got to get something wrong, I hope in this case it's just the subject >> of the cover letter :D > > I suppose the change logs could be worded a little better :) Do you think I

Re: [PATCH 0/2] nvme-pic: improve max I/O queue handling

2020-11-12 Thread Keith Busch
On Thu, Nov 12, 2020 at 04:45:35PM +0100, Niklas Schnelle wrote: > You got to get something wrong, I hope in this case it's just the subject > of the cover letter :D I suppose the change logs could be worded a little better :) > Thanks for the review, I appreciate it. Might be getting ahead of >

Re: [PATCH 0/2] nvme-pic: improve max I/O queue handling

2020-11-12 Thread Niklas Schnelle
On 11/12/20 3:53 PM, Keith Busch wrote: > On Thu, Nov 12, 2020 at 09:23:00AM +0100, Niklas Schnelle wrote: >> while searching for a bug around zPCI + NVMe IRQ handling on a distro >> kernel, I got confused around handling of the maximum number >> of I/O queues in the NVMe driver. >> I think I

Re: [PATCH 0/2] nvme-pic: improve max I/O queue handling

2020-11-12 Thread Keith Busch
On Thu, Nov 12, 2020 at 09:23:00AM +0100, Niklas Schnelle wrote: > while searching for a bug around zPCI + NVMe IRQ handling on a distro > kernel, I got confused around handling of the maximum number > of I/O queues in the NVMe driver. > I think I groked it in the end but would like to propose the

[PATCH 0/2] nvme-pic: improve max I/O queue handling

2020-11-12 Thread Niklas Schnelle
Hi, while searching for a bug around zPCI + NVMe IRQ handling on a distro kernel, I got confused around handling of the maximum number of I/O queues in the NVMe driver. I think I groked it in the end but would like to propose the following improvements, that said I'm quite new to this code. I