Re: [PATCH 0/2] ptrace/x86: simplify ptrace_write_dr7()

2013-04-16 Thread Jan Kratochvil
On Tue, 16 Apr 2013 15:25:45 +0200, Oleg Nesterov wrote: > On 04/16, Frederic Weisbecker wrote: > > On Sun, Apr 14, 2013 at 09:12:05PM +0200, Oleg Nesterov wrote: > > Looking at the bug report, it seems they only reproduced with a homemade > > test. No real app has reported that issue? > > iirc

Re: [PATCH 0/2] ptrace/x86: simplify ptrace_write_dr7()

2013-04-16 Thread Oleg Nesterov
On 04/16, Frederic Weisbecker wrote: > > On Sun, Apr 14, 2013 at 09:12:05PM +0200, Oleg Nesterov wrote: > > Looking at the bug report, it seems they only reproduced with a homemade > test. No real app has reported that issue? iirc (Jan can correct me) gdb hit this problem, but it was already

Re: [PATCH 0/2] ptrace/x86: simplify ptrace_write_dr7()

2013-04-16 Thread Oleg Nesterov
On 04/16, Frederic Weisbecker wrote: On Sun, Apr 14, 2013 at 09:12:05PM +0200, Oleg Nesterov wrote: Looking at the bug report, it seems they only reproduced with a homemade test. No real app has reported that issue? iirc (Jan can correct me) gdb hit this problem, but it was already changed

Re: [PATCH 0/2] ptrace/x86: simplify ptrace_write_dr7()

2013-04-16 Thread Jan Kratochvil
On Tue, 16 Apr 2013 15:25:45 +0200, Oleg Nesterov wrote: On 04/16, Frederic Weisbecker wrote: On Sun, Apr 14, 2013 at 09:12:05PM +0200, Oleg Nesterov wrote: Looking at the bug report, it seems they only reproduced with a homemade test. No real app has reported that issue? iirc (Jan can

Re: [PATCH 0/2] ptrace/x86: simplify ptrace_write_dr7()

2013-04-15 Thread Frederic Weisbecker
On Sun, Apr 14, 2013 at 09:12:05PM +0200, Oleg Nesterov wrote: > Hello. > > On top of "[PATCH 0/5] kill ptrace_{get,put}_breakpoints()". > Cleanup and preparation for the potential fix, see below. > > -- > Now the

Re: [PATCH 0/2] ptrace/x86: simplify ptrace_write_dr7()

2013-04-15 Thread Frederic Weisbecker
On Sun, Apr 14, 2013 at 09:12:05PM +0200, Oleg Nesterov wrote: Hello. On top of [PATCH 0/5] kill ptrace_{get,put}_breakpoints(). Cleanup and preparation for the potential fix, see below. -- Now the question.

Re: [PATCH 0/2] ptrace/x86: simplify ptrace_write_dr7()

2013-04-14 Thread Oleg Nesterov
On 04/14, Jan Kratochvil wrote: > > On Sun, 14 Apr 2013 21:12:05 +0200, Oleg Nesterov wrote: > > Jan, Frederic, et all. What do you think we should do? > > > > 1. Change ptrace_write_dr7() to do register_user_hw_breakpoint() > >if necessary. > > > >This is what I was going to

Re: [PATCH 0/2] ptrace/x86: simplify ptrace_write_dr7()

2013-04-14 Thread Jan Kratochvil
On Sun, 14 Apr 2013 21:12:05 +0200, Oleg Nesterov wrote: > Jan, Frederic, et all. What do you think we should do? > > 1. Change ptrace_write_dr7() to do register_user_hw_breakpoint() > if necessary. > > This is what I was going to do, but I am no longer sure > we

[PATCH 0/2] ptrace/x86: simplify ptrace_write_dr7()

2013-04-14 Thread Oleg Nesterov
Hello. On top of "[PATCH 0/5] kill ptrace_{get,put}_breakpoints()". Cleanup and preparation for the potential fix, see below. -- Now the question. Initially I was going to make more patches and fix the regression

[PATCH 0/2] ptrace/x86: simplify ptrace_write_dr7()

2013-04-14 Thread Oleg Nesterov
Hello. On top of [PATCH 0/5] kill ptrace_{get,put}_breakpoints(). Cleanup and preparation for the potential fix, see below. -- Now the question. Initially I was going to make more patches and fix the regression

Re: [PATCH 0/2] ptrace/x86: simplify ptrace_write_dr7()

2013-04-14 Thread Jan Kratochvil
On Sun, 14 Apr 2013 21:12:05 +0200, Oleg Nesterov wrote: Jan, Frederic, et all. What do you think we should do? 1. Change ptrace_write_dr7() to do register_user_hw_breakpoint() if necessary. This is what I was going to do, but I am no longer sure we want

Re: [PATCH 0/2] ptrace/x86: simplify ptrace_write_dr7()

2013-04-14 Thread Oleg Nesterov
On 04/14, Jan Kratochvil wrote: On Sun, 14 Apr 2013 21:12:05 +0200, Oleg Nesterov wrote: Jan, Frederic, et all. What do you think we should do? 1. Change ptrace_write_dr7() to do register_user_hw_breakpoint() if necessary. This is what I was going to do, but I am no