Re: [PATCH 0/3] add support for metadata encryption to F2FS

2020-12-25 Thread Chao Yu
On 2020/12/24 18:13, Satya Tangirala wrote: On Tue, Dec 22, 2020 at 07:47:45PM +0800, Chao Yu wrote: On 2020/12/18 19:53, Satya Tangirala wrote: On Fri, Dec 18, 2020 at 05:02:23PM +0800, Chao Yu wrote: But, what's the plan about supporting software encryption for metadata? Current f2fs write

Re: [PATCH 0/3] add support for metadata encryption to F2FS

2020-12-24 Thread Satya Tangirala
On Tue, Dec 22, 2020 at 07:47:45PM +0800, Chao Yu wrote: > On 2020/12/18 19:53, Satya Tangirala wrote: > > On Fri, Dec 18, 2020 at 05:02:23PM +0800, Chao Yu wrote: > > > But, what's the plan about supporting software encryption for metadata? > > > Current > > > f2fs write flow will handle all

Re: [PATCH 0/3] add support for metadata encryption to F2FS

2020-12-22 Thread Chao Yu
On 2020/12/18 19:53, Satya Tangirala wrote: On Fri, Dec 18, 2020 at 05:02:23PM +0800, Chao Yu wrote: On 2020/12/17 23:44, Satya Tangirala wrote: On Sat, Oct 10, 2020 at 05:53:06PM +0800, Chao Yu wrote: Why not using nid as DUN, then GC could migrate encrypted node block directly via meta

Re: [PATCH 0/3] add support for metadata encryption to F2FS

2020-12-18 Thread Satya Tangirala
On Fri, Dec 18, 2020 at 05:02:23PM +0800, Chao Yu wrote: > On 2020/12/17 23:44, Satya Tangirala wrote: > > On Sat, Oct 10, 2020 at 05:53:06PM +0800, Chao Yu wrote: > > > Why not using nid as DUN, then GC could migrate encrypted node block > > > directly via > > > meta inode's address space like

Re: [PATCH 0/3] add support for metadata encryption to F2FS

2020-12-18 Thread Chao Yu
On 2020/12/17 23:44, Satya Tangirala wrote: On Sat, Oct 10, 2020 at 05:53:06PM +0800, Chao Yu wrote: On 2020/10/5 15:36, Satya Tangirala wrote: This patch series adds support for metadata encryption to F2FS using blk-crypto. It looks this implementation is based on hardware crypto engine,

Re: [PATCH 0/3] add support for metadata encryption to F2FS

2020-12-17 Thread Satya Tangirala
On Sat, Oct 10, 2020 at 05:53:06PM +0800, Chao Yu wrote: > On 2020/10/5 15:36, Satya Tangirala wrote: > > This patch series adds support for metadata encryption to F2FS using > > blk-crypto. > > It looks this implementation is based on hardware crypto engine, could you > please add this info into

Re: [PATCH 0/3] add support for metadata encryption to F2FS

2020-10-10 Thread Chao Yu
On 2020/10/5 15:36, Satya Tangirala wrote: This patch series adds support for metadata encryption to F2FS using blk-crypto. It looks this implementation is based on hardware crypto engine, could you please add this info into f2fs.rst as well like inlinecrypt... Patch 1 replaces

Re: [PATCH 0/3] add support for metadata encryption to F2FS

2020-10-08 Thread Eric Biggers
On Wed, Oct 07, 2020 at 10:05:00PM +, Satya Tangirala wrote: > > I notice this is missing the step I suggested to include the metadata > > encryption > > key in the HKDF application-specific info string when deriving subkeys from > > the > > fscrypt master keys. > > > > The same effect

Re: [PATCH 0/3] add support for metadata encryption to F2FS

2020-10-07 Thread Satya Tangirala
On Wed, Oct 07, 2020 at 02:00:40PM -0700, Eric Biggers wrote: > On Mon, Oct 05, 2020 at 07:36:03AM +, Satya Tangirala wrote: > > This patch series adds support for metadata encryption to F2FS using > > blk-crypto. > > This patch series needs more explanation about what "metadata encryption"

Re: [PATCH 0/3] add support for metadata encryption to F2FS

2020-10-07 Thread Eric Biggers
On Mon, Oct 05, 2020 at 07:36:03AM +, Satya Tangirala wrote: > This patch series adds support for metadata encryption to F2FS using > blk-crypto. This patch series needs more explanation about what "metadata encryption" is, why people will want to use it (as opposed to either not using it, or

Re: [PATCH 0/3] add support for metadata encryption to F2FS

2020-10-05 Thread Satya Tangirala
On Mon, Oct 05, 2020 at 07:36:03AM +, Satya Tangirala wrote: > This patch series adds support for metadata encryption to F2FS using > blk-crypto. > > Patch 1 replaces fscrypt_get_devices (which took an array of request_queues > and filled it up) with fscrypt_get_device, which takes a index of

[PATCH 0/3] add support for metadata encryption to F2FS

2020-10-05 Thread Satya Tangirala
This patch series adds support for metadata encryption to F2FS using blk-crypto. Patch 1 replaces fscrypt_get_devices (which took an array of request_queues and filled it up) with fscrypt_get_device, which takes a index of the desired device and returns the device at that index (so the index