Re: [PATCH 0/3] fs: reduce export usage of kerne_read*() calls

2020-07-28 Thread Luis Chamberlain
On Mon, May 18, 2020 at 08:21:08AM -0700, Kees Cook wrote: > On Mon, May 18, 2020 at 08:37:42AM -0400, Mimi Zohar wrote: > > Hi Christoph, > > > > On Sun, 2020-05-17 at 23:22 -0700, Christoph Hellwig wrote: > > > On Fri, May 15, 2020 at 09:29:33PM +, Luis Chamberlain wrote: > > > > On Wed,

Re: [PATCH 0/3] fs: reduce export usage of kerne_read*() calls

2020-06-05 Thread Mimi Zohar
On Fri, 2020-06-05 at 11:15 -0700, Scott Branden wrote: > Hi Mimi, > > On 2020-05-23 7:52 p.m., Mimi Zohar wrote: > > Scott, the change should be straight forward.  The additional patch > > needs to: > > - define a new kernel_read_file_id enumeration, like > > FIRMWARE_PARTIAL_READ. > > -

Re: [PATCH 0/3] fs: reduce export usage of kerne_read*() calls

2020-06-05 Thread Scott Branden
Hi Mimi, On 2020-05-23 7:52 p.m., Mimi Zohar wrote: On Fri, 2020-05-22 at 16:25 -0700, Scott Branden wrote: Hi Kees, On 2020-05-22 4:04 p.m., Kees Cook wrote: On Fri, May 22, 2020 at 03:24:32PM -0700, Scott Branden wrote: On 2020-05-18 5:37 a.m., Mimi Zohar wrote: On Sun, 2020-05-17 at

Re: [PATCH 0/3] fs: reduce export usage of kerne_read*() calls

2020-05-23 Thread Mimi Zohar
On Fri, 2020-05-22 at 16:25 -0700, Scott Branden wrote: > Hi Kees, > > On 2020-05-22 4:04 p.m., Kees Cook wrote: > > On Fri, May 22, 2020 at 03:24:32PM -0700, Scott Branden wrote: > >> On 2020-05-18 5:37 a.m., Mimi Zohar wrote: > >>> On Sun, 2020-05-17 at 23:22 -0700, Christoph Hellwig wrote: >

Re: [PATCH 0/3] fs: reduce export usage of kerne_read*() calls

2020-05-22 Thread Scott Branden
Hi Kees, On 2020-05-22 4:04 p.m., Kees Cook wrote: On Fri, May 22, 2020 at 03:24:32PM -0700, Scott Branden wrote: On 2020-05-18 5:37 a.m., Mimi Zohar wrote: On Sun, 2020-05-17 at 23:22 -0700, Christoph Hellwig wrote: On Fri, May 15, 2020 at 09:29:33PM +, Luis Chamberlain wrote: On Wed,

Re: [PATCH 0/3] fs: reduce export usage of kerne_read*() calls

2020-05-22 Thread Kees Cook
On Fri, May 22, 2020 at 03:24:32PM -0700, Scott Branden wrote: > On 2020-05-18 5:37 a.m., Mimi Zohar wrote: > > On Sun, 2020-05-17 at 23:22 -0700, Christoph Hellwig wrote: > > > On Fri, May 15, 2020 at 09:29:33PM +, Luis Chamberlain wrote: > > > > On Wed, May 13, 2020 at 11:17:36AM -0700,

Re: [PATCH 0/3] fs: reduce export usage of kerne_read*() calls

2020-05-22 Thread Scott Branden
Hi Mimi, On 2020-05-18 5:37 a.m., Mimi Zohar wrote: Hi Christoph, On Sun, 2020-05-17 at 23:22 -0700, Christoph Hellwig wrote: On Fri, May 15, 2020 at 09:29:33PM +, Luis Chamberlain wrote: On Wed, May 13, 2020 at 11:17:36AM -0700, Christoph Hellwig wrote: Can you also move kernel_read_*

Re: [PATCH 0/3] fs: reduce export usage of kerne_read*() calls

2020-05-18 Thread Kees Cook
On Mon, May 18, 2020 at 08:37:42AM -0400, Mimi Zohar wrote: > Hi Christoph, > > On Sun, 2020-05-17 at 23:22 -0700, Christoph Hellwig wrote: > > On Fri, May 15, 2020 at 09:29:33PM +, Luis Chamberlain wrote: > > > On Wed, May 13, 2020 at 11:17:36AM -0700, Christoph Hellwig wrote: > > > > Can

Re: [PATCH 0/3] fs: reduce export usage of kerne_read*() calls

2020-05-18 Thread Mimi Zohar
Hi Christoph, On Sun, 2020-05-17 at 23:22 -0700, Christoph Hellwig wrote: > On Fri, May 15, 2020 at 09:29:33PM +, Luis Chamberlain wrote: > > On Wed, May 13, 2020 at 11:17:36AM -0700, Christoph Hellwig wrote: > > > Can you also move kernel_read_* out of fs.h? That header gets pulled > > > in

Re: [PATCH 0/3] fs: reduce export usage of kerne_read*() calls

2020-05-18 Thread Christoph Hellwig
On Fri, May 15, 2020 at 09:29:33PM +, Luis Chamberlain wrote: > On Wed, May 13, 2020 at 11:17:36AM -0700, Christoph Hellwig wrote: > > Can you also move kernel_read_* out of fs.h? That header gets pulled > > in just about everywhere and doesn't really need function not related > > to the

Re: [PATCH 0/3] fs: reduce export usage of kerne_read*() calls

2020-05-15 Thread Luis Chamberlain
On Wed, May 13, 2020 at 11:17:36AM -0700, Christoph Hellwig wrote: > Can you also move kernel_read_* out of fs.h? That header gets pulled > in just about everywhere and doesn't really need function not related > to the general fs interface. Sure, where should I dump these? Luis

Re: [PATCH 0/3] fs: reduce export usage of kerne_read*() calls

2020-05-13 Thread Christoph Hellwig
Can you also move kernel_read_* out of fs.h? That header gets pulled in just about everywhere and doesn't really need function not related to the general fs interface.

[PATCH 0/3] fs: reduce export usage of kerne_read*() calls

2020-05-13 Thread Luis Chamberlain
While reviewing Scott Branden's submission of the new Broadcom VK driver driver upstream [0], part of which included 4 new pread varaints of the existing kernel_read*(), calls I grew shivers of the possibility of drivers using these exported symbols loosely. If we're going to grow these, it seems