Re: cgroup aware oom killer (was Re: [PATCH 0/3] introduce memory.oom.group)

2018-08-20 Thread Roman Gushchin
On Sun, Aug 19, 2018 at 04:26:50PM -0700, David Rientjes wrote: > Roman, have you had time to go through this? Hm, I thought we've finished this part of discussion, no? Anyway, let me repeat my position: I don't like the interface you've proposed in that follow-up patchset, and I explained why. If

cgroup aware oom killer (was Re: [PATCH 0/3] introduce memory.oom.group)

2018-08-19 Thread David Rientjes
Roman, have you had time to go through this? On Tue, 7 Aug 2018, David Rientjes wrote: > On Mon, 6 Aug 2018, Roman Gushchin wrote: > > > > In a cgroup-aware oom killer world, yes, we need the ability to specify > > > that the usage of the entire subtree should be compared as a single > > > en

Re: [PATCH 0/3] introduce memory.oom.group

2018-08-10 Thread Michal Hocko
On Thu 09-08-18 13:10:10, David Rientjes wrote: > On Wed, 8 Aug 2018, Michal Hocko wrote: > > > > > > In a cgroup-aware oom killer world, yes, we need the ability to > > > > > specify > > > > > that the usage of the entire subtree should be compared as a single > > > > > entity with other cgrou

Re: [PATCH 0/3] introduce memory.oom.group

2018-08-09 Thread David Rientjes
On Wed, 8 Aug 2018, Michal Hocko wrote: > > > > In a cgroup-aware oom killer world, yes, we need the ability to specify > > > > that the usage of the entire subtree should be compared as a single > > > > entity with other cgroups. That is necessary for user subtrees but may > > > > not be nece

Re: [PATCH 0/3] introduce memory.oom.group

2018-08-08 Thread Michal Hocko
On Tue 07-08-18 15:34:58, David Rientjes wrote: > On Mon, 6 Aug 2018, Roman Gushchin wrote: > > > > In a cgroup-aware oom killer world, yes, we need the ability to specify > > > that the usage of the entire subtree should be compared as a single > > > entity with other cgroups. That is necessar

Re: [PATCH 0/3] introduce memory.oom.group

2018-08-07 Thread David Rientjes
On Mon, 6 Aug 2018, Roman Gushchin wrote: > > In a cgroup-aware oom killer world, yes, we need the ability to specify > > that the usage of the entire subtree should be compared as a single > > entity with other cgroups. That is necessary for user subtrees but may > > not be necessary for top-

Re: [PATCH 0/3] introduce memory.oom.group

2018-08-06 Thread Roman Gushchin
On Mon, Aug 06, 2018 at 02:34:06PM -0700, David Rientjes wrote: > On Wed, 1 Aug 2018, Roman Gushchin wrote: > > > Ok, I think that what we'll do here: > > 1) drop the current cgroup-aware OOM killer implementation from the mm tree > > 2) land memory.oom.group to the mm tree (your ack will be appre

Re: [PATCH 0/3] introduce memory.oom.group

2018-08-06 Thread David Rientjes
On Wed, 1 Aug 2018, Roman Gushchin wrote: > Ok, I think that what we'll do here: > 1) drop the current cgroup-aware OOM killer implementation from the mm tree > 2) land memory.oom.group to the mm tree (your ack will be appreciated) > 3) discuss and, hopefully, agree on memory.oom.policy interface

Re: [PATCH 0/3] introduce memory.oom.group

2018-08-02 Thread Michal Hocko
On Wed 01-08-18 14:51:25, David Rientjes wrote: > On Tue, 31 Jul 2018, Roman Gushchin wrote: > > > > What's the plan with the cgroup aware oom killer? It has been sitting in > > > the -mm tree for ages with no clear path to being merged. > > > > It's because your nack, isn't it? > > Everybody e

Re: [PATCH 0/3] introduce memory.oom.group

2018-08-01 Thread Roman Gushchin
On Wed, Aug 01, 2018 at 02:51:25PM -0700, David Rientjes wrote: > On Tue, 31 Jul 2018, Roman Gushchin wrote: > > > > What's the plan with the cgroup aware oom killer? It has been sitting in > > > the -mm tree for ages with no clear path to being merged. > > > > It's because your nack, isn't it?

Re: [PATCH 0/3] introduce memory.oom.group

2018-08-01 Thread David Rientjes
On Tue, 31 Jul 2018, Roman Gushchin wrote: > > What's the plan with the cgroup aware oom killer? It has been sitting in > > the -mm tree for ages with no clear path to being merged. > > It's because your nack, isn't it? > Everybody else seem to be fine with it. > If they are fine with it, I'm

Re: [PATCH 0/3] introduce memory.oom.group

2018-07-31 Thread Roman Gushchin
On Mon, Jul 30, 2018 at 06:49:31PM -0700, David Rientjes wrote: > On Mon, 30 Jul 2018, Roman Gushchin wrote: > > > This is a tiny implementation of cgroup-aware OOM killer, > > which adds an ability to kill a cgroup as a single unit > > and so guarantee the integrity of the workload. > > > > Alth

Re: [PATCH 0/3] introduce memory.oom.group

2018-07-31 Thread Johannes Weiner
On Mon, Jul 30, 2018 at 06:49:31PM -0700, David Rientjes wrote: > On Mon, 30 Jul 2018, Roman Gushchin wrote: > > > This is a tiny implementation of cgroup-aware OOM killer, > > which adds an ability to kill a cgroup as a single unit > > and so guarantee the integrity of the workload. > > > > Alth

Re: [PATCH 0/3] introduce memory.oom.group

2018-07-30 Thread David Rientjes
On Mon, 30 Jul 2018, Roman Gushchin wrote: > This is a tiny implementation of cgroup-aware OOM killer, > which adds an ability to kill a cgroup as a single unit > and so guarantee the integrity of the workload. > > Although it has only a limited functionality in comparison > to what now resides i

[PATCH 0/3] introduce memory.oom.group

2018-07-30 Thread Roman Gushchin
This is a tiny implementation of cgroup-aware OOM killer, which adds an ability to kill a cgroup as a single unit and so guarantee the integrity of the workload. Although it has only a limited functionality in comparison to what now resides in the mm tree (it doesn't change the victim task selecti