Re: [PATCH 0/3] perf jvmti: Various fixes to JVMTI agent

2020-05-15 Thread Nick Gasson
On 05/15/20 06:41 am, Ian Rogers wrote: > > If you are looking at this code I believe there is a bug in that the > loop handling jvmtiCompiledMethodLoadInlineRecord is writing out the > entire line number table before a pc and not just the line number > table at the pc. This loop in do_get_line_num

Re: [PATCH 0/3] perf jvmti: Various fixes to JVMTI agent

2020-05-14 Thread Ian Rogers
On Thu, May 14, 2020 at 6:23 AM Arnaldo Carvalho de Melo wrote: > > Em Thu, May 14, 2020 at 04:56:07PM +0800, Nick Gasson escreveu: > > On 04/27/20 18:35 pm, Jiri Olsa wrote: > > > > > > adding Stephane to the loop > > Stephane, Ian, can you guys please take a look at this one and provide a > Revi

Re: [PATCH 0/3] perf jvmti: Various fixes to JVMTI agent

2020-05-14 Thread Arnaldo Carvalho de Melo
Em Thu, May 14, 2020 at 04:56:07PM +0800, Nick Gasson escreveu: > On 04/27/20 18:35 pm, Jiri Olsa wrote: > > > > adding Stephane to the loop Stephane, Ian, can you guys please take a look at this one and provide a Reviewed-by or Acked-by? Thanks, - Arnaldo > > jirka > > > >> > >> These three

Re: [PATCH 0/3] perf jvmti: Various fixes to JVMTI agent

2020-05-14 Thread Nick Gasson
On 04/27/20 18:35 pm, Jiri Olsa wrote: > > adding Stephane to the loop > > jirka > >> >> These three patches fix a couple of issues I ran into while using the >> jitdump JVMTI agent to profile the SPECjbb benchmark. >> Hi, any feedback on these patches? Thanks, Nick >> >> >> Nick Gasson (3):