Re: [PATCH 0/4] Add support for XMM fast hypercalls

2021-04-09 Thread Siddharth Chandrasekaran
On Fri, Apr 09, 2021 at 09:42:41AM +0200, Vitaly Kuznetsov wrote: > Siddharth Chandrasekaran writes: > > On Thu, Apr 08, 2021 at 04:30:18PM +, Wei Liu wrote: > >> On Thu, Apr 08, 2021 at 05:54:43PM +0200, Siddharth Chandrasekaran wrote: > >> > On Thu, Apr 08, 2021 at 05:48:19PM +0200, Paolo

Re: [PATCH 0/4] Add support for XMM fast hypercalls

2021-04-09 Thread Vitaly Kuznetsov
Siddharth Chandrasekaran writes: > On Thu, Apr 08, 2021 at 04:30:18PM +, Wei Liu wrote: >> On Thu, Apr 08, 2021 at 05:54:43PM +0200, Siddharth Chandrasekaran wrote: >> > On Thu, Apr 08, 2021 at 05:48:19PM +0200, Paolo Bonzini wrote: >> > > On 08/04/21 17:40, Siddharth Chandrasekaran wrote:

Re: [PATCH 0/4] Add support for XMM fast hypercalls

2021-04-08 Thread Siddharth Chandrasekaran
On Thu, Apr 08, 2021 at 04:30:18PM +, Wei Liu wrote: > On Thu, Apr 08, 2021 at 05:54:43PM +0200, Siddharth Chandrasekaran wrote: > > On Thu, Apr 08, 2021 at 05:48:19PM +0200, Paolo Bonzini wrote: > > > On 08/04/21 17:40, Siddharth Chandrasekaran wrote: > > > > > > > Although the Hyper-v TLFS

Re: [PATCH 0/4] Add support for XMM fast hypercalls

2021-04-08 Thread Wei Liu
On Thu, Apr 08, 2021 at 05:54:43PM +0200, Siddharth Chandrasekaran wrote: > On Thu, Apr 08, 2021 at 05:48:19PM +0200, Paolo Bonzini wrote: > > On 08/04/21 17:40, Siddharth Chandrasekaran wrote: > > > > > > Although the Hyper-v TLFS mentions that a guest cannot use this > > > > > > feature > > > >

Re: [PATCH 0/4] Add support for XMM fast hypercalls

2021-04-08 Thread Siddharth Chandrasekaran
On Thu, Apr 08, 2021 at 03:38:13PM +, Wei Liu wrote: > On Thu, Apr 08, 2021 at 05:30:26PM +0200, Paolo Bonzini wrote: > > On 08/04/21 17:28, Wei Liu wrote: > > > > Although the Hyper-v TLFS mentions that a guest cannot use this feature > > > > unless the hypervisor advertises support for it,

Re: [PATCH 0/4] Add support for XMM fast hypercalls

2021-04-08 Thread Siddharth Chandrasekaran
On Thu, Apr 08, 2021 at 05:48:19PM +0200, Paolo Bonzini wrote: > On 08/04/21 17:40, Siddharth Chandrasekaran wrote: > > > > > Although the Hyper-v TLFS mentions that a guest cannot use this > > > > > feature > > > > > unless the hypervisor advertises support for it, some hypercalls which > > > >

Re: [PATCH 0/4] Add support for XMM fast hypercalls

2021-04-08 Thread Paolo Bonzini
On 08/04/21 17:40, Siddharth Chandrasekaran wrote: Although the Hyper-v TLFS mentions that a guest cannot use this feature unless the hypervisor advertises support for it, some hypercalls which we plan on upstreaming in future uses them anyway. No, please don't do this. Check the feature bit(s)

Re: [PATCH 0/4] Add support for XMM fast hypercalls

2021-04-08 Thread Siddharth Chandrasekaran
On Thu, Apr 08, 2021 at 05:30:26PM +0200, Paolo Bonzini wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you can confirm the sender and know the > content is safe. > > > > On 08/04/21 17:28, Wei Liu wrote: > > > Although

Re: [PATCH 0/4] Add support for XMM fast hypercalls

2021-04-08 Thread Wei Liu
On Thu, Apr 08, 2021 at 05:30:26PM +0200, Paolo Bonzini wrote: > On 08/04/21 17:28, Wei Liu wrote: > > > Although the Hyper-v TLFS mentions that a guest cannot use this feature > > > unless the hypervisor advertises support for it, some hypercalls which > > > we plan on upstreaming in future uses

Re: [PATCH 0/4] Add support for XMM fast hypercalls

2021-04-08 Thread Paolo Bonzini
On 08/04/21 17:28, Wei Liu wrote: Although the Hyper-v TLFS mentions that a guest cannot use this feature unless the hypervisor advertises support for it, some hypercalls which we plan on upstreaming in future uses them anyway. No, please don't do this. Check the feature bit(s) before you

Re: [PATCH 0/4] Add support for XMM fast hypercalls

2021-04-08 Thread Wei Liu
On Wed, Apr 07, 2021 at 11:29:26PM +0200, Siddharth Chandrasekaran wrote: > Hyper-V supports the use of XMM registers to perform fast hypercalls. > This allows guests to take advantage of the improved performance of the > fast hypercall interface even though a hypercall may require more than >

[PATCH 0/4] Add support for XMM fast hypercalls

2021-04-07 Thread Siddharth Chandrasekaran
Hyper-V supports the use of XMM registers to perform fast hypercalls. This allows guests to take advantage of the improved performance of the fast hypercall interface even though a hypercall may require more than (the current maximum of) two general purpose registers. The XMM fast hypercall