Re: [PATCH 0/4] Convert timekeeping core to use printk_deferred (v2)

2014-05-05 Thread John Stultz
On 05/05/2014 11:42 AM, Steven Rostedt wrote: > On Fri, 2 May 2014 16:05:36 -0700 > Andrew Morton wrote: > > >> Would "printk_deferred_once" be more logical than >> "printk_once_deferred"? Think so. It's (((printk(deferred(once))), >> not (((printk(once(deferred))). >> > I agree with the

Re: [PATCH 0/4] Convert timekeeping core to use printk_deferred (v2)

2014-05-05 Thread John Stultz
On 05/02/2014 04:05 PM, Andrew Morton wrote: > On Fri, 2 May 2014 15:09:14 -0700 John Stultz wrote: > >> Recently, Jiri pointed out a potential deadlock when calling printk >> while holding the timekeeping seqlock. >> >> Annoyingly, the seqlock lockdep enablement doesn't catch this, as >> printk

Re: [PATCH 0/4] Convert timekeeping core to use printk_deferred (v2)

2014-05-05 Thread Steven Rostedt
On Fri, 2 May 2014 16:05:36 -0700 Andrew Morton wrote: > Would "printk_deferred_once" be more logical than > "printk_once_deferred"? Think so. It's (((printk(deferred(once))), > not (((printk(once(deferred))). > I agree with the above, but other than that you can add my: Reviewed-by:

Re: [PATCH 0/4] Convert timekeeping core to use printk_deferred (v2)

2014-05-05 Thread Steven Rostedt
On Fri, 2 May 2014 16:05:36 -0700 Andrew Morton wrote: > Would "printk_deferred_once" be more logical than > "printk_once_deferred"? Think so. It's (((printk(deferred(once))), > not (((printk(once(deferred))). Or printk_once_removed()? Or does that only deal with cousins? -- Steve -- To

Re: [PATCH 0/4] Convert timekeeping core to use printk_deferred (v2)

2014-05-05 Thread Steven Rostedt
On Fri, 2 May 2014 16:05:36 -0700 Andrew Morton a...@linux-foundation.org wrote: Would printk_deferred_once be more logical than printk_once_deferred? Think so. It's (((printk(deferred(once))), not (((printk(once(deferred))). Or printk_once_removed()? Or does that only deal with cousins?

Re: [PATCH 0/4] Convert timekeeping core to use printk_deferred (v2)

2014-05-05 Thread Steven Rostedt
On Fri, 2 May 2014 16:05:36 -0700 Andrew Morton a...@linux-foundation.org wrote: Would printk_deferred_once be more logical than printk_once_deferred? Think so. It's (((printk(deferred(once))), not (((printk(once(deferred))). I agree with the above, but other than that you can add my:

Re: [PATCH 0/4] Convert timekeeping core to use printk_deferred (v2)

2014-05-05 Thread John Stultz
On 05/02/2014 04:05 PM, Andrew Morton wrote: On Fri, 2 May 2014 15:09:14 -0700 John Stultz john.stu...@linaro.org wrote: Recently, Jiri pointed out a potential deadlock when calling printk while holding the timekeeping seqlock. Annoyingly, the seqlock lockdep enablement doesn't catch this,

Re: [PATCH 0/4] Convert timekeeping core to use printk_deferred (v2)

2014-05-05 Thread John Stultz
On 05/05/2014 11:42 AM, Steven Rostedt wrote: On Fri, 2 May 2014 16:05:36 -0700 Andrew Morton a...@linux-foundation.org wrote: Would printk_deferred_once be more logical than printk_once_deferred? Think so. It's (((printk(deferred(once))), not (((printk(once(deferred))). I agree with

Re: [PATCH 0/4] Convert timekeeping core to use printk_deferred (v2)

2014-05-02 Thread Andrew Morton
On Fri, 2 May 2014 15:09:14 -0700 John Stultz wrote: > Recently, Jiri pointed out a potential deadlock when calling printk > while holding the timekeeping seqlock. > > Annoyingly, the seqlock lockdep enablement doesn't catch this, as > printk disables lockdep. > > When looking for possible

[PATCH 0/4] Convert timekeeping core to use printk_deferred (v2)

2014-05-02 Thread John Stultz
Recently, Jiri pointed out a potential deadlock when calling printk while holding the timekeeping seqlock. Annoyingly, the seqlock lockdep enablement doesn't catch this, as printk disables lockdep. When looking for possible solutions, one idea was to use a local buffer and defer the printk to

[PATCH 0/4] Convert timekeeping core to use printk_deferred (v2)

2014-05-02 Thread John Stultz
Recently, Jiri pointed out a potential deadlock when calling printk while holding the timekeeping seqlock. Annoyingly, the seqlock lockdep enablement doesn't catch this, as printk disables lockdep. When looking for possible solutions, one idea was to use a local buffer and defer the printk to

Re: [PATCH 0/4] Convert timekeeping core to use printk_deferred (v2)

2014-05-02 Thread Andrew Morton
On Fri, 2 May 2014 15:09:14 -0700 John Stultz john.stu...@linaro.org wrote: Recently, Jiri pointed out a potential deadlock when calling printk while holding the timekeeping seqlock. Annoyingly, the seqlock lockdep enablement doesn't catch this, as printk disables lockdep. When looking