Re: [PATCH 0/4] fujitsu_init() cleanup

On Tue, Feb 28, 2017 at 03:01:52PM +0100, Greg Kroah-Hartman wrote: > On Tue, Feb 28, 2017 at 02:24:40PM +0100, Michał Kępień wrote: > > > On Tue, Feb 28, 2017 at 09:33:28AM +0100, Micha?? K??pie?? wrote: > > > > GregKH wrote: > > > > > On Mon, Feb 27, 2017 at 10:17:55PM -0800, Darren Hart wrote:

Re: [PATCH 0/4] fujitsu_init() cleanup

On Tue, Feb 28, 2017 at 03:01:52PM +0100, Greg Kroah-Hartman wrote: > On Tue, Feb 28, 2017 at 02:24:40PM +0100, Michał Kępień wrote: > > > On Tue, Feb 28, 2017 at 09:33:28AM +0100, Micha?? K??pie?? wrote: > > > > GregKH wrote: > > > > > On Mon, Feb 27, 2017 at 10:17:55PM -0800, Darren Hart wrote:

Re: [PATCH 0/4] fujitsu_init() cleanup

On Tue, Feb 28, 2017 at 4:01 PM, Greg Kroah-Hartman wrote: > On Tue, Feb 28, 2017 at 02:24:40PM +0100, Michał Kępień wrote: >> > On Tue, Feb 28, 2017 at 09:33:28AM +0100, Micha?? K??pie?? wrote: >> > > GregKH wrote: >> Greg objected to that, arguing that there might

Re: [PATCH 0/4] fujitsu_init() cleanup

On Tue, Feb 28, 2017 at 4:01 PM, Greg Kroah-Hartman wrote: > On Tue, Feb 28, 2017 at 02:24:40PM +0100, Michał Kępień wrote: >> > On Tue, Feb 28, 2017 at 09:33:28AM +0100, Micha?? K??pie?? wrote: >> > > GregKH wrote: >> Greg objected to that, arguing that there might be userspace >> applications

Re: [PATCH 0/4] fujitsu_init() cleanup

On Tue, Feb 28, 2017 at 02:24:40PM +0100, Michał Kępień wrote: > > On Tue, Feb 28, 2017 at 09:33:28AM +0100, Micha?? K??pie?? wrote: > > > GregKH wrote: > > > > On Mon, Feb 27, 2017 at 10:17:55PM -0800, Darren Hart wrote: > > > > > GregKH - Can you please confirm the above? Moving an attribute is

Re: [PATCH 0/4] fujitsu_init() cleanup

On Tue, Feb 28, 2017 at 02:24:40PM +0100, Michał Kępień wrote: > > On Tue, Feb 28, 2017 at 09:33:28AM +0100, Micha?? K??pie?? wrote: > > > GregKH wrote: > > > > On Mon, Feb 27, 2017 at 10:17:55PM -0800, Darren Hart wrote: > > > > > GregKH - Can you please confirm the above? Moving an attribute is

Re: [PATCH 0/4] fujitsu_init() cleanup

> On Tue, Feb 28, 2017 at 09:33:28AM +0100, Micha?? K??pie?? wrote: > > GregKH wrote: > > > On Mon, Feb 27, 2017 at 10:17:55PM -0800, Darren Hart wrote: > > > > GregKH - Can you please confirm the above? Moving an attribute is > > > > different than > > > > the format and contents, which is what

Re: [PATCH 0/4] fujitsu_init() cleanup

> On Tue, Feb 28, 2017 at 09:33:28AM +0100, Micha?? K??pie?? wrote: > > GregKH wrote: > > > On Mon, Feb 27, 2017 at 10:17:55PM -0800, Darren Hart wrote: > > > > GregKH - Can you please confirm the above? Moving an attribute is > > > > different than > > > > the format and contents, which is what

Re: [PATCH 0/4] fujitsu_init() cleanup

On Tue, Feb 28, 2017 at 09:44:26PM +1030, Jonathan Woithe wrote: > On Tue, Feb 28, 2017 at 09:07:04AM +0100, Greg Kroah-Hartman wrote: > > On Mon, Feb 27, 2017 at 10:17:55PM -0800, Darren Hart wrote: > > > > > > > > The problem I have with this driver is that it is generally > > > > > > > >

Re: [PATCH 0/4] fujitsu_init() cleanup

On Tue, Feb 28, 2017 at 09:44:26PM +1030, Jonathan Woithe wrote: > On Tue, Feb 28, 2017 at 09:07:04AM +0100, Greg Kroah-Hartman wrote: > > On Mon, Feb 27, 2017 at 10:17:55PM -0800, Darren Hart wrote: > > > > > > > > The problem I have with this driver is that it is generally > > > > > > > >

Re: [PATCH 0/4] fujitsu_init() cleanup

On Tue, Feb 28, 2017 at 09:33:28AM +0100, Micha?? K??pie?? wrote: > GregKH wrote: > > On Mon, Feb 27, 2017 at 10:17:55PM -0800, Darren Hart wrote: > > > GregKH - Can you please confirm the above? Moving an attribute is > > > different than > > > the format and contents, which is what I explicitly

Re: [PATCH 0/4] fujitsu_init() cleanup

On Tue, Feb 28, 2017 at 09:33:28AM +0100, Micha?? K??pie?? wrote: > GregKH wrote: > > On Mon, Feb 27, 2017 at 10:17:55PM -0800, Darren Hart wrote: > > > GregKH - Can you please confirm the above? Moving an attribute is > > > different than > > > the format and contents, which is what I explicitly

Re: [PATCH 0/4] fujitsu_init() cleanup

On Tue, Feb 28, 2017 at 09:07:04AM +0100, Greg Kroah-Hartman wrote: > On Mon, Feb 27, 2017 at 10:17:55PM -0800, Darren Hart wrote: > > > > > > > The problem I have with this driver is that it is generally > > > > > > > oblivious to > > > > > > > the user's chosen backlight provider. It was

Re: [PATCH 0/4] fujitsu_init() cleanup

On Tue, Feb 28, 2017 at 09:07:04AM +0100, Greg Kroah-Hartman wrote: > On Mon, Feb 27, 2017 at 10:17:55PM -0800, Darren Hart wrote: > > > > > > > The problem I have with this driver is that it is generally > > > > > > > oblivious to > > > > > > > the user's chosen backlight provider. It was

Re: [PATCH 0/4] fujitsu_init() cleanup

> On Mon, Feb 27, 2017 at 10:17:55PM -0800, Darren Hart wrote: > > Greg, question for you below, see "GregKH"... > > > > On Mon, Feb 27, 2017 at 08:19:09AM +0100, Michał Kępień wrote: > > > > Darren, Andy, > > > > > > > > Please drop this patch series for now. I will send a rebased v2 after a >

Re: [PATCH 0/4] fujitsu_init() cleanup

> On Mon, Feb 27, 2017 at 10:17:55PM -0800, Darren Hart wrote: > > Greg, question for you below, see "GregKH"... > > > > On Mon, Feb 27, 2017 at 08:19:09AM +0100, Michał Kępień wrote: > > > > Darren, Andy, > > > > > > > > Please drop this patch series for now. I will send a rebased v2 after a >

Re: [PATCH 0/4] fujitsu_init() cleanup

Greg, question for you below, see "GregKH"... On Mon, Feb 27, 2017 at 08:19:09AM +0100, Michał Kępień wrote: > > Darren, Andy, > > > > Please drop this patch series for now. I will send a rebased v2 after a > > long overdue patch series from Alan Jenkins gets applied in a reworked > > form. > >

Re: [PATCH 0/4] fujitsu_init() cleanup

Greg, question for you below, see "GregKH"... On Mon, Feb 27, 2017 at 08:19:09AM +0100, Michał Kępień wrote: > > Darren, Andy, > > > > Please drop this patch series for now. I will send a rebased v2 after a > > long overdue patch series from Alan Jenkins gets applied in a reworked > > form. > >

Re: [PATCH 0/4] fujitsu_init() cleanup

On Mon, Feb 27, 2017 at 10:17:55PM -0800, Darren Hart wrote: > Greg, question for you below, see "GregKH"... > > On Mon, Feb 27, 2017 at 08:19:09AM +0100, Michał Kępień wrote: > > > Darren, Andy, > > > > > > Please drop this patch series for now. I will send a rebased v2 after a > > > long

Re: [PATCH 0/4] fujitsu_init() cleanup

On Mon, Feb 27, 2017 at 10:17:55PM -0800, Darren Hart wrote: > Greg, question for you below, see "GregKH"... > > On Mon, Feb 27, 2017 at 08:19:09AM +0100, Michał Kępień wrote: > > > Darren, Andy, > > > > > > Please drop this patch series for now. I will send a rebased v2 after a > > > long

Re: [PATCH 0/4] fujitsu_init() cleanup

> Darren, Andy, > > Please drop this patch series for now. I will send a rebased v2 after a > long overdue patch series from Alan Jenkins gets applied in a reworked > form. > > However, your input is still essential for determining the future shape > of fujitsu-laptop. I quoted the essential

Re: [PATCH 0/4] fujitsu_init() cleanup

> Darren, Andy, > > Please drop this patch series for now. I will send a rebased v2 after a > long overdue patch series from Alan Jenkins gets applied in a reworked > form. > > However, your input is still essential for determining the future shape > of fujitsu-laptop. I quoted the essential

Re: [PATCH 0/4] fujitsu_init() cleanup

On Sat, Feb 4, 2017 at 8:21 AM, Michał Kępień wrote: >> On Fri, Feb 03, 2017 at 04:13:40PM +0200, Andy Shevchenko wrote: >> > On Fri, Feb 3, 2017 at 4:06 PM, Michał Kępień wrote: >> > > Darren, Andy, >> > > >> > > Please drop this patch series for now. I

Re: [PATCH 0/4] fujitsu_init() cleanup

On Sat, Feb 4, 2017 at 8:21 AM, Michał Kępień wrote: >> On Fri, Feb 03, 2017 at 04:13:40PM +0200, Andy Shevchenko wrote: >> > On Fri, Feb 3, 2017 at 4:06 PM, Michał Kępień wrote: >> > > Darren, Andy, >> > > >> > > Please drop this patch series for now. I will send a rebased v2 after a >> > >

Re: [PATCH 0/4] fujitsu_init() cleanup

> On Fri, Feb 03, 2017 at 04:13:40PM +0200, Andy Shevchenko wrote: > > On Fri, Feb 3, 2017 at 4:06 PM, Michał Kępień wrote: > > > Darren, Andy, > > > > > > Please drop this patch series for now. I will send a rebased v2 after a > > > long overdue patch series from Alan Jenkins

Re: [PATCH 0/4] fujitsu_init() cleanup

> On Fri, Feb 03, 2017 at 04:13:40PM +0200, Andy Shevchenko wrote: > > On Fri, Feb 3, 2017 at 4:06 PM, Michał Kępień wrote: > > > Darren, Andy, > > > > > > Please drop this patch series for now. I will send a rebased v2 after a > > > long overdue patch series from Alan Jenkins gets applied in a

Re: [PATCH 0/4] fujitsu_init() cleanup

On Fri, Feb 03, 2017 at 04:13:40PM +0200, Andy Shevchenko wrote: > On Fri, Feb 3, 2017 at 4:06 PM, Michał Kępień wrote: > > Darren, Andy, > > > > Please drop this patch series for now. I will send a rebased v2 after a > > long overdue patch series from Alan Jenkins gets

Re: [PATCH 0/4] fujitsu_init() cleanup

On Fri, Feb 03, 2017 at 04:13:40PM +0200, Andy Shevchenko wrote: > On Fri, Feb 3, 2017 at 4:06 PM, Michał Kępień wrote: > > Darren, Andy, > > > > Please drop this patch series for now. I will send a rebased v2 after a > > long overdue patch series from Alan Jenkins gets applied in a reworked > >

Re: [PATCH 0/4] fujitsu_init() cleanup

On Fri, Feb 3, 2017 at 4:06 PM, Michał Kępień wrote: > Darren, Andy, > > Please drop this patch series for now. I will send a rebased v2 after a > long overdue patch series from Alan Jenkins gets applied in a reworked > form. Noted. Just for you information. Our repo now

Re: [PATCH 0/4] fujitsu_init() cleanup

On Fri, Feb 3, 2017 at 4:06 PM, Michał Kępień wrote: > Darren, Andy, > > Please drop this patch series for now. I will send a rebased v2 after a > long overdue patch series from Alan Jenkins gets applied in a reworked > form. Noted. Just for you information. Our repo now consists three

Re: [PATCH 0/4] fujitsu_init() cleanup

Darren, Andy, Please drop this patch series for now. I will send a rebased v2 after a long overdue patch series from Alan Jenkins gets applied in a reworked form. However, your input is still essential for determining the future shape of fujitsu-laptop. I quoted the essential parts of my

Re: [PATCH 0/4] fujitsu_init() cleanup

Darren, Andy, Please drop this patch series for now. I will send a rebased v2 after a long overdue patch series from Alan Jenkins gets applied in a reworked form. However, your input is still essential for determining the future shape of fujitsu-laptop. I quoted the essential parts of my

Re: [PATCH 0/4] fujitsu_init() cleanup

On Fri, Jan 13, 2017 at 02:19:15PM +0100, Micha?? K??pie?? wrote: > > It might be worth glancing through these because the resulting renames in > > particular definitely improved the clarity of the driver: > > > > Date: Thu, 17 Sep 2009 > > From: Alan Jenkins > > Subject: [PATCH 1/4]

Re: [PATCH 0/4] fujitsu_init() cleanup

On Fri, Jan 13, 2017 at 02:19:15PM +0100, Micha?? K??pie?? wrote: > > It might be worth glancing through these because the resulting renames in > > particular definitely improved the clarity of the driver: > > > > Date: Thu, 17 Sep 2009 > > From: Alan Jenkins > > Subject: [PATCH 1/4]

Re: [PATCH 0/4] fujitsu_init() cleanup

> On Fri, Jan 13, 2017 at 12:02:36PM +0100, Micha?? K??pie?? wrote: > > These patches should make fujitsu_init() a bit more palatable. I > > intentionally stopped after four patches, because they should do no harm > > and the next steps require some discussion. > > I will review these as soon as

Re: [PATCH 0/4] fujitsu_init() cleanup

> On Fri, Jan 13, 2017 at 12:02:36PM +0100, Micha?? K??pie?? wrote: > > These patches should make fujitsu_init() a bit more palatable. I > > intentionally stopped after four patches, because they should do no harm > > and the next steps require some discussion. > > I will review these as soon as

Re: [PATCH 0/4] fujitsu_init() cleanup

On Fri, Jan 13, 2017 at 12:02:36PM +0100, Micha?? K??pie?? wrote: > These patches should make fujitsu_init() a bit more palatable. I > intentionally stopped after four patches, because they should do no harm > and the next steps require some discussion. I will review these as soon as I can,

Re: [PATCH 0/4] fujitsu_init() cleanup

On Fri, Jan 13, 2017 at 12:02:36PM +0100, Micha?? K??pie?? wrote: > These patches should make fujitsu_init() a bit more palatable. I > intentionally stopped after four patches, because they should do no harm > and the next steps require some discussion. I will review these as soon as I can,

[PATCH 0/4] fujitsu_init() cleanup

These patches should make fujitsu_init() a bit more palatable. I intentionally stopped after four patches, because they should do no harm and the next steps require some discussion. The problem I have with this driver is that it is generally oblivious to the user's chosen backlight provider. It

[PATCH 0/4] fujitsu_init() cleanup

These patches should make fujitsu_init() a bit more palatable. I intentionally stopped after four patches, because they should do no harm and the next steps require some discussion. The problem I have with this driver is that it is generally oblivious to the user's chosen backlight provider. It