Re: [E1000-devel] [PATCH 0/4] i40e: Neatening and object size reductions

2013-09-03 Thread Joe Perches
On Wed, 2013-09-04 at 01:00 +000, Nelson, Shannon wrote: > we hadn't noticed the new experimental "--fix" option before. There > are a lot of good suggestions there, but obviously it needs a lot of > reading and tweaking before it can be used. Yes, I think --fix works best on patches. When you u

RE: [E1000-devel] [PATCH 0/4] i40e: Neatening and object size reductions

2013-09-03 Thread Nelson, Shannon
> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: Tuesday, September 03, 2013 6:31 PM > > On Wed, 2013-09-04 at 01:00 +, Nelson, Shannon wrote: > > Hi Shannon. > > > > -Original Message- > From: Joe Perches > > [mailto:j...@perches.com] > Sent: Friday

Re: [E1000-devel] [PATCH 0/4] i40e: Neatening and object size reductions

2013-09-03 Thread Joe Perches
On Wed, 2013-09-04 at 01:00 +, Nelson, Shannon wrote: Hi Shannon. > > -Original Message- > From: Joe Perches > [mailto:j...@perches.com] > Sent: Friday, August 30, 2013 4:06 PM > > > Just some potential cleanings... > > > i40e: Whitespace cleaning > > Hmmm, we hadn't noticed the n

RE: [E1000-devel] [PATCH 0/4] i40e: Neatening and object size reductions

2013-09-03 Thread Nelson, Shannon
> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: Friday, August 30, 2013 4:06 PM > > Just some potential cleanings... > i40e: Whitespace cleaning Hmmm, we hadn't noticed the new experimental "--fix" option before. There are a lot of good suggestions there, b

Re: [PATCH 0/4] i40e: Neatening and object size reductions

2013-08-30 Thread Jeff Kirsher
On Fri, 2013-08-30 at 16:06 -0700, Joe Perches wrote: > Just some potential cleanings... > > Joe Perches (4): > i40e: Whitespace cleaning > i40e: Add and use pf_ > i40e: pf_ remove "%s: " ... __func__ > i40e: Convert pf_ macros to functions Thanks Joe, I will add these to my queue. sign

[PATCH 0/4] i40e: Neatening and object size reductions

2013-08-30 Thread Joe Perches
Just some potential cleanings... Joe Perches (4): i40e: Whitespace cleaning i40e: Add and use pf_ i40e: pf_ remove "%s: " ... __func__ i40e: Convert pf_ macros to functions drivers/net/ethernet/intel/i40e/i40e.h | 149 +-- drivers/net/ethernet/intel/i40e/i40e_common.c |