Re: [PATCH 0/4] iomap: fix multiple consistency issues, interface cleanup

2019-02-18 Thread Hugo Lefeuvre
Hi, > Nice cleanup! Applied to my asm-generic tree now. Thanks! > I notice that you did not add a 'volatile' qualifier in addition to 'const'. > Is that something you considered doing? I think the traditional > readl/writel style accessors have them partly for historic reasons, > and partly to

Re: [PATCH 0/4] iomap: fix multiple consistency issues, interface cleanup

2019-02-18 Thread Arnd Bergmann
On Mon, Feb 18, 2019 at 11:53 AM Hugo Lefeuvre wrote: > > Hi, > > This patch cleans up the iomap interface. > > The first patch makes the include/asm-generic/iomap.h header compliant > with the kernel style guidelines by adding missing function args > identifier names. > > The second and fourth

[PATCH 0/4] iomap: fix multiple consistency issues, interface cleanup

2019-02-18 Thread Hugo Lefeuvre
Hi, This patch cleans up the iomap interface. The first patch makes the include/asm-generic/iomap.h header compliant with the kernel style guidelines by adding missing function args identifier names. The second and fourth patches address multiple compilation warnings due to missing const