Re: [PATCH 0/5] fallocate system call

2007-05-07 Thread David Chinner
On Thu, May 03, 2007 at 01:22:48PM +0200, Miquel van Smoorenburg wrote: > In article <[EMAIL PROTECTED]> you write: > >On May 02, 2007 18:23 +0530, Amit K. Arora wrote: > >> On Sun, Apr 29, 2007 at 10:25:59PM -0700, Chris Wedgwood wrote: > >> > On Mon, Apr 30, 2007 at 10:47:02AM +1000, David

Re: [PATCH 0/5] fallocate system call

2007-05-07 Thread David Chinner
On Thu, May 03, 2007 at 01:22:48PM +0200, Miquel van Smoorenburg wrote: In article [EMAIL PROTECTED] you write: On May 02, 2007 18:23 +0530, Amit K. Arora wrote: On Sun, Apr 29, 2007 at 10:25:59PM -0700, Chris Wedgwood wrote: On Mon, Apr 30, 2007 at 10:47:02AM +1000, David Chinner wrote:

Re: [PATCH 0/5] fallocate system call

2007-05-03 Thread Miquel van Smoorenburg
In article <[EMAIL PROTECTED]> you write: >On May 02, 2007 18:23 +0530, Amit K. Arora wrote: >> On Sun, Apr 29, 2007 at 10:25:59PM -0700, Chris Wedgwood wrote: >> > On Mon, Apr 30, 2007 at 10:47:02AM +1000, David Chinner wrote: >> > >> > > For FA_ALLOCATE, it's supposed to change the file size

Re: [PATCH 0/5] fallocate system call

2007-05-03 Thread Andreas Dilger
On May 02, 2007 18:23 +0530, Amit K. Arora wrote: > On Sun, Apr 29, 2007 at 10:25:59PM -0700, Chris Wedgwood wrote: > > On Mon, Apr 30, 2007 at 10:47:02AM +1000, David Chinner wrote: > > > > > For FA_ALLOCATE, it's supposed to change the file size if we > > > allocate past EOF, right? > > > > I

Re: [PATCH 0/5] fallocate system call

2007-05-03 Thread Andreas Dilger
On May 02, 2007 18:23 +0530, Amit K. Arora wrote: On Sun, Apr 29, 2007 at 10:25:59PM -0700, Chris Wedgwood wrote: On Mon, Apr 30, 2007 at 10:47:02AM +1000, David Chinner wrote: For FA_ALLOCATE, it's supposed to change the file size if we allocate past EOF, right? I would argue

Re: [PATCH 0/5] fallocate system call

2007-05-03 Thread Miquel van Smoorenburg
In article [EMAIL PROTECTED] you write: On May 02, 2007 18:23 +0530, Amit K. Arora wrote: On Sun, Apr 29, 2007 at 10:25:59PM -0700, Chris Wedgwood wrote: On Mon, Apr 30, 2007 at 10:47:02AM +1000, David Chinner wrote: For FA_ALLOCATE, it's supposed to change the file size if we

Re: [PATCH 0/5] fallocate system call

2007-05-02 Thread Amit K. Arora
On Sun, Apr 29, 2007 at 10:25:59PM -0700, Chris Wedgwood wrote: > On Mon, Apr 30, 2007 at 10:47:02AM +1000, David Chinner wrote: > > > For FA_ALLOCATE, it's supposed to change the file size if we > > allocate past EOF, right? > > I would argue no. Use truncate for that. The patch I posted for

Re: [PATCH 0/5] fallocate system call

2007-05-02 Thread Amit K. Arora
On Sun, Apr 29, 2007 at 10:25:59PM -0700, Chris Wedgwood wrote: On Mon, Apr 30, 2007 at 10:47:02AM +1000, David Chinner wrote: For FA_ALLOCATE, it's supposed to change the file size if we allocate past EOF, right? I would argue no. Use truncate for that. The patch I posted for ext4

Re: [PATCH 0/5] fallocate system call

2007-04-30 Thread Chris Wedgwood
On Mon, Apr 30, 2007 at 03:56:32PM +1000, David Chinner wrote: > On Sun, Apr 29, 2007 at 10:25:59PM -0700, Chris Wedgwood wrote: > IIRC, the argument for FA_ALLOCATE changing file size is that > posix_fallocate() is supposed to change the file size. But it's not posix_fallocate; it's something

Re: [PATCH 0/5] fallocate system call

2007-04-30 Thread Chris Wedgwood
On Mon, Apr 30, 2007 at 03:56:32PM +1000, David Chinner wrote: On Sun, Apr 29, 2007 at 10:25:59PM -0700, Chris Wedgwood wrote: IIRC, the argument for FA_ALLOCATE changing file size is that posix_fallocate() is supposed to change the file size. But it's not posix_fallocate; it's something more

Re: [PATCH 0/5] fallocate system call

2007-04-29 Thread David Chinner
On Sun, Apr 29, 2007 at 10:25:59PM -0700, Chris Wedgwood wrote: > On Mon, Apr 30, 2007 at 10:47:02AM +1000, David Chinner wrote: > > > For FA_ALLOCATE, it's supposed to change the file size if we > > allocate past EOF, right? > > I would argue no. Use truncate for that. I'm going from the ext4

Re: [PATCH 0/5] fallocate system call

2007-04-29 Thread Chris Wedgwood
On Mon, Apr 30, 2007 at 10:47:02AM +1000, David Chinner wrote: > For FA_ALLOCATE, it's supposed to change the file size if we > allocate past EOF, right? I would argue no. Use truncate for that. > For FA_DEALLOCATE, does it change the filesize at all? Same as above. > Or does > it just punch

Re: [PATCH 0/5] fallocate system call

2007-04-29 Thread David Chinner
On Thu, Apr 26, 2007 at 11:20:56PM +0530, Amit K. Arora wrote: > Based on the discussion, this new patchset uses following as the > interface for fallocate() system call: > > asmlinkage long sys_fallocate(int fd, int mode, loff_t offset, loff_t len) Ok, so now for the hard questions - what are

Re: [PATCH 0/5] fallocate system call

2007-04-29 Thread David Chinner
On Thu, Apr 26, 2007 at 11:20:56PM +0530, Amit K. Arora wrote: Based on the discussion, this new patchset uses following as the interface for fallocate() system call: asmlinkage long sys_fallocate(int fd, int mode, loff_t offset, loff_t len) Ok, so now for the hard questions - what are the

Re: [PATCH 0/5] fallocate system call

2007-04-29 Thread Chris Wedgwood
On Mon, Apr 30, 2007 at 10:47:02AM +1000, David Chinner wrote: For FA_ALLOCATE, it's supposed to change the file size if we allocate past EOF, right? I would argue no. Use truncate for that. For FA_DEALLOCATE, does it change the filesize at all? Same as above. Or does it just punch a

Re: [PATCH 0/5] fallocate system call

2007-04-29 Thread David Chinner
On Sun, Apr 29, 2007 at 10:25:59PM -0700, Chris Wedgwood wrote: On Mon, Apr 30, 2007 at 10:47:02AM +1000, David Chinner wrote: For FA_ALLOCATE, it's supposed to change the file size if we allocate past EOF, right? I would argue no. Use truncate for that. I'm going from the ext4

Re: [PATCH 0/5] fallocate system call

2007-04-27 Thread Chris Wedgwood
On Fri, Apr 27, 2007 at 07:46:13PM +0200, Heiko Carstens wrote: > If one insists to have fd at first argument, what is wrong with > having u32 arguments only? Well, I was one of those who objected as it seems *UGLY* to me. > It's not that this syscall comes even close to what can be >

Re: [PATCH 0/5] fallocate system call

2007-04-27 Thread Heiko Carstens
On Fri, Apr 27, 2007 at 04:43:28PM +0200, Jörn Engel wrote: > On Fri, 27 April 2007 14:10:03 +0200, Heiko Carstens wrote: > > > > After long discussions where at least two possible implementations > > were suggested that would work on _all_ architectures you chose one > > which doesn't and causes

Re: [PATCH 0/5] fallocate system call

2007-04-27 Thread Jörn Engel
On Fri, 27 April 2007 14:10:03 +0200, Heiko Carstens wrote: > > After long discussions where at least two possible implementations > were suggested that would work on _all_ architectures you chose one > which doesn't and causes extra effort. I believe the long discussion also showed that every

Re: [PATCH 0/5] fallocate system call

2007-04-27 Thread Heiko Carstens
On Thu, Apr 26, 2007 at 11:20:56PM +0530, Amit K. Arora wrote: > Based on the discussion, this new patchset uses following as the > interface for fallocate() system call: > > asmlinkage long sys_fallocate(int fd, int mode, loff_t offset, loff_t len) > > It seems that only s390 architecture has

Re: [PATCH 0/5] fallocate system call

2007-04-27 Thread Heiko Carstens
On Thu, Apr 26, 2007 at 11:20:56PM +0530, Amit K. Arora wrote: Based on the discussion, this new patchset uses following as the interface for fallocate() system call: asmlinkage long sys_fallocate(int fd, int mode, loff_t offset, loff_t len) It seems that only s390 architecture has a

Re: [PATCH 0/5] fallocate system call

2007-04-27 Thread Jörn Engel
On Fri, 27 April 2007 14:10:03 +0200, Heiko Carstens wrote: After long discussions where at least two possible implementations were suggested that would work on _all_ architectures you chose one which doesn't and causes extra effort. I believe the long discussion also showed that every

Re: [PATCH 0/5] fallocate system call

2007-04-27 Thread Heiko Carstens
On Fri, Apr 27, 2007 at 04:43:28PM +0200, Jörn Engel wrote: On Fri, 27 April 2007 14:10:03 +0200, Heiko Carstens wrote: After long discussions where at least two possible implementations were suggested that would work on _all_ architectures you chose one which doesn't and causes extra

Re: [PATCH 0/5] fallocate system call

2007-04-27 Thread Chris Wedgwood
On Fri, Apr 27, 2007 at 07:46:13PM +0200, Heiko Carstens wrote: If one insists to have fd at first argument, what is wrong with having u32 arguments only? Well, I was one of those who objected as it seems *UGLY* to me. It's not that this syscall comes even close to what can be considered

[PATCH 0/5] fallocate system call

2007-04-26 Thread Amit K. Arora
Based on the discussion, this new patchset uses following as the interface for fallocate() system call: asmlinkage long sys_fallocate(int fd, int mode, loff_t offset, loff_t len) It seems that only s390 architecture has a problem with such a layout of arguments in fallocate(). Thus for s390, we

[PATCH 0/5] fallocate system call

2007-04-26 Thread Amit K. Arora
Based on the discussion, this new patchset uses following as the interface for fallocate() system call: asmlinkage long sys_fallocate(int fd, int mode, loff_t offset, loff_t len) It seems that only s390 architecture has a problem with such a layout of arguments in fallocate(). Thus for s390, we