Re: [PATCH 0/5] mm: poison critical mm/ structs

2014-10-09 Thread Sasha Levin
On 10/02/2014 05:23 AM, Hugh Dickins wrote: > I'm glad to hear they've confirmed some vm_area_struct corruption: > any ideas on where that's coming from? Hugh, I think that what we're seeing isn't a corruption of vm_area_struct per-se, but something weirder. I've poisoned every spot where

Re: [PATCH 0/5] mm: poison critical mm/ structs

2014-10-09 Thread Sasha Levin
On 10/02/2014 05:23 AM, Hugh Dickins wrote: I'm glad to hear they've confirmed some vm_area_struct corruption: any ideas on where that's coming from? Hugh, I think that what we're seeing isn't a corruption of vm_area_struct per-se, but something weirder. I've poisoned every spot where

Re: [PATCH 0/5] mm: poison critical mm/ structs

2014-10-08 Thread Sasha Levin
On 10/07/2014 06:16 PM, Dave Hansen wrote: > On 10/02/2014 07:58 AM, Sasha Levin wrote: What does this add on top of slab poisoning? Some checks in some mm places while the object is active, I guess: why not base those on slab poisoning? And add them in as appropriate to the

Re: [PATCH 0/5] mm: poison critical mm/ structs

2014-10-08 Thread Sasha Levin
On 10/07/2014 06:16 PM, Dave Hansen wrote: On 10/02/2014 07:58 AM, Sasha Levin wrote: What does this add on top of slab poisoning? Some checks in some mm places while the object is active, I guess: why not base those on slab poisoning? And add them in as appropriate to the problem at hand,

Re: [PATCH 0/5] mm: poison critical mm/ structs

2014-10-07 Thread Dave Hansen
On 10/02/2014 07:58 AM, Sasha Levin wrote: >> > What does this add on top of slab poisoning? Some checks in some >> > mm places while the object is active, I guess: why not base those >> > on slab poisoning? And add them in as appropriate to the problem >> > at hand, when a problem is seen. >

Re: [PATCH 0/5] mm: poison critical mm/ structs

2014-10-07 Thread Dave Hansen
On 10/02/2014 07:58 AM, Sasha Levin wrote: What does this add on top of slab poisoning? Some checks in some mm places while the object is active, I guess: why not base those on slab poisoning? And add them in as appropriate to the problem at hand, when a problem is seen. The extra

Re: [PATCH 0/5] mm: poison critical mm/ structs

2014-10-02 Thread Dave Jones
On Thu, Oct 02, 2014 at 02:23:08AM -0700, Hugh Dickins wrote: > I think these patches are fine for investigating whatever is the > problem currently afflicting you and mm under trinity; but we all > have our temporary debugging patches, I don't think all deserve > preservation in everyone

Re: [PATCH 0/5] mm: poison critical mm/ structs

2014-10-02 Thread Sasha Levin
On 10/02/2014 05:23 AM, Hugh Dickins wrote: > On Wed, 1 Oct 2014, Sasha Levin wrote: >> On 10/01/2014 05:07 PM, Andrew Morton wrote: >>> On Mon, 29 Sep 2014 21:47:14 -0400 Sasha Levin >>> wrote: >>> Currently we're seeing a few issues which are unexplainable by looking at the

Re: [PATCH 0/5] mm: poison critical mm/ structs

2014-10-02 Thread Hugh Dickins
On Wed, 1 Oct 2014, Sasha Levin wrote: > On 10/01/2014 05:07 PM, Andrew Morton wrote: > > On Mon, 29 Sep 2014 21:47:14 -0400 Sasha Levin > > wrote: > > > >> Currently we're seeing a few issues which are unexplainable by looking at > >> the > >> data we see and are most likely caused by a

Re: [PATCH 0/5] mm: poison critical mm/ structs

2014-10-02 Thread Hugh Dickins
On Wed, 1 Oct 2014, Sasha Levin wrote: On 10/01/2014 05:07 PM, Andrew Morton wrote: On Mon, 29 Sep 2014 21:47:14 -0400 Sasha Levin sasha.le...@oracle.com wrote: Currently we're seeing a few issues which are unexplainable by looking at the data we see and are most likely caused by a

Re: [PATCH 0/5] mm: poison critical mm/ structs

2014-10-02 Thread Sasha Levin
On 10/02/2014 05:23 AM, Hugh Dickins wrote: On Wed, 1 Oct 2014, Sasha Levin wrote: On 10/01/2014 05:07 PM, Andrew Morton wrote: On Mon, 29 Sep 2014 21:47:14 -0400 Sasha Levin sasha.le...@oracle.com wrote: Currently we're seeing a few issues which are unexplainable by looking at the data

Re: [PATCH 0/5] mm: poison critical mm/ structs

2014-10-02 Thread Dave Jones
On Thu, Oct 02, 2014 at 02:23:08AM -0700, Hugh Dickins wrote: I think these patches are fine for investigating whatever is the problem currently afflicting you and mm under trinity; but we all have our temporary debugging patches, I don't think all deserve preservation in everyone else's

Re: [PATCH 0/5] mm: poison critical mm/ structs

2014-10-01 Thread Sasha Levin
On 10/01/2014 05:48 PM, Andrew Morton wrote: > On Wed, 01 Oct 2014 17:39:39 -0400 Sasha Levin wrote: > >>> It looks fairly cheap - I wonder if it should simply fall under >>> CONFIG_DEBUG_VM rather than the new CONFIG_DEBUG_VM_POISON. >> >> Config options are cheap as well :) > > Thing is, lots

Re: [PATCH 0/5] mm: poison critical mm/ structs

2014-10-01 Thread Andrew Morton
On Wed, 01 Oct 2014 17:39:39 -0400 Sasha Levin wrote: > > It looks fairly cheap - I wonder if it should simply fall under > > CONFIG_DEBUG_VM rather than the new CONFIG_DEBUG_VM_POISON. > > Config options are cheap as well :) Thing is, lots of people are enabling CONFIG_DEBUG_VM, but a smaller

Re: [PATCH 0/5] mm: poison critical mm/ structs

2014-10-01 Thread Sasha Levin
On 10/01/2014 05:07 PM, Andrew Morton wrote: > On Mon, 29 Sep 2014 21:47:14 -0400 Sasha Levin wrote: > >> Currently we're seeing a few issues which are unexplainable by looking at the >> data we see and are most likely caused by a memory corruption caused >> elsewhere. >> >> This is wasting time

Re: [PATCH 0/5] mm: poison critical mm/ structs

2014-10-01 Thread Andrew Morton
On Mon, 29 Sep 2014 21:47:14 -0400 Sasha Levin wrote: > Currently we're seeing a few issues which are unexplainable by looking at the > data we see and are most likely caused by a memory corruption caused > elsewhere. > > This is wasting time for folks who are trying to figure out an issue

Re: [PATCH 0/5] mm: poison critical mm/ structs

2014-10-01 Thread Andrew Morton
On Mon, 29 Sep 2014 21:47:14 -0400 Sasha Levin sasha.le...@oracle.com wrote: Currently we're seeing a few issues which are unexplainable by looking at the data we see and are most likely caused by a memory corruption caused elsewhere. This is wasting time for folks who are trying to figure

Re: [PATCH 0/5] mm: poison critical mm/ structs

2014-10-01 Thread Sasha Levin
On 10/01/2014 05:07 PM, Andrew Morton wrote: On Mon, 29 Sep 2014 21:47:14 -0400 Sasha Levin sasha.le...@oracle.com wrote: Currently we're seeing a few issues which are unexplainable by looking at the data we see and are most likely caused by a memory corruption caused elsewhere. This is

Re: [PATCH 0/5] mm: poison critical mm/ structs

2014-10-01 Thread Andrew Morton
On Wed, 01 Oct 2014 17:39:39 -0400 Sasha Levin sasha.le...@oracle.com wrote: It looks fairly cheap - I wonder if it should simply fall under CONFIG_DEBUG_VM rather than the new CONFIG_DEBUG_VM_POISON. Config options are cheap as well :) Thing is, lots of people are enabling

Re: [PATCH 0/5] mm: poison critical mm/ structs

2014-10-01 Thread Sasha Levin
On 10/01/2014 05:48 PM, Andrew Morton wrote: On Wed, 01 Oct 2014 17:39:39 -0400 Sasha Levin sasha.le...@oracle.com wrote: It looks fairly cheap - I wonder if it should simply fall under CONFIG_DEBUG_VM rather than the new CONFIG_DEBUG_VM_POISON. Config options are cheap as well :) Thing

[PATCH 0/5] mm: poison critical mm/ structs

2014-09-29 Thread Sasha Levin
Currently we're seeing a few issues which are unexplainable by looking at the data we see and are most likely caused by a memory corruption caused elsewhere. This is wasting time for folks who are trying to figure out an issue provided a stack trace that can't really point out the real issue.

[PATCH 0/5] mm: poison critical mm/ structs

2014-09-29 Thread Sasha Levin
Currently we're seeing a few issues which are unexplainable by looking at the data we see and are most likely caused by a memory corruption caused elsewhere. This is wasting time for folks who are trying to figure out an issue provided a stack trace that can't really point out the real issue.