Re: [PATCH 0/6] new zram statistics reporting scheme

2015-03-11 Thread Sergey Senozhatsky
On (03/12/15 14:11), Minchan Kim wrote: > I think we don't need CONFIG_ZRAM_OLD_STATS. > For example, for mem_used_max, we could add pr_warn_once in > *mem_used_max_show* but not *mem_used_max_store*. so, old users will see > deprecated message when they try to *read* the vaule old stat while they

Re: [PATCH 0/6] new zram statistics reporting scheme

2015-03-11 Thread Minchan Kim
On Thu, Mar 12, 2015 at 11:16:09AM +0900, Sergey Senozhatsky wrote: > On (03/12/15 10:55), Minchan Kim wrote: > > I really appreciate you enhance stat functions, esp, working with iostat! > > thanks! my pleasure. > > > One thing I want to discuss is sometime we could remove RO fields > > in

Re: [PATCH 0/6] new zram statistics reporting scheme

2015-03-11 Thread Sergey Senozhatsky
On (03/12/15 11:16), Sergey Senozhatsky wrote: > > cat /sys/block/zram/mem_used_max > > cat /sys/block/zram/mm_stat | awk friend > > > > How about changing only writeable, not readable for duplicated stats > > in /sys/block/zram? So, user will have writeable stat to set some > >

Re: [PATCH 0/6] new zram statistics reporting scheme

2015-03-11 Thread Sergey Senozhatsky
On (03/12/15 10:55), Minchan Kim wrote: > I really appreciate you enhance stat functions, esp, working with iostat! thanks! my pleasure. > One thing I want to discuss is sometime we could remove RO fields > in /sys/block/zram/ but we couldn't remove RW fields because > io_stat/mm_stat doesn't

Re: [PATCH 0/6] new zram statistics reporting scheme

2015-03-11 Thread Minchan Kim
Hi Sergey, On Wed, Mar 11, 2015 at 12:08:28AM +0900, Sergey Senozhatsky wrote: > Hello, > > This patch introduces rework to zram stats. We have per-stat sysfs > nodes, and it makes things a bit hard to use in user space: it doesn't > give an immediate stats 'snapshot', it requires user space to

Re: [PATCH 0/6] new zram statistics reporting scheme

2015-03-11 Thread Sergey Senozhatsky
On (03/12/15 10:55), Minchan Kim wrote: I really appreciate you enhance stat functions, esp, working with iostat! thanks! my pleasure. One thing I want to discuss is sometime we could remove RO fields in /sys/block/zram/ but we couldn't remove RW fields because io_stat/mm_stat doesn't have

Re: [PATCH 0/6] new zram statistics reporting scheme

2015-03-11 Thread Sergey Senozhatsky
On (03/12/15 11:16), Sergey Senozhatsky wrote: cat /sys/block/zram/mem_used_max cat /sys/block/zram/mm_stat | awk friend How about changing only writeable, not readable for duplicated stats in /sys/block/zram? So, user will have writeable stat to set some options in

Re: [PATCH 0/6] new zram statistics reporting scheme

2015-03-11 Thread Minchan Kim
On Thu, Mar 12, 2015 at 11:16:09AM +0900, Sergey Senozhatsky wrote: On (03/12/15 10:55), Minchan Kim wrote: I really appreciate you enhance stat functions, esp, working with iostat! thanks! my pleasure. One thing I want to discuss is sometime we could remove RO fields in

Re: [PATCH 0/6] new zram statistics reporting scheme

2015-03-11 Thread Sergey Senozhatsky
On (03/12/15 14:11), Minchan Kim wrote: I think we don't need CONFIG_ZRAM_OLD_STATS. For example, for mem_used_max, we could add pr_warn_once in *mem_used_max_show* but not *mem_used_max_store*. so, old users will see deprecated message when they try to *read* the vaule old stat while they

Re: [PATCH 0/6] new zram statistics reporting scheme

2015-03-11 Thread Minchan Kim
Hi Sergey, On Wed, Mar 11, 2015 at 12:08:28AM +0900, Sergey Senozhatsky wrote: Hello, This patch introduces rework to zram stats. We have per-stat sysfs nodes, and it makes things a bit hard to use in user space: it doesn't give an immediate stats 'snapshot', it requires user space to use

[PATCH 0/6] new zram statistics reporting scheme

2015-03-10 Thread Sergey Senozhatsky
Hello, This patch introduces rework to zram stats. We have per-stat sysfs nodes, and it makes things a bit hard to use in user space: it doesn't give an immediate stats 'snapshot', it requires user space to use more syscals -- open, read, close for every stat file, with appropriate error checks

[PATCH 0/6] new zram statistics reporting scheme

2015-03-10 Thread Sergey Senozhatsky
Hello, This patch introduces rework to zram stats. We have per-stat sysfs nodes, and it makes things a bit hard to use in user space: it doesn't give an immediate stats 'snapshot', it requires user space to use more syscals -- open, read, close for every stat file, with appropriate error checks