Re: [PATCH 0/6] refine and rename slub sysfs

2017-05-25 Thread Michal Hocko
On Wed 24-05-17 23:21:24, Wei Yang wrote: > On Wed, May 24, 2017 at 02:03:18PM +0200, Michal Hocko wrote: > >On Wed 24-05-17 17:54:50, Wei Yang wrote: > >> On Tue, May 23, 2017 at 08:39:11AM +0200, Michal Hocko wrote: > >[...] > >> >Is this worth risking breakage of the userspace which consume

Re: [PATCH 0/6] refine and rename slub sysfs

2017-05-25 Thread Michal Hocko
On Wed 24-05-17 23:21:24, Wei Yang wrote: > On Wed, May 24, 2017 at 02:03:18PM +0200, Michal Hocko wrote: > >On Wed 24-05-17 17:54:50, Wei Yang wrote: > >> On Tue, May 23, 2017 at 08:39:11AM +0200, Michal Hocko wrote: > >[...] > >> >Is this worth risking breakage of the userspace which consume

Re: [PATCH 0/6] refine and rename slub sysfs

2017-05-24 Thread Christoph Lameter
On Wed, 24 May 2017, Wei Yang wrote: > > > >Who is going to use those new entries and for what purpose? Why do we > >want to expose even more details of the slab allocator to the userspace. > >Is the missing information something fundamental that some user space > >cannot work without it?

Re: [PATCH 0/6] refine and rename slub sysfs

2017-05-24 Thread Christoph Lameter
On Wed, 24 May 2017, Wei Yang wrote: > > > >Who is going to use those new entries and for what purpose? Why do we > >want to expose even more details of the slab allocator to the userspace. > >Is the missing information something fundamental that some user space > >cannot work without it?

Re: [PATCH 0/6] refine and rename slub sysfs

2017-05-24 Thread Wei Yang
On Wed, May 24, 2017 at 02:03:18PM +0200, Michal Hocko wrote: >On Wed 24-05-17 17:54:50, Wei Yang wrote: >> On Tue, May 23, 2017 at 08:39:11AM +0200, Michal Hocko wrote: >[...] >> >Is this worth risking breakage of the userspace which consume this data >> >now? Do you have any user space code

Re: [PATCH 0/6] refine and rename slub sysfs

2017-05-24 Thread Wei Yang
On Wed, May 24, 2017 at 02:03:18PM +0200, Michal Hocko wrote: >On Wed 24-05-17 17:54:50, Wei Yang wrote: >> On Tue, May 23, 2017 at 08:39:11AM +0200, Michal Hocko wrote: >[...] >> >Is this worth risking breakage of the userspace which consume this data >> >now? Do you have any user space code

Re: [PATCH 0/6] refine and rename slub sysfs

2017-05-24 Thread Michal Hocko
On Wed 24-05-17 17:54:50, Wei Yang wrote: > On Tue, May 23, 2017 at 08:39:11AM +0200, Michal Hocko wrote: [...] > >Is this worth risking breakage of the userspace which consume this data > >now? Do you have any user space code which will greatly benefit from the > >new data and which couldn't do

Re: [PATCH 0/6] refine and rename slub sysfs

2017-05-24 Thread Michal Hocko
On Wed 24-05-17 17:54:50, Wei Yang wrote: > On Tue, May 23, 2017 at 08:39:11AM +0200, Michal Hocko wrote: [...] > >Is this worth risking breakage of the userspace which consume this data > >now? Do you have any user space code which will greatly benefit from the > >new data and which couldn't do

Re: [PATCH 0/6] refine and rename slub sysfs

2017-05-24 Thread Wei Yang
On Tue, May 23, 2017 at 08:39:11AM +0200, Michal Hocko wrote: >On Tue 23-05-17 11:27:05, Wei Yang wrote: >> On Thu, May 18, 2017 at 11:06:37AM +0200, Michal Hocko wrote: >> >On Wed 17-05-17 22:11:40, Wei Yang wrote: >> >> This patch serial could be divided into two parts. >> >> >> >> First three

Re: [PATCH 0/6] refine and rename slub sysfs

2017-05-24 Thread Wei Yang
On Tue, May 23, 2017 at 08:39:11AM +0200, Michal Hocko wrote: >On Tue 23-05-17 11:27:05, Wei Yang wrote: >> On Thu, May 18, 2017 at 11:06:37AM +0200, Michal Hocko wrote: >> >On Wed 17-05-17 22:11:40, Wei Yang wrote: >> >> This patch serial could be divided into two parts. >> >> >> >> First three

Re: [PATCH 0/6] refine and rename slub sysfs

2017-05-23 Thread Christoph Lameter
On Tue, 23 May 2017, Michal Hocko wrote: > > >_Why_ do we need all this? > > > > To have a clear statistics for each slab level. > > Is this worth risking breakage of the userspace which consume this data > now? Do you have any user space code which will greatly benefit from the > new data and

Re: [PATCH 0/6] refine and rename slub sysfs

2017-05-23 Thread Christoph Lameter
On Tue, 23 May 2017, Michal Hocko wrote: > > >_Why_ do we need all this? > > > > To have a clear statistics for each slab level. > > Is this worth risking breakage of the userspace which consume this data > now? Do you have any user space code which will greatly benefit from the > new data and

Re: [PATCH 0/6] refine and rename slub sysfs

2017-05-23 Thread Michal Hocko
On Tue 23-05-17 11:27:05, Wei Yang wrote: > On Thu, May 18, 2017 at 11:06:37AM +0200, Michal Hocko wrote: > >On Wed 17-05-17 22:11:40, Wei Yang wrote: > >> This patch serial could be divided into two parts. > >> > >> First three patches refine and adds slab sysfs. > >> Second three patches rename

Re: [PATCH 0/6] refine and rename slub sysfs

2017-05-23 Thread Michal Hocko
On Tue 23-05-17 11:27:05, Wei Yang wrote: > On Thu, May 18, 2017 at 11:06:37AM +0200, Michal Hocko wrote: > >On Wed 17-05-17 22:11:40, Wei Yang wrote: > >> This patch serial could be divided into two parts. > >> > >> First three patches refine and adds slab sysfs. > >> Second three patches rename

Re: [PATCH 0/6] refine and rename slub sysfs

2017-05-22 Thread Wei Yang
On Thu, May 18, 2017 at 11:06:37AM +0200, Michal Hocko wrote: >On Wed 17-05-17 22:11:40, Wei Yang wrote: >> This patch serial could be divided into two parts. >> >> First three patches refine and adds slab sysfs. >> Second three patches rename slab sysfs. >> >> 1. Refine slab sysfs >> >> There

Re: [PATCH 0/6] refine and rename slub sysfs

2017-05-22 Thread Wei Yang
On Thu, May 18, 2017 at 11:06:37AM +0200, Michal Hocko wrote: >On Wed 17-05-17 22:11:40, Wei Yang wrote: >> This patch serial could be divided into two parts. >> >> First three patches refine and adds slab sysfs. >> Second three patches rename slab sysfs. >> >> 1. Refine slab sysfs >> >> There

Re: [PATCH 0/6] refine and rename slub sysfs

2017-05-18 Thread Michal Hocko
On Wed 17-05-17 22:11:40, Wei Yang wrote: > This patch serial could be divided into two parts. > > First three patches refine and adds slab sysfs. > Second three patches rename slab sysfs. > > 1. Refine slab sysfs > > There are four level slabs: > > CPU > CPU_PARTIAL > PARTIAL >

Re: [PATCH 0/6] refine and rename slub sysfs

2017-05-18 Thread Michal Hocko
On Wed 17-05-17 22:11:40, Wei Yang wrote: > This patch serial could be divided into two parts. > > First three patches refine and adds slab sysfs. > Second three patches rename slab sysfs. > > 1. Refine slab sysfs > > There are four level slabs: > > CPU > CPU_PARTIAL > PARTIAL >

Re: [PATCH 0/6] refine and rename slub sysfs

2017-05-17 Thread Christoph Lameter
On Wed, 17 May 2017, Wei Yang wrote: > This patch serial could be divided into two parts. > > First three patches refine and adds slab sysfs. > Second three patches rename slab sysfs. These changes will break the slabinfo tool in linux/tools/vm/slabinfo.c. Please update it as well. > 1. Refine

Re: [PATCH 0/6] refine and rename slub sysfs

2017-05-17 Thread Christoph Lameter
On Wed, 17 May 2017, Wei Yang wrote: > This patch serial could be divided into two parts. > > First three patches refine and adds slab sysfs. > Second three patches rename slab sysfs. These changes will break the slabinfo tool in linux/tools/vm/slabinfo.c. Please update it as well. > 1. Refine

[PATCH 0/6] refine and rename slub sysfs

2017-05-17 Thread Wei Yang
This patch serial could be divided into two parts. First three patches refine and adds slab sysfs. Second three patches rename slab sysfs. 1. Refine slab sysfs There are four level slabs: CPU CPU_PARTIAL PARTIAL FULL And in sysfs, it use show_slab_objects() and

[PATCH 0/6] refine and rename slub sysfs

2017-05-17 Thread Wei Yang
This patch serial could be divided into two parts. First three patches refine and adds slab sysfs. Second three patches rename slab sysfs. 1. Refine slab sysfs There are four level slabs: CPU CPU_PARTIAL PARTIAL FULL And in sysfs, it use show_slab_objects() and