Re: [PATCH 0/7] HID: picoLCD updates

2012-08-19 Thread Alan Stern
On Sun, 19 Aug 2012, Bruno Prémont wrote: > > I don't know bout hid_hw_close(). Certainly no more reports should be > > submitted following usbhid_stop(). > > Ok, I did just that, prevent new calls to usbhid_submit_report(), after > calling hid_hw_close(), fixed one bug in my code that triggers

Re: [PATCH 0/7] HID: picoLCD updates

2012-08-19 Thread Bruno Prémont
On Sat, 18 August 2012 Alan Stern wrote: > On Sat, 18 Aug 2012, Bruno Prémont wrote: > > > One thing I just though about, how does usbhid handle the calls to > > usbhid_submit_report() when hid_hw_stop()/hid_hw_close() have already > > been called? > > Looks like they aren't synchronized at all.

Re: [PATCH 0/7] HID: picoLCD updates

2012-08-18 Thread Alan Stern
On Sat, 18 Aug 2012, Bruno Prémont wrote: > One thing I just though about, how does usbhid handle the calls to > usbhid_submit_report() when hid_hw_stop()/hid_hw_close() have already > been called? Looks like they aren't synchronized at all. That's a bug. usbhid_submit_report() should check th

Re: [PATCH 0/7] HID: picoLCD updates

2012-08-18 Thread Bruno Prémont
On Sat, 18 August 2012 Bruno Prémont wrote: > One thing I just though about, how does usbhid handle the calls to > usbhid_submit_report() when hid_hw_stop()/hid_hw_close() have already > been called? > I will attempt to see if it makes a difference to shortcut my > usbhid_submit_report() calls fro

Re: [PATCH 0/7] HID: picoLCD updates

2012-08-18 Thread Bruno Prémont
On Sat, 18 August 2012 Alan Stern wrote: > On Sat, 18 Aug 2012, Bruno Prémont wrote: > > On Thu, 16 August 2012 Jiri Kosina wrote: > > > On Thu, 16 Aug 2012, Bruno Prémont wrote: > > > > > > > > I don't really understand this explanation. Once usb_kill_urb() > > > > > returns, > > > > > the UR

Re: [PATCH 0/7] HID: picoLCD updates

2012-08-18 Thread Alan Stern
On Sat, 18 Aug 2012, Bruno Prémont wrote: > Hi Jiri, > > [CCing Alan Stern] > > On Thu, 16 August 2012 Jiri Kosina wrote: > > On Thu, 16 Aug 2012, Bruno Prémont wrote: > > > > > > I don't really understand this explanation. Once usb_kill_urb() > > > > returns, > > > > the URB should be avail

Re: [PATCH 0/7] HID: picoLCD updates

2012-08-18 Thread Bruno Prémont
Hi Jiri, [CCing Alan Stern] On Thu, 16 August 2012 Jiri Kosina wrote: > On Thu, 16 Aug 2012, Bruno Prémont wrote: > > > > I don't really understand this explanation. Once usb_kill_urb() returns, > > > the URB should be available for future use (and therefore all queues > > > completely draine

Re: [PATCH 0/7] HID: picoLCD updates

2012-08-16 Thread Jiri Kosina
On Thu, 16 Aug 2012, Bruno Prémont wrote: > > I don't really understand this explanation. Once usb_kill_urb() returns, > > the URB should be available for future use (and therefore all queues > > completely drained). > > I won't have time today to check, though my guess is that on each > echo $

Re: [PATCH 0/7] HID: picoLCD updates

2012-08-16 Thread Bruno Prémont
On Wed, 15 August 2012 Jiri Kosina wrote: > On Wed, 15 Aug 2012, Bruno Prémont wrote: > > > I see. Alan Stern has fixed a huge pile of things in this area in > > > 3.6-rc1. > > > I have expected all of those to actually be on theoretical problems not > > > ever having happened in the wild, but

Re: [PATCH 0/7] HID: picoLCD updates

2012-08-15 Thread Jiri Kosina
On Wed, 15 Aug 2012, Bruno Prémont wrote: > > I see. Alan Stern has fixed a huge pile of things in this area in 3.6-rc1. > > I have expected all of those to actually be on theoretical problems not > > ever having happened in the wild, but it might be that you are actually > > chasing on of thos

Re: [PATCH 0/7] HID: picoLCD updates

2012-08-15 Thread Bruno Prémont
Hi Jiri, On Wed, 15 August 2012 Jiri Kosina wrote: > I see. Alan Stern has fixed a huge pile of things in this area in 3.6-rc1. > I have expected all of those to actually be on theoretical problems not > ever having happened in the wild, but it might be that you are actually > chasing on of th

Re: [PATCH 0/7] HID: picoLCD updates

2012-08-15 Thread Jiri Kosina
On Wed, 15 Aug 2012, Bruno Prémont wrote: > > > [ 6383.521833] > > > = > > > [ 6383.530020] BUG kmalloc-64 (Not tainted): Object already free > > > [ 6383.530020] > > > ---

Re: [PATCH 0/7] HID: picoLCD updates

2012-08-15 Thread Bruno Prémont
Hi Jiri, On Wed, 15 August 2012 Jiri Kosina wrote: > On Mon, 30 Jul 2012, Bruno Prémont wrote: > > Hi, > > > > This series updates picoLCD driver: > > - split the driver functions into separate files which get included > > depending on Kconfig selection > > (implementation for CIR using RC_C

Re: [PATCH 0/7] HID: picoLCD updates

2012-08-15 Thread Jiri Kosina
On Mon, 30 Jul 2012, Bruno Prémont wrote: > Hi, > > This series updates picoLCD driver: > - split the driver functions into separate files which get included > depending on Kconfig selection > (implementation for CIR using RC_CORE will follow later) > - drop private framebuffer refcounting in

Re: [PATCH 0/7] HID: picoLCD updates

2012-08-14 Thread Tejun Heo
Hello, On Tue, Aug 14, 2012 at 08:30:44AM +0200, Bruno Prémont wrote: > > I'm kinda shooting in the dark but who flushes / cancels > > fb_info->deferred_work? > > fb_deferred_io_cleanup() does so and is called by destroy fbops > (when last reference to fb_info is returned): I see. Sorry but jus

Re: [PATCH 0/7] HID: picoLCD updates

2012-08-13 Thread Bruno Prémont
Hello Tejun, [Tejun: sorry for duplicate, did hit "reply" instead of "reply to all"] On Mon, 13 Aug 2012 16:27:08 Tejun Heo wrote: > On Thu, Aug 09, 2012 at 08:09:47PM +0200, Bruno Prémont wrote: > > As you are working on workqueues and related code, could you have a look > > at my usage of them

Re: [PATCH 0/7] HID: picoLCD updates

2012-08-13 Thread Tejun Heo
Hello, On Thu, Aug 09, 2012 at 08:09:47PM +0200, Bruno Prémont wrote: > As you are working on workqueues and related code, could you have a look > at my usage of them in combination with db_defio? > > The delayed memory corruptions or system reboots after unbinding/unplugging > the PicoLCD seem v

Re: [PATCH 0/7] HID: picoLCD updates

2012-08-09 Thread Bruno Prémont
Hi Tejun, As you are working on workqueues and related code, could you have a look at my usage of them in combination with db_defio? The delayed memory corruptions or system reboots after unbinding/unplugging the PicoLCD seem very much related to workqueue used to handle the deferred IO to frameb

Re: [PATCH 0/7] HID: picoLCD updates

2012-07-31 Thread Bruno Prémont
Hi David, On Tue, 31 Jul 2012 09:26:07 David Herrmann wrote: > This is not directly related to this patchset, but did you fix the > locking issue with hid-core? It is still on my todo-list but I haven't > gotten around fixing it, yet. However, I plan on fixing it this > summer, but if picolcd does

Re: [PATCH 0/7] HID: picoLCD updates

2012-07-31 Thread David Herrmann
Hi Bruno On Mon, Jul 30, 2012 at 9:36 PM, Bruno Prémont wrote: > Hi, > > This series updates picoLCD driver: > - split the driver functions into separate files which get included > depending on Kconfig selection > (implementation for CIR using RC_CORE will follow later) > - drop private frame

[PATCH 0/7] HID: picoLCD updates

2012-07-30 Thread Bruno Prémont
Hi, This series updates picoLCD driver: - split the driver functions into separate files which get included depending on Kconfig selection (implementation for CIR using RC_CORE will follow later) - drop private framebuffer refcounting in favor of refcounting added to fb_info some time ago -