Re: [RFC PATCH 0/7] Share events between metrics

2020-12-15 Thread Andi Kleen
> Or, is the concern more about trying to time-slice the results in a > fairly granular way and expecting accurate results then? Usually the later. It's especially important for divisions. You want both divisor and dividend to be in the same time slice, otherwise the result usually doesn't make

Re: [RFC PATCH 0/7] Share events between metrics

2020-12-15 Thread Paul A. Clarke
On Thu, May 07, 2020 at 10:43:43PM -0700, Ian Rogers wrote: > On Thu, May 7, 2020 at 2:47 PM Andi Kleen wrote: > > > > > > - without this change events within a metric may get scheduled > > > > together, after they may appear as part of a larger group and be > > > > multiplexed at different

Re: [PATCH 0/7] Share events between metrics

2020-05-20 Thread Ian Rogers
On Wed, May 20, 2020 at 6:14 AM Jiri Olsa wrote: > > On Wed, May 20, 2020 at 12:28:07AM -0700, Ian Rogers wrote: > > Metric groups contain metrics. Metrics create groups of events to > > ideally be scheduled together. Often metrics refer to the same events, > > for example, a cache hit and cache

Re: [PATCH 0/7] Share events between metrics

2020-05-20 Thread Jiri Olsa
On Wed, May 20, 2020 at 12:28:07AM -0700, Ian Rogers wrote: > Metric groups contain metrics. Metrics create groups of events to > ideally be scheduled together. Often metrics refer to the same events, > for example, a cache hit and cache miss rate. Using separate event > groups means these metrics

[PATCH 0/7] Share events between metrics

2020-05-20 Thread Ian Rogers
Metric groups contain metrics. Metrics create groups of events to ideally be scheduled together. Often metrics refer to the same events, for example, a cache hit and cache miss rate. Using separate event groups means these metrics are multiplexed at different times and the counts don't sum to

Re: [RFC PATCH 0/7] Share events between metrics

2020-05-07 Thread Ian Rogers
On Thu, May 7, 2020 at 2:47 PM Andi Kleen wrote: > > > > - without this change events within a metric may get scheduled > > > together, after they may appear as part of a larger group and be > > > multiplexed at different times, lowering accuracy - however, less > > > multiplexing may

Re: [RFC PATCH 0/7] Share events between metrics

2020-05-07 Thread Andi Kleen
> > - without this change events within a metric may get scheduled > > together, after they may appear as part of a larger group and be > > multiplexed at different times, lowering accuracy - however, less > > multiplexing may compensate for this. > > I agree the heuristic in this patch set

Re: [RFC PATCH 0/7] Share events between metrics

2020-05-07 Thread Ian Rogers
On Thu, May 7, 2020 at 10:48 AM Andi Kleen wrote: > > On Thu, May 07, 2020 at 01:14:29AM -0700, Ian Rogers wrote: > > Metric groups contain metrics. Metrics create groups of events to > > ideally be scheduled together. Often metrics refer to the same events, > > for example, a cache hit and cache

Re: [RFC PATCH 0/7] Share events between metrics

2020-05-07 Thread Andi Kleen
On Thu, May 07, 2020 at 01:14:29AM -0700, Ian Rogers wrote: > Metric groups contain metrics. Metrics create groups of events to > ideally be scheduled together. Often metrics refer to the same events, > for example, a cache hit and cache miss rate. Using separate event > groups means these metrics

Re: [RFC PATCH 0/7] Share events between metrics

2020-05-07 Thread Ian Rogers
On Thu, May 7, 2020 at 6:49 AM Jiri Olsa wrote: > > On Thu, May 07, 2020 at 01:14:29AM -0700, Ian Rogers wrote: > > Metric groups contain metrics. Metrics create groups of events to > > ideally be scheduled together. Often metrics refer to the same events, > > for example, a cache hit and cache

Re: [RFC PATCH 0/7] Share events between metrics

2020-05-07 Thread Jiri Olsa
On Thu, May 07, 2020 at 01:14:29AM -0700, Ian Rogers wrote: > Metric groups contain metrics. Metrics create groups of events to > ideally be scheduled together. Often metrics refer to the same events, > for example, a cache hit and cache miss rate. Using separate event > groups means these metrics

[RFC PATCH 0/7] Share events between metrics

2020-05-07 Thread Ian Rogers
Metric groups contain metrics. Metrics create groups of events to ideally be scheduled together. Often metrics refer to the same events, for example, a cache hit and cache miss rate. Using separate event groups means these metrics are multiplexed at different times and the counts don't sum to