Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-10 Thread James Bottomley
On Thu, 2008-01-10 at 13:01 +1100, Rusty Russell wrote: > On Thursday 10 January 2008 09:10:37 James Bottomley wrote: > > On Tue, 2008-01-08 at 11:39 +1100, Rusty Russell wrote: > > > On Tuesday 08 January 2008 02:48:23 James Bottomley wrote: > > > > We're always open to new APIs (or more powerful

Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-09 Thread Rusty Russell
On Thursday 10 January 2008 09:10:37 James Bottomley wrote: > On Tue, 2008-01-08 at 11:39 +1100, Rusty Russell wrote: > > On Tuesday 08 January 2008 02:48:23 James Bottomley wrote: > > > We're always open to new APIs (or more powerful and expanded old ones). > > > The way we've been doing the sg_ch

Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-09 Thread James Bottomley
On Tue, 2008-01-08 at 11:39 +1100, Rusty Russell wrote: > On Tuesday 08 January 2008 02:48:23 James Bottomley wrote: > > We're always open to new APIs (or more powerful and expanded old ones). > > The way we've been doing the sg_chain conversion is to slide API layers > > into the drivers so sg_ch

Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-07 Thread Rusty Russell
On Tuesday 08 January 2008 02:48:23 James Bottomley wrote: > We're always open to new APIs (or more powerful and expanded old ones). > The way we've been doing the sg_chain conversion is to slide API layers > into the drivers so sg_chain becomes a simple API flip when we turn it > on. Unfortunatel

Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-07 Thread James Bottomley
On Mon, 2008-01-07 at 15:38 +1100, Rusty Russell wrote: > On Sunday 06 January 2008 02:31:12 James Bottomley wrote: > > On Wed, 2007-12-19 at 17:31 +1100, Rusty Russell wrote: > > > This patch series is the start of my attempt to simplify and make > > > explicit the chained scatterlist logic. > > >

Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-07 Thread Herbert Xu
Tejun Heo <[EMAIL PROTECTED]> wrote: > > /me agrees. As long as this can be made sane using one unified > interface, I don't care whether it's sg_ring, table or dish. Give us sg_annulus :) On a more serious note, having played with SG chaining for a couple of years in the crypto layer, I must sa

Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-07 Thread Tejun Heo
Rusty Russell wrote: > On Monday 07 January 2008 17:37:41 Tejun Heo wrote: >> Rusty Russell wrote: >>> Hi Tejun, >>> >>>Nice try! Even ignoring the ugliness of undoing such an operation if >>> the caller doesn't expect you to mangle their chains, consider a >>> one-element sg array. :( >> Heh

Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-07 Thread Rusty Russell
On Monday 07 January 2008 17:37:41 Tejun Heo wrote: > Rusty Russell wrote: > > Hi Tejun, > > > >Nice try! Even ignoring the ugliness of undoing such an operation if > > the caller doesn't expect you to mangle their chains, consider a > > one-element sg array. :( > > Heh heh, that can be dealt

Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-06 Thread Tejun Heo
Rusty Russell wrote: > On Monday 07 January 2008 16:01:40 Tejun Heo wrote: >>> But we hit the same problems: >>> >>> 1) sg_chain loses information. The clever chain packaging makes reading >>> easy, but manipulation is severely limited. You can append to your own >>> chains by padding, but not so

Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-06 Thread Rusty Russell
On Monday 07 January 2008 16:01:40 Tejun Heo wrote: > > But we hit the same problems: > > > > 1) sg_chain loses information. The clever chain packaging makes reading > > easy, but manipulation is severely limited. You can append to your own > > chains by padding, but not someone elses. This work

Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-06 Thread Tejun Heo
Hello, Rusty Russell wrote: >> The other thing I note is that the problem you're claiming to solve with >> sg_ring (the ability to add extra scatterlists to the front or the back >> of an existing one) is already solved with sg_chain, so the only real >> advantage of sg_ring was that it contains e

Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-06 Thread Rusty Russell
On Sunday 06 January 2008 02:31:12 James Bottomley wrote: > On Wed, 2007-12-19 at 17:31 +1100, Rusty Russell wrote: > > This patch series is the start of my attempt to simplify and make > > explicit the chained scatterlist logic. > > > > It's not complete: my SATA box boots and seems happy, but all

Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-05 Thread James Bottomley
On Wed, 2007-12-19 at 17:31 +1100, Rusty Russell wrote: > This patch series is the start of my attempt to simplify and make explicit > the chained scatterlist logic. > > It's not complete: my SATA box boots and seems happy, but all the other > users of SCSI need to be updated and checked. But I'

[PATCH 0/7] sg_ring: a ring of scatterlist arrays

2007-12-18 Thread Rusty Russell
This patch series is the start of my attempt to simplify and make explicit the chained scatterlist logic. It's not complete: my SATA box boots and seems happy, but all the other users of SCSI need to be updated and checked. But I've gotten far enough to believe it's worth persuing. Cheers, Rusty