Re: [PATCH 0/8] Update kernel uabi header files for x32

2014-01-22 Thread Catalin Marinas
On Tue, Jan 21, 2014 at 09:06:59AM -0800, H. Peter Anvin wrote: > On 12/27/2013 02:14 PM, H.J. Lu wrote: > > X32 uses the same kernel system call interface as x86-64 for many > > system calls. However, "long" is 64-bit for x86-64 and is 32-bit for > > x32. Where long or unsigned long are used in

Re: [PATCH 0/8] Update kernel uabi header files for x32

2014-01-21 Thread H. Peter Anvin
On 12/27/2013 02:14 PM, H.J. Lu wrote: > X32 uses the same kernel system call interface as x86-64 for many > system calls. However, "long" is 64-bit for x86-64 and is 32-bit for > x32. Where long or unsigned long are used in struct types for such > system calls, they are wrong for x32. __kernel_

Re: [PATCH 0/8] Update kernel uabi header files for x32

2014-01-21 Thread H. Peter Anvin
On 01/21/2014 04:04 AM, Catalin Marinas wrote: > > ILP32 for arm64 is still work in progress and subject to change. So far > the preliminary ABI > (http://git.kernel.org/cgit/linux/kernel/git/cmarinas/linux-aarch64.git/log/?h=ilp32) > redefines kernel_(u)long_t is defined as (unsigned) long long.

Re: [PATCH 0/8] Update kernel uabi header files for x32

2014-01-21 Thread H.J. Lu
On Tue, Jan 21, 2014 at 4:04 AM, Catalin Marinas wrote: > On Mon, Jan 20, 2014 at 05:46:41PM +, H. Peter Anvin wrote: >> On 12/28/2013 08:33 AM, Christoph Hellwig wrote: >> > On Fri, Dec 27, 2013 at 02:14:16PM -0800, H.J. Lu wrote: >> >> X32 uses the same kernel system call interface as x86-64

Re: [PATCH 0/8] Update kernel uabi header files for x32

2014-01-21 Thread Catalin Marinas
On Mon, Jan 20, 2014 at 05:46:41PM +, H. Peter Anvin wrote: > On 12/28/2013 08:33 AM, Christoph Hellwig wrote: > > On Fri, Dec 27, 2013 at 02:14:16PM -0800, H.J. Lu wrote: > >> X32 uses the same kernel system call interface as x86-64 for many > >> system calls. However, "long" is 64-bit for x8

Re: [PATCH 0/8] Update kernel uabi header files for x32

2014-01-20 Thread H. Peter Anvin
On 01/20/2014 09:50 AM, Christoph Hellwig wrote: > On Mon, Jan 20, 2014 at 09:46:41AM -0800, H. Peter Anvin wrote: >> This comment by Christoph was literally the only feedback on this >> patchset. The definition of __kernel_[u]long_t is "the size of 'long' >> for the native kernel for the ABI". H

Re: [PATCH 0/8] Update kernel uabi header files for x32

2014-01-20 Thread H.J. Lu
On Mon, Jan 20, 2014 at 9:51 AM, H.J. Lu wrote: > On Mon, Jan 20, 2014 at 9:50 AM, Christoph Hellwig wrote: >> On Mon, Jan 20, 2014 at 09:46:41AM -0800, H. Peter Anvin wrote: >>> This comment by Christoph was literally the only feedback on this >>> patchset. The definition of __kernel_[u]long_t

Re: [PATCH 0/8] Update kernel uabi header files for x32

2014-01-20 Thread H. Peter Anvin
On 01/20/2014 09:51 AM, H.J. Lu wrote: > On Mon, Jan 20, 2014 at 9:50 AM, Christoph Hellwig wrote: >> On Mon, Jan 20, 2014 at 09:46:41AM -0800, H. Peter Anvin wrote: >>> This comment by Christoph was literally the only feedback on this >>> patchset. The definition of __kernel_[u]long_t is "the si

Re: [PATCH 0/8] Update kernel uabi header files for x32

2014-01-20 Thread H. Peter Anvin
On 12/28/2013 08:33 AM, Christoph Hellwig wrote: > On Fri, Dec 27, 2013 at 02:14:16PM -0800, H.J. Lu wrote: >> X32 uses the same kernel system call interface as x86-64 for many >> system calls. However, "long" is 64-bit for x86-64 and is 32-bit for >> x32. Where long or unsigned long are used in

Re: [PATCH 0/8] Update kernel uabi header files for x32

2014-01-20 Thread H.J. Lu
On Mon, Jan 20, 2014 at 9:50 AM, Christoph Hellwig wrote: > On Mon, Jan 20, 2014 at 09:46:41AM -0800, H. Peter Anvin wrote: >> This comment by Christoph was literally the only feedback on this >> patchset. The definition of __kernel_[u]long_t is "the size of 'long' >> for the native kernel for th

Re: [PATCH 0/8] Update kernel uabi header files for x32

2014-01-20 Thread Christoph Hellwig
On Mon, Jan 20, 2014 at 09:46:41AM -0800, H. Peter Anvin wrote: > This comment by Christoph was literally the only feedback on this > patchset. The definition of __kernel_[u]long_t is "the size of 'long' > for the native kernel for the ABI". H.J.'s patchset only affects x86 > (specifically x86-64

Re: [PATCH 0/8] Update kernel uabi header files for x32

2013-12-28 Thread H. Peter Anvin
On 12/28/2013 08:33 AM, Christoph Hellwig wrote: > > Independent on how this fixes things, how does the kernel_long_t name > here make any sense? > > On x86-64 "kernel" long always is 64 bits wide. The userspace ABI long > might be 32 or 64bits wide. > > Currently kernel_long_t has almost no us

Re: [PATCH 0/8] Update kernel uabi header files for x32

2013-12-28 Thread Christoph Hellwig
On Fri, Dec 27, 2013 at 02:14:16PM -0800, H.J. Lu wrote: > X32 uses the same kernel system call interface as x86-64 for many > system calls. However, "long" is 64-bit for x86-64 and is 32-bit for > x32. Where long or unsigned long are used in struct types for such > system calls, they are wrong f

[PATCH 0/8] Update kernel uabi header files for x32

2013-12-27 Thread H.J. Lu
X32 uses the same kernel system call interface as x86-64 for many system calls. However, "long" is 64-bit for x86-64 and is 32-bit for x32. Where long or unsigned long are used in struct types for such system calls, they are wrong for x32. __kernel_[u]long_t is [unsigned] long for all ABIs other

[PATCH 0/8] Update kernel uabi header files for x32

2013-12-27 Thread H.J. Lu
X32 uses the same kernel system call interface as x86-64 for many system calls. However, "long" is 64-bit for x86-64 and is 32-bit for x32. Where long or unsigned long are used in struct types for such system calls, they are wrong for x32. __kernel_[u]long_t is [unsigned] long for all ABIs other