Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-30 Thread Jonathan Woithe
Hi Michael On Thu, Mar 30, 2017 at 08:41:15AM +0200, Micha?? K??pie?? wrote: > I noted your concerns about error handling in the driver ... For the time > being I would rather concentrate on the issues I personally consider more > pressing as I will most likely lose access to modern Fujitsu

Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-30 Thread Jonathan Woithe
Hi Michael On Thu, Mar 30, 2017 at 08:41:15AM +0200, Micha?? K??pie?? wrote: > I noted your concerns about error handling in the driver ... For the time > being I would rather concentrate on the issues I personally consider more > pressing as I will most likely lose access to modern Fujitsu

Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-30 Thread Michał Kępień
> On Thu, Mar 30, 2017 at 02:26:26PM +1030, Jonathan Woithe wrote: > > On Wed, Mar 29, 2017 at 08:36:50PM -0700, Darren Hart wrote: > > > On Wed, Mar 29, 2017 at 07:35:50PM +0300, Andy Shevchenko wrote: > > > > On Wed, Mar 29, 2017 at 10:19 AM, Micha?? K??pie?? > > > > wrote:

Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-30 Thread Michał Kępień
> On Thu, Mar 30, 2017 at 02:26:26PM +1030, Jonathan Woithe wrote: > > On Wed, Mar 29, 2017 at 08:36:50PM -0700, Darren Hart wrote: > > > On Wed, Mar 29, 2017 at 07:35:50PM +0300, Andy Shevchenko wrote: > > > > On Wed, Mar 29, 2017 at 10:19 AM, Micha?? K??pie?? > > > > wrote: > > > > > > > > >

Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-29 Thread Darren Hart
On Thu, Mar 30, 2017 at 02:26:26PM +1030, Jonathan Woithe wrote: > On Wed, Mar 29, 2017 at 08:36:50PM -0700, Darren Hart wrote: > > On Wed, Mar 29, 2017 at 07:35:50PM +0300, Andy Shevchenko wrote: > > > On Wed, Mar 29, 2017 at 10:19 AM, Micha?? K??pie?? > > > wrote: > > > > >

Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-29 Thread Darren Hart
On Thu, Mar 30, 2017 at 02:26:26PM +1030, Jonathan Woithe wrote: > On Wed, Mar 29, 2017 at 08:36:50PM -0700, Darren Hart wrote: > > On Wed, Mar 29, 2017 at 07:35:50PM +0300, Andy Shevchenko wrote: > > > On Wed, Mar 29, 2017 at 10:19 AM, Micha?? K??pie?? > > > wrote: > > > > > > > Darren, Andy,

Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-29 Thread Jonathan Woithe
On Wed, Mar 29, 2017 at 08:36:50PM -0700, Darren Hart wrote: > On Wed, Mar 29, 2017 at 07:35:50PM +0300, Andy Shevchenko wrote: > > On Wed, Mar 29, 2017 at 10:19 AM, Micha?? K??pie?? > > wrote: > > > > > Darren, Andy, in light of the above I will be awaiting your review of >

Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-29 Thread Jonathan Woithe
On Wed, Mar 29, 2017 at 08:36:50PM -0700, Darren Hart wrote: > On Wed, Mar 29, 2017 at 07:35:50PM +0300, Andy Shevchenko wrote: > > On Wed, Mar 29, 2017 at 10:19 AM, Micha?? K??pie?? > > wrote: > > > > > Darren, Andy, in light of the above I will be awaiting your review of > > > this series. I

Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-29 Thread Darren Hart
On Wed, Mar 29, 2017 at 07:35:50PM +0300, Andy Shevchenko wrote: > On Wed, Mar 29, 2017 at 10:19 AM, Michał Kępień wrote: > > > Darren, Andy, in light of the above I will be awaiting your review of > > this series. I will submit v2 afterwards, with all remarks from both > >

Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-29 Thread Darren Hart
On Wed, Mar 29, 2017 at 07:35:50PM +0300, Andy Shevchenko wrote: > On Wed, Mar 29, 2017 at 10:19 AM, Michał Kępień wrote: > > > Darren, Andy, in light of the above I will be awaiting your review of > > this series. I will submit v2 afterwards, with all remarks from both > > you and Jonathan

Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-29 Thread Darren Hart
On Wed, Mar 29, 2017 at 09:30:29AM +1030, Jonathan Woithe wrote: > On Tue, Mar 28, 2017 at 08:16:18AM +0200, Micha?? K??pie?? wrote: > > > On Fri, Mar 24, 2017 at 09:19:59PM +1030, Jonathan Woithe wrote: > > > > On Mon, Mar 20, 2017 at 10:32:16AM +0100, Micha?? K??pie?? wrote: > > > > > This

Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-29 Thread Darren Hart
On Wed, Mar 29, 2017 at 09:30:29AM +1030, Jonathan Woithe wrote: > On Tue, Mar 28, 2017 at 08:16:18AM +0200, Micha?? K??pie?? wrote: > > > On Fri, Mar 24, 2017 at 09:19:59PM +1030, Jonathan Woithe wrote: > > > > On Mon, Mar 20, 2017 at 10:32:16AM +0100, Micha?? K??pie?? wrote: > > > > > This

Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-29 Thread Andy Shevchenko
On Wed, Mar 29, 2017 at 10:19 AM, Michał Kępień wrote: > Darren, Andy, in light of the above I will be awaiting your review of > this series. I will submit v2 afterwards, with all remarks from both > you and Jonathan taken into account. Darren marked this series under his

Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-29 Thread Andy Shevchenko
On Wed, Mar 29, 2017 at 10:19 AM, Michał Kępień wrote: > Darren, Andy, in light of the above I will be awaiting your review of > this series. I will submit v2 afterwards, with all remarks from both > you and Jonathan taken into account. Darren marked this series under his name to review, so, I

Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-29 Thread Michał Kępień
> On Tue, Mar 28, 2017 at 08:16:18AM +0200, Micha?? K??pie?? wrote: > > > On Fri, Mar 24, 2017 at 09:19:59PM +1030, Jonathan Woithe wrote: > > > > On Mon, Mar 20, 2017 at 10:32:16AM +0100, Micha?? K??pie?? wrote: > > > > > This series simplifies handling of both brightness key and hotkey > > > >

Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-29 Thread Michał Kępień
> On Tue, Mar 28, 2017 at 08:16:18AM +0200, Micha?? K??pie?? wrote: > > > On Fri, Mar 24, 2017 at 09:19:59PM +1030, Jonathan Woithe wrote: > > > > On Mon, Mar 20, 2017 at 10:32:16AM +0100, Micha?? K??pie?? wrote: > > > > > This series simplifies handling of both brightness key and hotkey > > > >

Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-28 Thread Jonathan Woithe
On Tue, Mar 28, 2017 at 08:16:18AM +0200, Micha?? K??pie?? wrote: > > On Fri, Mar 24, 2017 at 09:19:59PM +1030, Jonathan Woithe wrote: > > > On Mon, Mar 20, 2017 at 10:32:16AM +0100, Micha?? K??pie?? wrote: > > > > This series simplifies handling of both brightness key and hotkey input > > > >

Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-28 Thread Jonathan Woithe
On Tue, Mar 28, 2017 at 08:16:18AM +0200, Micha?? K??pie?? wrote: > > On Fri, Mar 24, 2017 at 09:19:59PM +1030, Jonathan Woithe wrote: > > > On Mon, Mar 20, 2017 at 10:32:16AM +0100, Micha?? K??pie?? wrote: > > > > This series simplifies handling of both brightness key and hotkey input > > > >

Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-28 Thread Michał Kępień
> On Fri, Mar 24, 2017 at 09:19:59PM +1030, Jonathan Woithe wrote: > > On Mon, Mar 20, 2017 at 10:32:16AM +0100, Micha?? K??pie?? wrote: > > > This series simplifies handling of both brightness key and hotkey input > > > events on Fujitsu laptops by making use of sparse keymaps. This not > > >

Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-28 Thread Michał Kępień
> On Fri, Mar 24, 2017 at 09:19:59PM +1030, Jonathan Woithe wrote: > > On Mon, Mar 20, 2017 at 10:32:16AM +0100, Micha?? K??pie?? wrote: > > > This series simplifies handling of both brightness key and hotkey input > > > events on Fujitsu laptops by making use of sparse keymaps. This not > > >

Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-27 Thread Jonathan Woithe
On Fri, Mar 24, 2017 at 09:19:59PM +1030, Jonathan Woithe wrote: > On Mon, Mar 20, 2017 at 10:32:16AM +0100, Micha?? K??pie?? wrote: > > This series simplifies handling of both brightness key and hotkey input > > events on Fujitsu laptops by making use of sparse keymaps. This not > > only makes

Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-27 Thread Jonathan Woithe
On Fri, Mar 24, 2017 at 09:19:59PM +1030, Jonathan Woithe wrote: > On Mon, Mar 20, 2017 at 10:32:16AM +0100, Micha?? K??pie?? wrote: > > This series simplifies handling of both brightness key and hotkey input > > events on Fujitsu laptops by making use of sparse keymaps. This not > > only makes

Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-24 Thread Jonathan Woithe
On Mon, Mar 20, 2017 at 10:32:16AM +0100, Micha?? K??pie?? wrote: > This series simplifies handling of both brightness key and hotkey input > events on Fujitsu laptops by making use of sparse keymaps. This not > only makes the driver shorter and, hopefully, cleaner, but also enables > us to get

Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-24 Thread Jonathan Woithe
On Mon, Mar 20, 2017 at 10:32:16AM +0100, Micha?? K??pie?? wrote: > This series simplifies handling of both brightness key and hotkey input > events on Fujitsu laptops by making use of sparse keymaps. This not > only makes the driver shorter and, hopefully, cleaner, but also enables > us to get

[PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-20 Thread Michał Kępień
This series simplifies handling of both brightness key and hotkey input events on Fujitsu laptops by making use of sparse keymaps. This not only makes the driver shorter and, hopefully, cleaner, but also enables us to get rid of the keycodeX fields inside struct fujitsu_bl, which facilitates

[PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-20 Thread Michał Kępień
This series simplifies handling of both brightness key and hotkey input events on Fujitsu laptops by making use of sparse keymaps. This not only makes the driver shorter and, hopefully, cleaner, but also enables us to get rid of the keycodeX fields inside struct fujitsu_bl, which facilitates