Re: [PATCH 0/8] x86/fpu: Remove CR0.TS support

2016-11-01 Thread Borislav Petkov
On Tue, Nov 01, 2016 at 08:51:57AM +0100, Paul Bolle wrote: > And as probably everybody capable of hacking on lguest (ie, other > people than me) came up with doubts similar to yours, these two issues > never got fixed. You can always try to fix them and see where it gets ya. I think that's the

Re: [PATCH 0/8] x86/fpu: Remove CR0.TS support

2016-11-01 Thread Borislav Petkov
On Tue, Nov 01, 2016 at 08:51:57AM +0100, Paul Bolle wrote: > And as probably everybody capable of hacking on lguest (ie, other > people than me) came up with doubts similar to yours, these two issues > never got fixed. You can always try to fix them and see where it gets ya. I think that's the

Re: [PATCH 0/8] x86/fpu: Remove CR0.TS support

2016-11-01 Thread Paul Bolle
On Tue, 2016-11-01 at 00:48 +0100, Borislav Petkov wrote: > --- a/drivers/lguest/Kconfig > +++ b/drivers/lguest/Kconfig >  config LGUEST >   tristate "Linux hypervisor example code" > - depends on X86_32 && EVENTFD && TTY && PCI_DIRECT > > + depends on X86_32 && EVENTFD && TTY &&

Re: [PATCH 0/8] x86/fpu: Remove CR0.TS support

2016-11-01 Thread Paul Bolle
On Tue, 2016-11-01 at 00:48 +0100, Borislav Petkov wrote: > --- a/drivers/lguest/Kconfig > +++ b/drivers/lguest/Kconfig >  config LGUEST >   tristate "Linux hypervisor example code" > - depends on X86_32 && EVENTFD && TTY && PCI_DIRECT > > + depends on X86_32 && EVENTFD && TTY &&

Re: [PATCH 0/8] x86/fpu: Remove CR0.TS support

2016-10-31 Thread Borislav Petkov
On Tue, Nov 01, 2016 at 12:10:48AM +0100, Paul Bolle wrote: > See https://lists.ozlabs.org/pipermail/lguest/2013-May/002001.html . > Nobody cared enough to fix it. I cared enough to figure it all out. But > I didn't understand much of the possible solutions that where suggested > three years ago.

Re: [PATCH 0/8] x86/fpu: Remove CR0.TS support

2016-10-31 Thread Borislav Petkov
On Tue, Nov 01, 2016 at 12:10:48AM +0100, Paul Bolle wrote: > See https://lists.ozlabs.org/pipermail/lguest/2013-May/002001.html . > Nobody cared enough to fix it. I cared enough to figure it all out. But > I didn't understand much of the possible solutions that where suggested > three years ago.

Re: [PATCH 0/8] x86/fpu: Remove CR0.TS support

2016-10-31 Thread Paul Bolle
On Tue, 2016-11-01 at 00:04 +0100, Borislav Petkov wrote: > Huh, what does that have to do with disabling the microcode loader? > > Funny... See https://lists.ozlabs.org/pipermail/lguest/2013-May/002001.html . Nobody cared enough to fix it. I cared enough to figure it all out. But I didn't

Re: [PATCH 0/8] x86/fpu: Remove CR0.TS support

2016-10-31 Thread Paul Bolle
On Tue, 2016-11-01 at 00:04 +0100, Borislav Petkov wrote: > Huh, what does that have to do with disabling the microcode loader? > > Funny... See https://lists.ozlabs.org/pipermail/lguest/2013-May/002001.html . Nobody cared enough to fix it. I cared enough to figure it all out. But I didn't

Re: [PATCH 0/8] x86/fpu: Remove CR0.TS support

2016-10-31 Thread Borislav Petkov
On Mon, Oct 31, 2016 at 11:41:19PM +0100, Paul Bolle wrote: > A similar obscure gotcha (I think it is "unhandled trap 13") can be > avoided by launching the guest with the dis_ucode_ldr kernel option. ^ Huh, what does that have to do with

Re: [PATCH 0/8] x86/fpu: Remove CR0.TS support

2016-10-31 Thread Borislav Petkov
On Mon, Oct 31, 2016 at 11:41:19PM +0100, Paul Bolle wrote: > A similar obscure gotcha (I think it is "unhandled trap 13") can be > avoided by launching the guest with the dis_ucode_ldr kernel option. ^ Huh, what does that have to do with

Re: [PATCH 0/8] x86/fpu: Remove CR0.TS support

2016-10-31 Thread Paul Bolle
On Mon, 2016-10-31 at 15:18 -0700, Andy Lutomirski wrote: > I havne't meaningfully tested lguest because I can't get it to work > even without these patches. Have you disabled CONFIG_OLPC in the .config for the guest kernel? Otherwise you will run into     lguest: Reinjecting trap 13 for fault at

Re: [PATCH 0/8] x86/fpu: Remove CR0.TS support

2016-10-31 Thread Paul Bolle
On Mon, 2016-10-31 at 15:18 -0700, Andy Lutomirski wrote: > I havne't meaningfully tested lguest because I can't get it to work > even without these patches. Have you disabled CONFIG_OLPC in the .config for the guest kernel? Otherwise you will run into     lguest: Reinjecting trap 13 for fault at

[PATCH 0/8] x86/fpu: Remove CR0.TS support

2016-10-31 Thread Andy Lutomirski
We don't do anything useful with CR0.TS anymore, so remove most of our support for it. I havne't meaningfully tested lguest because I can't get it to work even without these patches. Andy Lutomirski (8): fpu/init: Get rid of two redundant clts() calls fpu/bugs: Stop saving and restoring

[PATCH 0/8] x86/fpu: Remove CR0.TS support

2016-10-31 Thread Andy Lutomirski
We don't do anything useful with CR0.TS anymore, so remove most of our support for it. I havne't meaningfully tested lguest because I can't get it to work even without these patches. Andy Lutomirski (8): fpu/init: Get rid of two redundant clts() calls fpu/bugs: Stop saving and restoring