Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Marcel Holtmann
Hi Jan, > > > > I agree with Dmitry on this point. The IHEX parser should not be inside > > > > firmware_class.c. What about using keyspan_ihex.[ch] for it? > > > > > > That's what I had originally, actually called firmware_ihex.ko, since > > > the IHEX format parser is not in any way keyspan

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Dmitry Torokhov
On Apr 5, 2005 6:45 AM, Jan Harkes <[EMAIL PROTECTED]> wrote: > On Tue, Apr 05, 2005 at 11:22:06AM +0200, Marcel Holtmann wrote: > > I agree with Dmitry on this point. The IHEX parser should not be inside > > firmware_class.c. What about using keyspan_ihex.[ch] for it? > > That's what I had

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Marcel Holtmann
Hi Dmitry, > > People are also working on a replacement for the > > current request_firmware(), because the needs are changing. Try to keep > > it close with the usb-serial for now. > > > > Could you elaborate on what do you think is needed? I have some of > patches to firmware loader and

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Jan Harkes
On Tue, Apr 05, 2005 at 04:36:31PM +0200, Marcel Holtmann wrote: > > > I agree with Dmitry on this point. The IHEX parser should not be inside > > > firmware_class.c. What about using keyspan_ihex.[ch] for it? > > > > That's what I had originally, actually called firmware_ihex.ko, since > > the

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Dmitry Torokhov
On Apr 5, 2005 9:36 AM, Marcel Holtmann <[EMAIL PROTECTED]> wrote: > People are also working on a replacement for the > current request_firmware(), because the needs are changing. Try to keep > it close with the usb-serial for now. > Could you elaborate on what do you think is needed? I have

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Humberto Massa
Sven Luther wrote: On Tue, Apr 05, 2005 at 12:23:29AM -0400, Jan Harkes wrote: > This ofcourse doesn't actually solve Debian's distribution issues since > the keyspan firmware can only be distributed as part of 'Linux or other > Open Source operating system kernel'. Well, if this is the case, it

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Marcel Holtmann
Hi Jan, > > I agree with Dmitry on this point. The IHEX parser should not be inside > > firmware_class.c. What about using keyspan_ihex.[ch] for it? > > That's what I had originally, actually called firmware_ihex.ko, since > the IHEX format parser is not in any way keyspan specific and there are

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Jan Harkes
On Tue, Apr 05, 2005 at 11:22:06AM +0200, Marcel Holtmann wrote: > I agree with Dmitry on this point. The IHEX parser should not be inside > firmware_class.c. What about using keyspan_ihex.[ch] for it? That's what I had originally, actually called firmware_ihex.ko, since the IHEX format parser is

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Jan Harkes
On Tue, Apr 05, 2005 at 10:32:38AM +0200, Kay Sievers wrote: > On Mon, 2005-04-04 at 23:51 -0500, Dmitry Torokhov wrote: > > Firmware loader is format-agnostic, I think having IHEX parser in a separate > > file would be better... > > Why should this be in-kernel at all? Convert the firmware into

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Marcel Holtmann
Hi Jan, > > > > Mmm, probably that 2001 discussion about the keyspan firmware, right ? > > > > > > > > http://lists.debian.org/debian-legal/2001/04/msg00145.html > > > > > > > > Can you summarize the conclusion of the thread, or what you did get > > > > from it, > > > > please ? > > > > >

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Kay Sievers
On Mon, 2005-04-04 at 23:51 -0500, Dmitry Torokhov wrote: > On Monday 04 April 2005 23:23, Jan Harkes wrote: > > On Mon, Apr 04, 2005 at 12:17:46PM -0700, Greg KH wrote: > > > On Mon, Apr 04, 2005 at 08:27:53PM +0200, Sven Luther wrote: > > > > Mmm, probably that 2001 discussion about the keyspan

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Marcel Holtmann
Hi Jan, I agree with Dmitry on this point. The IHEX parser should not be inside firmware_class.c. What about using keyspan_ihex.[ch] for it? That's what I had originally, actually called firmware_ihex.ko, since the IHEX format parser is not in any way keyspan specific and there

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Kay Sievers
On Mon, 2005-04-04 at 23:51 -0500, Dmitry Torokhov wrote: On Monday 04 April 2005 23:23, Jan Harkes wrote: On Mon, Apr 04, 2005 at 12:17:46PM -0700, Greg KH wrote: On Mon, Apr 04, 2005 at 08:27:53PM +0200, Sven Luther wrote: Mmm, probably that 2001 discussion about the keyspan firmware,

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Marcel Holtmann
Hi Jan, Mmm, probably that 2001 discussion about the keyspan firmware, right ? http://lists.debian.org/debian-legal/2001/04/msg00145.html Can you summarize the conclusion of the thread, or what you did get from it, please ? That people didn't like the

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Jan Harkes
On Tue, Apr 05, 2005 at 10:32:38AM +0200, Kay Sievers wrote: On Mon, 2005-04-04 at 23:51 -0500, Dmitry Torokhov wrote: Firmware loader is format-agnostic, I think having IHEX parser in a separate file would be better... Why should this be in-kernel at all? Convert the firmware into a

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Jan Harkes
On Tue, Apr 05, 2005 at 11:22:06AM +0200, Marcel Holtmann wrote: I agree with Dmitry on this point. The IHEX parser should not be inside firmware_class.c. What about using keyspan_ihex.[ch] for it? That's what I had originally, actually called firmware_ihex.ko, since the IHEX format parser is

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Marcel Holtmann
Hi Jan, I agree with Dmitry on this point. The IHEX parser should not be inside firmware_class.c. What about using keyspan_ihex.[ch] for it? That's what I had originally, actually called firmware_ihex.ko, since the IHEX format parser is not in any way keyspan specific and there are

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Humberto Massa
Sven Luther wrote: On Tue, Apr 05, 2005 at 12:23:29AM -0400, Jan Harkes wrote: This ofcourse doesn't actually solve Debian's distribution issues since the keyspan firmware can only be distributed as part of 'Linux or other Open Source operating system kernel'. Well, if this is the case, it

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Dmitry Torokhov
On Apr 5, 2005 9:36 AM, Marcel Holtmann [EMAIL PROTECTED] wrote: People are also working on a replacement for the current request_firmware(), because the needs are changing. Try to keep it close with the usb-serial for now. Could you elaborate on what do you think is needed? I have some of

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Jan Harkes
On Tue, Apr 05, 2005 at 04:36:31PM +0200, Marcel Holtmann wrote: I agree with Dmitry on this point. The IHEX parser should not be inside firmware_class.c. What about using keyspan_ihex.[ch] for it? That's what I had originally, actually called firmware_ihex.ko, since the IHEX format

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Marcel Holtmann
Hi Dmitry, People are also working on a replacement for the current request_firmware(), because the needs are changing. Try to keep it close with the usb-serial for now. Could you elaborate on what do you think is needed? I have some of patches to firmware loader and wondering if we

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Dmitry Torokhov
On Apr 5, 2005 6:45 AM, Jan Harkes [EMAIL PROTECTED] wrote: On Tue, Apr 05, 2005 at 11:22:06AM +0200, Marcel Holtmann wrote: I agree with Dmitry on this point. The IHEX parser should not be inside firmware_class.c. What about using keyspan_ihex.[ch] for it? That's what I had originally,

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-04 Thread Sven Luther
On Tue, Apr 05, 2005 at 12:23:29AM -0400, Jan Harkes wrote: > On Mon, Apr 04, 2005 at 12:17:46PM -0700, Greg KH wrote: > > On Mon, Apr 04, 2005 at 08:27:53PM +0200, Sven Luther wrote: > > > Mmm, probably that 2001 discussion about the keyspan firmware, right ? > > > > > >

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-04 Thread Dmitry Torokhov
On Monday 04 April 2005 23:23, Jan Harkes wrote: > On Mon, Apr 04, 2005 at 12:17:46PM -0700, Greg KH wrote: > > On Mon, Apr 04, 2005 at 08:27:53PM +0200, Sven Luther wrote: > > > Mmm, probably that 2001 discussion about the keyspan firmware, right ? > > > > > >

[PATCH 00/04] Load keyspan firmware with hotplug

2005-04-04 Thread Jan Harkes
On Mon, Apr 04, 2005 at 12:17:46PM -0700, Greg KH wrote: > On Mon, Apr 04, 2005 at 08:27:53PM +0200, Sven Luther wrote: > > Mmm, probably that 2001 discussion about the keyspan firmware, right ? > > > > http://lists.debian.org/debian-legal/2001/04/msg00145.html > > > > Can you summarize the

[PATCH 00/04] Load keyspan firmware with hotplug

2005-04-04 Thread Jan Harkes
On Mon, Apr 04, 2005 at 12:17:46PM -0700, Greg KH wrote: On Mon, Apr 04, 2005 at 08:27:53PM +0200, Sven Luther wrote: Mmm, probably that 2001 discussion about the keyspan firmware, right ? http://lists.debian.org/debian-legal/2001/04/msg00145.html Can you summarize the conclusion of

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-04 Thread Dmitry Torokhov
On Monday 04 April 2005 23:23, Jan Harkes wrote: On Mon, Apr 04, 2005 at 12:17:46PM -0700, Greg KH wrote: On Mon, Apr 04, 2005 at 08:27:53PM +0200, Sven Luther wrote: Mmm, probably that 2001 discussion about the keyspan firmware, right ?

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-04 Thread Sven Luther
On Tue, Apr 05, 2005 at 12:23:29AM -0400, Jan Harkes wrote: On Mon, Apr 04, 2005 at 12:17:46PM -0700, Greg KH wrote: On Mon, Apr 04, 2005 at 08:27:53PM +0200, Sven Luther wrote: Mmm, probably that 2001 discussion about the keyspan firmware, right ?