Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Sun, 2018-05-20 at 18:17 -0400, Kent Overstreet wrote: > On Fri, May 18, 2018 at 03:12:27PM +, Bart Van Assche wrote: > > On Fri, 2018-05-18 at 05:06 -0400, Kent Overstreet wrote: > > > On Thu, May 17, 2018 at 08:54:57PM +, Bart Van Assche wrote: > > > > With Jens' latest for-next

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Sun, 2018-05-20 at 18:17 -0400, Kent Overstreet wrote: > On Fri, May 18, 2018 at 03:12:27PM +, Bart Van Assche wrote: > > On Fri, 2018-05-18 at 05:06 -0400, Kent Overstreet wrote: > > > On Thu, May 17, 2018 at 08:54:57PM +, Bart Van Assche wrote: > > > > With Jens' latest for-next

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Mon, 2018-05-21 at 11:37 -0700, Omar Sandoval wrote: > Have you made any progress in porting srp-test to blktests so we don't > have to have this conversation again? Hello Omar, Porting the srp-test software to the blktests framework is still high on my to-do list. I will start working on

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Mon, 2018-05-21 at 11:37 -0700, Omar Sandoval wrote: > Have you made any progress in porting srp-test to blktests so we don't > have to have this conversation again? Hello Omar, Porting the srp-test software to the blktests framework is still high on my to-do list. I will start working on

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Mon, May 21, 2018 at 03:11:08PM +, Bart Van Assche wrote: > On Sun, 2018-05-20 at 19:58 -0400, Kent Overstreet wrote: > > On Sun, May 20, 2018 at 11:40:45PM +, Bart Van Assche wrote: > > > On Sun, 2018-05-20 at 19:21 -0400, Kent Overstreet wrote: > > > > I really have better things to

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Mon, May 21, 2018 at 03:11:08PM +, Bart Van Assche wrote: > On Sun, 2018-05-20 at 19:58 -0400, Kent Overstreet wrote: > > On Sun, May 20, 2018 at 11:40:45PM +, Bart Van Assche wrote: > > > On Sun, 2018-05-20 at 19:21 -0400, Kent Overstreet wrote: > > > > I really have better things to

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Sun, 2018-05-20 at 19:58 -0400, Kent Overstreet wrote: > On Sun, May 20, 2018 at 11:40:45PM +, Bart Van Assche wrote: > > On Sun, 2018-05-20 at 19:21 -0400, Kent Overstreet wrote: > > > I really have better things to do than debug someone else's tests... > > > [ ... ] > > > ../run_tests:

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Sun, 2018-05-20 at 19:58 -0400, Kent Overstreet wrote: > On Sun, May 20, 2018 at 11:40:45PM +, Bart Van Assche wrote: > > On Sun, 2018-05-20 at 19:21 -0400, Kent Overstreet wrote: > > > I really have better things to do than debug someone else's tests... > > > [ ... ] > > > ../run_tests:

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Sun, May 20, 2018 at 11:40:45PM +, Bart Van Assche wrote: > On Sun, 2018-05-20 at 19:21 -0400, Kent Overstreet wrote: > > I really have better things to do than debug someone else's tests... > > [ ... ] > > ../run_tests: line 65: cd: /lib/modules/4.16.0+/kernel/block: No such file > > or

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Sun, May 20, 2018 at 11:40:45PM +, Bart Van Assche wrote: > On Sun, 2018-05-20 at 19:21 -0400, Kent Overstreet wrote: > > I really have better things to do than debug someone else's tests... > > [ ... ] > > ../run_tests: line 65: cd: /lib/modules/4.16.0+/kernel/block: No such file > > or

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Sun, 2018-05-20 at 19:21 -0400, Kent Overstreet wrote: > I really have better things to do than debug someone else's tests... > [ ... ] > ../run_tests: line 65: cd: /lib/modules/4.16.0+/kernel/block: No such file or > directory Kernel v4.16 is too old to run these tests. The srp-test script

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Sun, 2018-05-20 at 19:21 -0400, Kent Overstreet wrote: > I really have better things to do than debug someone else's tests... > [ ... ] > ../run_tests: line 65: cd: /lib/modules/4.16.0+/kernel/block: No such file or > directory Kernel v4.16 is too old to run these tests. The srp-test script

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Sun, May 20, 2018 at 10:35:29PM +, Bart Van Assche wrote: > On Sun, 2018-05-20 at 18:31 -0400, Kent Overstreet wrote: > > On Sun, May 20, 2018 at 10:19:13PM +, Bart Van Assche wrote: > > > On Sun, 2018-05-20 at 18:17 -0400, Kent Overstreet wrote: > > > > On Fri, May 18, 2018 at

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Sun, May 20, 2018 at 10:35:29PM +, Bart Van Assche wrote: > On Sun, 2018-05-20 at 18:31 -0400, Kent Overstreet wrote: > > On Sun, May 20, 2018 at 10:19:13PM +, Bart Van Assche wrote: > > > On Sun, 2018-05-20 at 18:17 -0400, Kent Overstreet wrote: > > > > On Fri, May 18, 2018 at

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Sun, 2018-05-20 at 19:00 -0400, Kent Overstreet wrote: > On Sun, May 20, 2018 at 10:35:29PM +, Bart Van Assche wrote: > > On Sun, 2018-05-20 at 18:31 -0400, Kent Overstreet wrote: > > > On Sun, May 20, 2018 at 10:19:13PM +, Bart Van Assche wrote: > > > > On Sun, 2018-05-20 at 18:17

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Sun, 2018-05-20 at 19:00 -0400, Kent Overstreet wrote: > On Sun, May 20, 2018 at 10:35:29PM +, Bart Van Assche wrote: > > On Sun, 2018-05-20 at 18:31 -0400, Kent Overstreet wrote: > > > On Sun, May 20, 2018 at 10:19:13PM +, Bart Van Assche wrote: > > > > On Sun, 2018-05-20 at 18:17

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Sun, May 20, 2018 at 10:35:29PM +, Bart Van Assche wrote: > On Sun, 2018-05-20 at 18:31 -0400, Kent Overstreet wrote: > > On Sun, May 20, 2018 at 10:19:13PM +, Bart Van Assche wrote: > > > On Sun, 2018-05-20 at 18:17 -0400, Kent Overstreet wrote: > > > > On Fri, May 18, 2018 at

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Sun, May 20, 2018 at 10:35:29PM +, Bart Van Assche wrote: > On Sun, 2018-05-20 at 18:31 -0400, Kent Overstreet wrote: > > On Sun, May 20, 2018 at 10:19:13PM +, Bart Van Assche wrote: > > > On Sun, 2018-05-20 at 18:17 -0400, Kent Overstreet wrote: > > > > On Fri, May 18, 2018 at

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Sun, 2018-05-20 at 18:31 -0400, Kent Overstreet wrote: > On Sun, May 20, 2018 at 10:19:13PM +, Bart Van Assche wrote: > > On Sun, 2018-05-20 at 18:17 -0400, Kent Overstreet wrote: > > > On Fri, May 18, 2018 at 03:12:27PM +, Bart Van Assche wrote: > > > > On Fri, 2018-05-18 at 05:06

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Sun, 2018-05-20 at 18:31 -0400, Kent Overstreet wrote: > On Sun, May 20, 2018 at 10:19:13PM +, Bart Van Assche wrote: > > On Sun, 2018-05-20 at 18:17 -0400, Kent Overstreet wrote: > > > On Fri, May 18, 2018 at 03:12:27PM +, Bart Van Assche wrote: > > > > On Fri, 2018-05-18 at 05:06

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Sun, May 20, 2018 at 10:19:13PM +, Bart Van Assche wrote: > On Sun, 2018-05-20 at 18:17 -0400, Kent Overstreet wrote: > > On Fri, May 18, 2018 at 03:12:27PM +, Bart Van Assche wrote: > > > On Fri, 2018-05-18 at 05:06 -0400, Kent Overstreet wrote: > > > > On Thu, May 17, 2018 at

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Sun, May 20, 2018 at 10:19:13PM +, Bart Van Assche wrote: > On Sun, 2018-05-20 at 18:17 -0400, Kent Overstreet wrote: > > On Fri, May 18, 2018 at 03:12:27PM +, Bart Van Assche wrote: > > > On Fri, 2018-05-18 at 05:06 -0400, Kent Overstreet wrote: > > > > On Thu, May 17, 2018 at

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Sun, 2018-05-20 at 18:17 -0400, Kent Overstreet wrote: > On Fri, May 18, 2018 at 03:12:27PM +, Bart Van Assche wrote: > > On Fri, 2018-05-18 at 05:06 -0400, Kent Overstreet wrote: > > > On Thu, May 17, 2018 at 08:54:57PM +, Bart Van Assche wrote: > > > > With Jens' latest for-next

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Sun, 2018-05-20 at 18:17 -0400, Kent Overstreet wrote: > On Fri, May 18, 2018 at 03:12:27PM +, Bart Van Assche wrote: > > On Fri, 2018-05-18 at 05:06 -0400, Kent Overstreet wrote: > > > On Thu, May 17, 2018 at 08:54:57PM +, Bart Van Assche wrote: > > > > With Jens' latest for-next

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Fri, May 18, 2018 at 03:12:27PM +, Bart Van Assche wrote: > On Fri, 2018-05-18 at 05:06 -0400, Kent Overstreet wrote: > > On Thu, May 17, 2018 at 08:54:57PM +, Bart Van Assche wrote: > > > With Jens' latest for-next branch I hit the kernel warning shown below. > > > Can > > > you have

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Fri, May 18, 2018 at 03:12:27PM +, Bart Van Assche wrote: > On Fri, 2018-05-18 at 05:06 -0400, Kent Overstreet wrote: > > On Thu, May 17, 2018 at 08:54:57PM +, Bart Van Assche wrote: > > > With Jens' latest for-next branch I hit the kernel warning shown below. > > > Can > > > you have

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On 5/18/18 10:23 AM, Christoph Hellwig wrote: > On Fri, May 11, 2018 at 03:13:38PM -0600, Jens Axboe wrote: >> Looked over the series, and looks like both good cleanups and optimizations. >> If we can get the mempool patch sorted, I can apply this for 4.18. > > FYI, I agree on the actual cleanups

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On 5/18/18 10:23 AM, Christoph Hellwig wrote: > On Fri, May 11, 2018 at 03:13:38PM -0600, Jens Axboe wrote: >> Looked over the series, and looks like both good cleanups and optimizations. >> If we can get the mempool patch sorted, I can apply this for 4.18. > > FYI, I agree on the actual cleanups

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Fri, May 11, 2018 at 03:13:38PM -0600, Jens Axboe wrote: > Looked over the series, and looks like both good cleanups and optimizations. > If we can get the mempool patch sorted, I can apply this for 4.18. FYI, I agree on the actual cleanups and optimization, but we really shouldn't add new

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Fri, May 11, 2018 at 03:13:38PM -0600, Jens Axboe wrote: > Looked over the series, and looks like both good cleanups and optimizations. > If we can get the mempool patch sorted, I can apply this for 4.18. FYI, I agree on the actual cleanups and optimization, but we really shouldn't add new

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Fri, 2018-05-18 at 05:06 -0400, Kent Overstreet wrote: > On Thu, May 17, 2018 at 08:54:57PM +, Bart Van Assche wrote: > > With Jens' latest for-next branch I hit the kernel warning shown below. Can > > you have a look? > > Any hints on how to reproduce it? Sure. This is how I triggered

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Fri, 2018-05-18 at 05:06 -0400, Kent Overstreet wrote: > On Thu, May 17, 2018 at 08:54:57PM +, Bart Van Assche wrote: > > With Jens' latest for-next branch I hit the kernel warning shown below. Can > > you have a look? > > Any hints on how to reproduce it? Sure. This is how I triggered

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Thu, May 17, 2018 at 08:54:57PM +, Bart Van Assche wrote: > On Tue, 2018-05-08 at 21:33 -0400, Kent Overstreet wrote: > > [ ... ] > > Hello Kent, > > With Jens' latest for-next branch I hit the kernel warning shown below. Can > you have a look? Any hints on how to reproduce it? >

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Thu, May 17, 2018 at 08:54:57PM +, Bart Van Assche wrote: > On Tue, 2018-05-08 at 21:33 -0400, Kent Overstreet wrote: > > [ ... ] > > Hello Kent, > > With Jens' latest for-next branch I hit the kernel warning shown below. Can > you have a look? Any hints on how to reproduce it? >

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Tue, 2018-05-08 at 21:33 -0400, Kent Overstreet wrote: > [ ... ] Hello Kent, With Jens' latest for-next branch I hit the kernel warning shown below. Can you have a look? Thanks, Bart. == BUG: KASAN: use-after-free in

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On Tue, 2018-05-08 at 21:33 -0400, Kent Overstreet wrote: > [ ... ] Hello Kent, With Jens' latest for-next branch I hit the kernel warning shown below. Can you have a look? Thanks, Bart. == BUG: KASAN: use-after-free in

Re: [PATCH 00/10] Misc block layer patches for bcachefs

Thanks! On Mon, May 14, 2018 at 3:24 PM, Jens Axboe wrote: > On 5/8/18 7:33 PM, Kent Overstreet wrote: >> - Add separately allowed mempools, biosets: bcachefs uses both all over the >>place >> >> - Bit of utility code - bio_copy_data_iter(), zero_fill_bio_iter() >> >> -

Re: [PATCH 00/10] Misc block layer patches for bcachefs

Thanks! On Mon, May 14, 2018 at 3:24 PM, Jens Axboe wrote: > On 5/8/18 7:33 PM, Kent Overstreet wrote: >> - Add separately allowed mempools, biosets: bcachefs uses both all over the >>place >> >> - Bit of utility code - bio_copy_data_iter(), zero_fill_bio_iter() >> >> -

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On 5/8/18 7:33 PM, Kent Overstreet wrote: > - Add separately allowed mempools, biosets: bcachefs uses both all over the >place > > - Bit of utility code - bio_copy_data_iter(), zero_fill_bio_iter() > > - bio_list_copy_data(), the bi_next check - defensiveness because of a bug I >had

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On 5/8/18 7:33 PM, Kent Overstreet wrote: > - Add separately allowed mempools, biosets: bcachefs uses both all over the >place > > - Bit of utility code - bio_copy_data_iter(), zero_fill_bio_iter() > > - bio_list_copy_data(), the bi_next check - defensiveness because of a bug I >had

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On 5/8/18 7:33 PM, Kent Overstreet wrote: > - Add separately allowed mempools, biosets: bcachefs uses both all over the >place > > - Bit of utility code - bio_copy_data_iter(), zero_fill_bio_iter() > > - bio_list_copy_data(), the bi_next check - defensiveness because of a bug I >had

Re: [PATCH 00/10] Misc block layer patches for bcachefs

On 5/8/18 7:33 PM, Kent Overstreet wrote: > - Add separately allowed mempools, biosets: bcachefs uses both all over the >place > > - Bit of utility code - bio_copy_data_iter(), zero_fill_bio_iter() > > - bio_list_copy_data(), the bi_next check - defensiveness because of a bug I >had

[PATCH 00/10] Misc block layer patches for bcachefs

- Add separately allowed mempools, biosets: bcachefs uses both all over the place - Bit of utility code - bio_copy_data_iter(), zero_fill_bio_iter() - bio_list_copy_data(), the bi_next check - defensiveness because of a bug I had fun chasing down at one point - add some exports,

[PATCH 00/10] Misc block layer patches for bcachefs

- Add separately allowed mempools, biosets: bcachefs uses both all over the place - Bit of utility code - bio_copy_data_iter(), zero_fill_bio_iter() - bio_list_copy_data(), the bi_next check - defensiveness because of a bug I had fun chasing down at one point - add some exports,